Web Inspector: Fix modify-css-property-race.html test failures
authornvasilyev@apple.com <nvasilyev@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 5 Feb 2019 20:35:10 +0000 (20:35 +0000)
committernvasilyev@apple.com <nvasilyev@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 5 Feb 2019 20:35:10 +0000 (20:35 +0000)
https://bugs.webkit.org/show_bug.cgi?id=194282

Reviewed by Matt Baker.

Fix test failures introduced by r240946 by providing a message for expectGreaterThan assert,
so it doesn't log the actual values.

* inspector/css/modify-css-property-race-expected.txt:
* inspector/css/modify-css-property-race.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/inspector/css/modify-css-property-race-expected.txt
LayoutTests/inspector/css/modify-css-property-race.html

index 207c056..74908a7 100644 (file)
@@ -1,3 +1,16 @@
+2019-02-05  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Fix modify-css-property-race.html test failures
+        https://bugs.webkit.org/show_bug.cgi?id=194282
+
+        Reviewed by Matt Baker.
+
+        Fix test failures introduced by r240946 by providing a message for expectGreaterThan assert,
+        so it doesn't log the actual values.
+
+        * inspector/css/modify-css-property-race-expected.txt:
+        * inspector/css/modify-css-property-race.html:
+
 2019-02-05  Andy VanWagoner  <andy@vanwagoner.family>
 
         REGRESSION(r238848): ICU upgrade broke jsc-layout-tests.yaml/js/script-tests/intl-numberformat.js.layout
index b4e857d..1391254 100644 (file)
@@ -3,9 +3,9 @@ Testing that changes to "style" attribute made from page's JavaScript are ignore
 
 == Running test suite: ModifyCSSProperty
 -- Running test case: ModifyCSSPropertyRace.ChangeInlineStyle
-PASS: expectGreaterThan(43, 42)
-PASS: expectGreaterThan(43, 42)
-PASS: Value updated to "10px".
+PASS: Height should be greater than 42px.
+PASS: Height should be greater than 42px.
+PASS: Height should be 10px.
 PASS: CSSStyleDeclaration text should update.
-PASS: expectGreaterThanOrEqual(10, 10)
+PASS: Height should be greater or equal 10px.
 
index 83c691d..f72b4f0 100644 (file)
@@ -66,17 +66,17 @@ function test() {
             function styleDecorationUpdated(event) {
                 if (!updateCount) {
                     let valueNumber = parseInt(getProperty("height").rawValue);
-                    InspectorTest.expectGreaterThan(valueNumber, 42);
+                    InspectorTest.expectGreaterThan(valueNumber, 42, "Height should be greater than 42px.");
                 } else if (updateCount === 1) {
                     let valueNumber = parseInt(getProperty("height").rawValue);
-                    InspectorTest.expectGreaterThan(valueNumber, 42);
+                    InspectorTest.expectGreaterThan(valueNumber, 42, "Height should be greater than 42px.");
                     getProperty("height").rawValue = "10px";
                 } else if (updateCount === 2) {
-                    InspectorTest.expectEqual(getProperty("height").rawValue, "10px", `Value updated to "10px".`);
+                    InspectorTest.expectEqual(getProperty("height").rawValue, "10px", "Height should be 10px.");
                     InspectorTest.expectEqual(getInlineStyleDeclaration().text, "height: 10px;", "CSSStyleDeclaration text should update.");
                 } else {
                     let valueNumber = parseInt(getProperty("height").rawValue);
-                    InspectorTest.expectGreaterThanOrEqual(valueNumber, 10);
+                    InspectorTest.expectGreaterThanOrEqual(valueNumber, 10, "Height should be greater or equal 10px.");
 
                     InspectorTest.evaluateInPage("stopExpanding()");
                     WI.CSSStyleDeclaration.removeEventListener(WI.CSSStyleDeclaration.Event.PropertiesChanged, styleDecorationUpdated);