Unreviewed, a quick fix after r238919
authorjiewen_tan@apple.com <jiewen_tan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Dec 2018 19:35:35 +0000 (19:35 +0000)
committerjiewen_tan@apple.com <jiewen_tan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Dec 2018 19:35:35 +0000 (19:35 +0000)
Add an early return such that the error message is actually meaningful.

* UIProcess/WebAuthentication/Mock/MockHidService.cpp:
(WebKit::MockHidService::platformStartDiscovery):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp

index cd69503..5798c4a 100644 (file)
@@ -1,3 +1,12 @@
+2018-12-06  Jiewen Tan  <jiewen_tan@apple.com>
+
+        Unreviewed, a quick fix after r238919
+
+        Add an early return such that the error message is actually meaningful.
+
+        * UIProcess/WebAuthentication/Mock/MockHidService.cpp:
+        (WebKit::MockHidService::platformStartDiscovery):
+
 2018-12-06  Alex Christensen  <achristensen@webkit.org>
 
         Remove unused LoaderStrategy::storeDerivedDataToCache and associated dead code
index 958764f..2a43f1d 100644 (file)
@@ -41,8 +41,10 @@ MockHidService::MockHidService(Observer& observer, const MockWebAuthenticationCo
 
 void MockHidService::platformStartDiscovery()
 {
-    if (!!m_configuration.hid)
+    if (!!m_configuration.hid) {
         deviceAdded(nullptr);
+        return;
+    }
     LOG_ERROR("No hid authenticators is available.");
 }