Remove [LegacyParent] from CodeGeneratorGObject.pm, and rename it to [JSLegacyParent]
authorharaken@chromium.org <haraken@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Feb 2012 09:54:53 +0000 (09:54 +0000)
committerharaken@chromium.org <haraken@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Feb 2012 09:54:53 +0000 (09:54 +0000)
https://bugs.webkit.org/show_bug.cgi?id=77706

Reviewed by Adam Barth.

This patch removes dead code about [LegacyParent] from CodeGeneratorGObject.pm,
and renames [LegacyParent] to [JSLegacyParent].

No tests. No changes in behavior.

* bindings/scripts/CodeGeneratorGObject.pm:
(Generate):
* bindings/scripts/CodeGeneratorJS.pm:
(GetParentClassName):
(GenerateHeader):
(GenerateImplementation):
* page/DOMWindow.idl:
* workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm
Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
Source/WebCore/page/DOMWindow.idl
Source/WebCore/workers/WorkerContext.idl

index 6e2031c..e48981b 100644 (file)
@@ -1,3 +1,24 @@
+2012-02-03  Kentaro Hara  <haraken@chromium.org>
+
+        Remove [LegacyParent] from CodeGeneratorGObject.pm, and rename it to [JSLegacyParent]
+        https://bugs.webkit.org/show_bug.cgi?id=77706
+
+        Reviewed by Adam Barth.
+
+        This patch removes dead code about [LegacyParent] from CodeGeneratorGObject.pm,
+        and renames [LegacyParent] to [JSLegacyParent].
+
+        No tests. No changes in behavior.
+
+        * bindings/scripts/CodeGeneratorGObject.pm:
+        (Generate):
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GetParentClassName):
+        (GenerateHeader):
+        (GenerateImplementation):
+        * page/DOMWindow.idl:
+        * workers/WorkerContext.idl:
+
 2012-02-03  Pavel Feldman  <pfeldman@google.com>
 
         Web Inspector: preserve elements panel selection upon node drag'n'drop
index 358b3a9..5d26414 100644 (file)
@@ -1231,9 +1231,6 @@ EOF
 sub Generate {
     my ($object, $dataNode) = @_;
 
-    my $hasLegacyParent = $dataNode->extendedAttributes->{"LegacyParent"};
-    my $hasRealParent = @{$dataNode->parents} > 0;
-    my $hasParent = $hasLegacyParent || $hasRealParent;
     my $parentClassName = GetParentClassName($dataNode);
     my $parentGObjType = GetParentGObjType($dataNode);
     my $interfaceName = $dataNode->name;
index 09443a5..917c356 100644 (file)
@@ -184,7 +184,7 @@ sub GetParentClassName
 {
     my $dataNode = shift;
 
-    return $dataNode->extendedAttributes->{"LegacyParent"} if $dataNode->extendedAttributes->{"LegacyParent"};
+    return $dataNode->extendedAttributes->{"JSLegacyParent"} if $dataNode->extendedAttributes->{"JSLegacyParent"};
     return "JSDOMWrapper" if (@{$dataNode->parents} eq 0);
     return "JS" . $codeGenerator->StripModule($dataNode->parents(0));
 }
@@ -652,7 +652,7 @@ sub GenerateHeader
         $codeGenerator->AddMethodsConstantsAndAttributesFromParentClasses($dataNode, \@ancestorInterfaceNames);
     }
 
-    my $hasLegacyParent = $dataNode->extendedAttributes->{"LegacyParent"};
+    my $hasLegacyParent = $dataNode->extendedAttributes->{"JSLegacyParent"};
     my $hasRealParent = @{$dataNode->parents} > 0;
     my $hasParent = $hasLegacyParent || $hasRealParent;
     my $parentClassName = GetParentClassName($dataNode);
@@ -1323,7 +1323,7 @@ sub GenerateImplementation
     my $className = "JS$interfaceName";
     my $implClassName = $interfaceName;
 
-    my $hasLegacyParent = $dataNode->extendedAttributes->{"LegacyParent"};
+    my $hasLegacyParent = $dataNode->extendedAttributes->{"JSLegacyParent"};
     my $hasRealParent = @{$dataNode->parents} > 0;
     my $hasParent = $hasLegacyParent || $hasRealParent;
     my $parentClassName = GetParentClassName($dataNode);
index dc44434..61b2caa 100644 (file)
@@ -40,7 +40,7 @@ module window {
         ExtendsDOMGlobalObject,
         GenerateNativeConverter,
         ReplaceableConstructor,
-        LegacyParent=JSDOMWindowBase
+        JSLegacyParent=JSDOMWindowBase
     ] DOMWindow {
         // DOM Level 0
         attribute [Replaceable] Screen screen;
index d04f06b..66a3968 100644 (file)
@@ -33,7 +33,7 @@ module threads {
         EventTarget,
         ExtendsDOMGlobalObject,
         IsWorkerContext,
-        LegacyParent=JSWorkerContextBase,
+        JSLegacyParent=JSWorkerContextBase,
         NoStaticTables,
         OmitConstructor
     ] WorkerContext {