[V8][Refactoring] Remove deserializeAndSetProperty()
authorharaken@chromium.org <haraken@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 Apr 2012 16:44:10 +0000 (16:44 +0000)
committerharaken@chromium.org <haraken@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 Apr 2012 16:44:10 +0000 (16:44 +0000)
from SerializedScriptValue.cpp
https://bugs.webkit.org/show_bug.cgi?id=84662

Reviewed by Nate Chapin.

SerializedScriptValue::deserializeAndSetProperty() is no
longer used. This patch removes it.

No tests. No change in behavior.

* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/SerializedScriptValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/bindings/v8/SerializedScriptValue.cpp
Source/WebCore/bindings/v8/SerializedScriptValue.h

index 1f92cc2..bb07c9a 100644 (file)
@@ -1,5 +1,21 @@
 2012-04-24  Kentaro Hara  <haraken@chromium.org>
 
+        [V8][Refactoring] Remove deserializeAndSetProperty()
+        from SerializedScriptValue.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=84662
+
+        Reviewed by Nate Chapin.
+
+        SerializedScriptValue::deserializeAndSetProperty() is no
+        longer used. This patch removes it.
+
+        No tests. No change in behavior.
+
+        * bindings/v8/SerializedScriptValue.cpp:
+        * bindings/v8/SerializedScriptValue.h:
+
+2012-04-24  Kentaro Hara  <haraken@chromium.org>
+
         [V8] Pass Isolate to setDOMException() in CodeGeneratorV8.pm
         https://bugs.webkit.org/show_bug.cgi?id=84660
 
index 394617c..d4bd132 100644 (file)
@@ -2059,20 +2059,6 @@ private:
 };
 
 } // namespace
-void SerializedScriptValue::deserializeAndSetProperty(v8::Handle<v8::Object> object, const char* propertyName,
-                                                      v8::PropertyAttribute attribute, SerializedScriptValue* value)
-{
-    if (!value)
-        return;
-    v8::Handle<v8::Value> deserialized = value->deserialize();
-    object->ForceSet(v8::String::NewSymbol(propertyName), deserialized, attribute);
-}
-
-void SerializedScriptValue::deserializeAndSetProperty(v8::Handle<v8::Object> object, const char* propertyName,
-                                                      v8::PropertyAttribute attribute, PassRefPtr<SerializedScriptValue> value)
-{
-    deserializeAndSetProperty(object, propertyName, attribute, value.get());
-}
 
 PassRefPtr<SerializedScriptValue> SerializedScriptValue::create(v8::Handle<v8::Value> value,
                                                                 MessagePortArray* messagePorts, ArrayBufferArray* arrayBuffers,
index d629ac4..7fc668d 100644 (file)
@@ -45,11 +45,6 @@ typedef Vector<RefPtr<WTF::ArrayBuffer>, 1> ArrayBufferArray;
 
 class SerializedScriptValue : public ThreadSafeRefCounted<SerializedScriptValue> {
 public:
-    static void deserializeAndSetProperty(v8::Handle<v8::Object>, const char* propertyName,
-                                          v8::PropertyAttribute, SerializedScriptValue*);
-    static void deserializeAndSetProperty(v8::Handle<v8::Object>, const char* propertyName,
-                                          v8::PropertyAttribute, PassRefPtr<SerializedScriptValue>);
-
     // If a serialization error occurs (e.g., cyclic input value) this
     // function returns an empty representation, schedules a V8 exception to
     // be thrown using v8::ThrowException(), and sets |didThrow|. In this case