Add system tracing points for compositing updates, and touch-event dispatching
authorsimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 30 Aug 2019 18:23:29 +0000 (18:23 +0000)
committersimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 30 Aug 2019 18:23:29 +0000 (18:23 +0000)
https://bugs.webkit.org/show_bug.cgi?id=201327

Reviewed by Alex Christensen.
Source/WebCore:

TraceScope in RenderLayerCompositor::updateCompositingLayers().

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers):

Source/WebKit:

TraceScope in EventDispatcher::dispatchTouchEvents().

* WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::dispatchTouchEvents):

Source/WTF:

* wtf/SystemTracing.h:

Tools:

* Tracing/SystemTracePoints.plist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WTF/ChangeLog
Source/WTF/wtf/SystemTracing.h
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderLayerCompositor.cpp
Source/WebKit/ChangeLog
Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp
Tools/ChangeLog
Tools/Tracing/SystemTracePoints.plist

index cf83db5..497b913 100644 (file)
@@ -1,3 +1,12 @@
+2019-08-30  Simon Fraser  <simon.fraser@apple.com>
+
+        Add system tracing points for compositing updates, and touch-event dispatching
+        https://bugs.webkit.org/show_bug.cgi?id=201327
+
+        Reviewed by Alex Christensen.
+
+        * wtf/SystemTracing.h:
+
 2019-08-30  Keith Rollin  <krollin@apple.com>
 
         Remove AppKitCompatibilityDeclarations.h
index e22aac5..9b970b3 100644 (file)
@@ -78,11 +78,14 @@ enum TracePointCode {
     DisplayRefreshDispatchingToMainThread,
     ComputeEventRegionsStart,
     ComputeEventRegionsEnd,
-
     ScheduleRenderingUpdate,
     TriggerRenderingUpdate,
     RenderingUpdateStart,
     RenderingUpdateEnd,
+    CompositingUpdateStart,
+    CompositingUpdateEnd,
+    DispatchTouchEventsStart,
+    DispatchTouchEventsEnd,
 
     WebKitRange = 10000,
     WebHTMLViewPaintStart,
index 29b7e32..a7bc10c 100644 (file)
@@ -1,3 +1,15 @@
+2019-08-30  Simon Fraser  <simon.fraser@apple.com>
+
+        Add system tracing points for compositing updates, and touch-event dispatching
+        https://bugs.webkit.org/show_bug.cgi?id=201327
+
+        Reviewed by Alex Christensen.
+
+        TraceScope in RenderLayerCompositor::updateCompositingLayers().
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::updateCompositingLayers):
+
 2019-08-30  Brent Fulgham  <bfulgham@apple.com>
 
         [FTW] Use DirectX SharedResource as basis for SharedBitmap
index a64b028..b3537b1 100644 (file)
@@ -67,6 +67,7 @@
 #include <wtf/HexNumber.h>
 #include <wtf/MemoryPressureHandler.h>
 #include <wtf/SetForScope.h>
+#include <wtf/SystemTracing.h>
 #include <wtf/text/CString.h>
 #include <wtf/text/StringBuilder.h>
 #include <wtf/text/StringConcatenateNumbers.h>
@@ -681,6 +682,8 @@ bool RenderLayerCompositor::updateCompositingLayers(CompositingUpdateType update
 {
     LOG_WITH_STREAM(Compositing, stream << "RenderLayerCompositor " << this << " updateCompositingLayers " << updateType << " contentLayersCount " << m_contentLayersCount);
 
+    TraceScope tracingScope(CompositingUpdateStart, CompositingUpdateEnd);
+
 #if ENABLE(TREE_DEBUGGING)
     if (compositingLogEnabled())
         showPaintOrderTree(m_renderView.layer());
index 04cb3f8..6cf9733 100644 (file)
@@ -1,3 +1,15 @@
+2019-08-30  Simon Fraser  <simon.fraser@apple.com>
+
+        Add system tracing points for compositing updates, and touch-event dispatching
+        https://bugs.webkit.org/show_bug.cgi?id=201327
+
+        Reviewed by Alex Christensen.
+        
+        TraceScope in EventDispatcher::dispatchTouchEvents().
+
+        * WebProcess/WebPage/EventDispatcher.cpp:
+        (WebKit::EventDispatcher::dispatchTouchEvents):
+
 2019-08-30  Brent Fulgham  <bfulgham@apple.com>
 
         [FTW] Use DirectX SharedResource as basis for SharedBitmap
index cac188b..cf39384 100644 (file)
@@ -36,6 +36,7 @@
 #include <WebCore/WheelEventTestTrigger.h>
 #include <wtf/MainThread.h>
 #include <wtf/RunLoop.h>
+#include <wtf/SystemTracing.h>
 
 #if ENABLE(ASYNC_SCROLLING)
 #include <WebCore/AsyncScrollingCoordinator.h>
@@ -194,6 +195,8 @@ void EventDispatcher::touchEvent(PageIdentifier pageID, const WebKit::WebTouchEv
 
 void EventDispatcher::dispatchTouchEvents()
 {
+    TraceScope traceScope(DispatchTouchEventsStart, DispatchTouchEventsEnd);
+
     HashMap<PageIdentifier, TouchEventQueue> localCopy;
     {
         LockHolder locker(&m_touchEventsLock);
index b861556..03500b5 100644 (file)
@@ -1,3 +1,12 @@
+2019-08-30  Simon Fraser  <simon.fraser@apple.com>
+
+        Add system tracing points for compositing updates, and touch-event dispatching
+        https://bugs.webkit.org/show_bug.cgi?id=201327
+
+        Reviewed by Alex Christensen.
+
+        * Tracing/SystemTracePoints.plist:
+
 2019-08-30  Keith Rollin  <krollin@apple.com>
 
         Simplify PLATFORM expression
index b44dc43..e8e96bf 100644 (file)
                  <key>CodeEnd</key>
                  <string>5031</string>
              </dict>
+
+             <dict>
+                 <key>Name</key>
+                 <string>Compositing update</string>
+                 <key>Type</key>
+                 <string>Interval</string>
+                 <key>Component</key>
+                 <string>47</string>
+                 <key>CodeBegin</key>
+                 <string>5032</string>
+                 <key>CodeEnd</key>
+                 <string>5033</string>
+             </dict>
+             <dict>
+                 <key>Name</key>
+                 <string>DispatchTouchEvents</string>
+                 <key>Type</key>
+                 <string>Interval</string>
+                 <key>Component</key>
+                 <string>47</string>
+                 <key>CodeBegin</key>
+                 <string>5034</string>
+                 <key>CodeEnd</key>
+                 <string>5035</string>
+             </dict>
              <dict>
                  <key>Name</key>
                  <string>Paint WebHTMLView</string>