REGRESSION (r231817?): Layout Test media/track/track-delete-during-setup.html is...
authorjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Jun 2018 20:37:23 +0000 (20:37 +0000)
committerjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Jun 2018 20:37:23 +0000 (20:37 +0000)
https://bugs.webkit.org/show_bug.cgi?id=185889
<rdar://problem/40583180>

Reviewed by Eric Carlson.

Source/WebCore:

Explicitly update the network and ready states when detaching the AVPlayerItem
from the AVPlayer.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldBufferData):

LayoutTests:

Modify the track-delete-during-setup.html test to end on video element suspend in
addition to canplaythrough.

* media/track/track-delete-during-setup.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@232557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/media/track/track-delete-during-setup.html
Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

index 59d3e1c..cb59f87 100644 (file)
@@ -1,5 +1,18 @@
 2018-06-06  Jer Noble  <jer.noble@apple.com>
 
+        REGRESSION (r231817?): Layout Test media/track/track-delete-during-setup.html is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=185889
+        <rdar://problem/40583180>
+
+        Reviewed by Eric Carlson.
+
+        Modify the track-delete-during-setup.html test to end on video element suspend in
+        addition to canplaythrough.
+
+        * media/track/track-delete-during-setup.html:
+
+2018-06-06  Jer Noble  <jer.noble@apple.com>
+
         Regions outside of the fullscreen window are exposed during zoom operations
         https://bugs.webkit.org/show_bug.cgi?id=186330
         <rdar://problem/34698009>
index c249bbf..01c3bd6 100644 (file)
                 setTimeout("endTest()", 100);
             }
 
+            function suspend()
+            {
+                setTimeout("endTest()", 100);
+            }
+
             function start()
             {
                 consoleWrite("<feOffset>");
@@ -37,5 +42,5 @@
             }
         </script>
     <body onload="start()">
-<command><aside><kbd><video oncanplaythrough="canplaythrough()" 
+<command><aside><kbd><video oncanplaythrough="canplaythrough()" onsuspend="suspend()">
             <track src="captions-webvtt/metadata.vtt" onload="metadataTrackLoaded()">
index 2eaf265..b08b3c2 100644 (file)
@@ -1,3 +1,17 @@
+2018-06-06  Jer Noble  <jer.noble@apple.com>
+
+        REGRESSION (r231817?): Layout Test media/track/track-delete-during-setup.html is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=185889
+        <rdar://problem/40583180>
+
+        Reviewed by Eric Carlson.
+
+        Explicitly update the network and ready states when detaching the AVPlayerItem
+        from the AVPlayer.
+
+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+        (WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldBufferData):
+
 2018-06-06  Antoine Quint  <graouts@apple.com>
 
         Use the default label for snapshotted plug-ins if no mime-type is available
index 9ac05c2..48ce779 100644 (file)
@@ -3057,6 +3057,7 @@ void MediaPlayerPrivateAVFoundationObjC::setShouldBufferData(bool shouldBuffer)
         return;
 
     setAVPlayerItem(shouldBuffer ? m_avPlayerItem.get() : nil);
+    updateStates();
 }
 
 #if ENABLE(DATACUE_VALUE)