Animometer: graphs should not do interpolation
authorsimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 21 Nov 2015 03:05:50 +0000 (03:05 +0000)
committersimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 21 Nov 2015 03:05:50 +0000 (03:05 +0000)
https://bugs.webkit.org/show_bug.cgi?id=151526

Reviewed by Simon Fraser.

Having the graphs do interpolation is misleading, because you can't see the actual data.

Also remove "shape-rendering: crispEdges;" so the lines get antialiased.

* Animometer/runner/resources/animometer.css:
(section#test-graph > data > svg): Deleted.
* Animometer/runner/resources/graph.js:
(graph): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@192715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

PerformanceTests/Animometer/runner/resources/animometer.css
PerformanceTests/Animometer/runner/resources/graph.js
PerformanceTests/ChangeLog

index 66b86e0..ef7fae6 100644 (file)
@@ -419,7 +419,6 @@ section#test-graph > data {
 
 section#test-graph > data > svg {
     fill: none;
-    shape-rendering: crispEdges;  
 }
 
 .axis path,
index f976d7c..021f5f5 100644 (file)
@@ -30,12 +30,10 @@ function graph(selector, margins, axes, samples, samplingTimeOffset)
             .orient("right");
 
     var lineLeft = d3.svg.line()
-            .interpolate("basis")
             .x(function(d) { return x(d.timeOffset); })
             .y(function(d) { return yLeft(d.values[0]); });
 
     var lineRight = d3.svg.line()
-            .interpolate("basis")
             .x(function(d) { return x(d.timeOffset); })
             .y(function(d) { return yRight(d.values[1]); });
 
index 53e9db3..dbc4231 100644 (file)
@@ -1,3 +1,19 @@
+2015-11-20  Simon Fraser  <simon.fraser@apple.com>
+
+        Animometer: graphs should not do interpolation
+        https://bugs.webkit.org/show_bug.cgi?id=151526
+
+        Reviewed by Simon Fraser.
+        
+        Having the graphs do interpolation is misleading, because you can't see the actual data.
+        
+        Also remove "shape-rendering: crispEdges;" so the lines get antialiased.
+
+        * Animometer/runner/resources/animometer.css:
+        (section#test-graph > data > svg): Deleted.
+        * Animometer/runner/resources/graph.js:
+        (graph): Deleted.
+
 2015-11-19  Said Abou-Hallawa  <sabouhallawa@apple.com>
 
         Calculate the graphics benchmark test gain adaptively