[CMake] Generated sources depending on SelectorPseudoClassAndCompatibilityElementMap...
authorcarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 22 Jun 2018 13:22:13 +0000 (13:22 +0000)
committercarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 22 Jun 2018 13:22:13 +0000 (13:22 +0000)
https://bugs.webkit.org/show_bug.cgi?id=186911

Reviewed by Michael Catanzaro.

This is causing test fullscreen/fullscreen-env.html to fail since it was added in r233066 in the bots that
didn't start a clean build. The problem is that the CMake command to generate
SelectorPseudoClassAndCompatibilityElementMap.cpp doesn't depend on
SelectorPseudoClassAndCompatibilityElementMap.in.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/CMakeLists.txt
Source/WebCore/ChangeLog

index b02858c..a3a19ce 100644 (file)
@@ -1740,14 +1740,16 @@ ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES(${WEBCORE_DIR}/css/CSSPrimitiveValueMapp
 # Generate CSS Selector pseudo type name to value maps.
 add_custom_command(
     OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoClassAndCompatibilityElementMap.gperf ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoClassAndCompatibilityElementMap.cpp
-    MAIN_DEPENDENCY ${WEBCORE_DIR}/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
+    MAIN_DEPENDENCY ${WEBCORE_DIR}/css/SelectorPseudoClassAndCompatibilityElementMap.in
+    DEPENDS ${WEBCORE_DIR}/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
     WORKING_DIRECTORY ${DERIVED_SOURCES_WEBCORE_DIR}
     COMMAND ${PYTHON_EXECUTABLE} ${WEBCORE_DIR}/css/makeSelectorPseudoClassAndCompatibilityElementMap.py ${WEBCORE_DIR}/css/SelectorPseudoClassAndCompatibilityElementMap.in "${GPERF_EXECUTABLE}" "${FEATURE_DEFINES_WITH_SPACE_SEPARATOR}"
     VERBATIM)
 list(APPEND WebCore_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoClassAndCompatibilityElementMap.cpp)
 add_custom_command(
     OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoElementTypeMap.gperf ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoElementTypeMap.cpp
-    MAIN_DEPENDENCY ${WEBCORE_DIR}/css/makeSelectorPseudoElementsMap.py
+    MAIN_DEPENDENCY ${WEBCORE_DIR}/css/SelectorPseudoElementTypeMap.in
+    DEPENDS ${WEBCORE_DIR}/css/makeSelectorPseudoElementsMap.py
     WORKING_DIRECTORY ${DERIVED_SOURCES_WEBCORE_DIR}
     COMMAND ${PYTHON_EXECUTABLE} ${WEBCORE_DIR}/css/makeSelectorPseudoElementsMap.py ${WEBCORE_DIR}/css/SelectorPseudoElementTypeMap.in "${GPERF_EXECUTABLE}" "${FEATURE_DEFINES_WITH_SPACE_SEPARATOR}"
     VERBATIM)
index 25497b0..2617dc1 100644 (file)
@@ -1,3 +1,17 @@
+2018-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [CMake] Generated sources depending on SelectorPseudoClassAndCompatibilityElementMap.in are not regenerated
+        https://bugs.webkit.org/show_bug.cgi?id=186911
+
+        Reviewed by Michael Catanzaro.
+
+        This is causing test fullscreen/fullscreen-env.html to fail since it was added in r233066 in the bots that
+        didn't start a clean build. The problem is that the CMake command to generate
+        SelectorPseudoClassAndCompatibilityElementMap.cpp doesn't depend on
+        SelectorPseudoClassAndCompatibilityElementMap.in.
+
+        * CMakeLists.txt:
+
 2018-06-22  Miguel Gomez  <magomez@igalia.com>
 
         [WPE][ThreadedRendering] WPE crashes rendering some pieces of text when using ThreadedRendering