Unreviewed, remove FIXME for https://bugs.webkit.org/show_bug.cgi?id=156457 and repla...

with a comment that describes what we do now.

* bytecode/PolymorphicAccess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@199389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
index 69d3d2e..bd5d623 100644 (file)
--- a/Source/JavaScriptCore/ChangeLog
+++ b/Source/JavaScriptCore/ChangeLog
@@ -1,3 +1,10 @@
+2016-04-12  Filip Pizlo  <fpizlo@apple.com>
+
+        Unreviewed, remove FIXME for https://bugs.webkit.org/show_bug.cgi?id=156457 and replace it
+        with a comment that describes what we do now.
+
+        * bytecode/PolymorphicAccess.h:
+
 2016-04-12  Saam barati  <sbarati@apple.com>
 
         isLocked() assertion broke builds because ConcurrentJITLock isn't always a real lock.

diff --git a/Source/JavaScriptCore/bytecode/PolymorphicAccess.h b/Source/JavaScriptCore/bytecode/PolymorphicAccess.h
index 26f9fa8..1234245 100644 (file)
--- a/Source/JavaScriptCore/bytecode/PolymorphicAccess.h
+++ b/Source/JavaScriptCore/bytecode/PolymorphicAccess.h
@@ -84,10 +84,9 @@ struct AccessGenerationState;
 //
 // An AccessCase may be destroyed while in any of these states.
 //
-// Note that right now, an AccessCase goes from Primordial to Generated quite quickly.
-// FIXME: Make it possible for PolymorphicAccess to hold onto AccessCases that haven't been
-// generated. That would allow us to significantly reduce the number of regeneration events.
-// https://bugs.webkit.org/show_bug.cgi?id=156457
+// We will sometimes buffer committed AccessCases in the PolymorphicAccess object before generating
+// code. This allows us to only regenerate once we've accumulated (hopefully) more than one new
+// AccessCase.
 class AccessCase {
     WTF_MAKE_NONCOPYABLE(AccessCase);
     WTF_MAKE_FAST_ALLOCATED;