WebCore:
authorsullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Jul 2005 22:55:07 +0000 (22:55 +0000)
committersullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Jul 2005 22:55:07 +0000 (22:55 +0000)
        Reviewed by Vicki Murley.

        - removed some form-related methods that weren't being used anywhere, in preparation
        for weaning WebKit's WebFormDelegate protocol from NSView.

        Test cases added: none, no behavior change

        * kwq/KWQTextField.mm:
        * kwq/WebCoreBridge.h:
        removed these methods:
        -control:didFailToFormatString:errorDescription:
        -control:didFailToValidatePartialString:errorDescription:
        -control:isValidObject:

WebKit:

        Reviewed by Vicki Murley.

        - removed some form-related methods that weren't being used anywhere, in preparation
        for weaning WebKit's WebFormDelegate protocol from NSView.

        * WebCoreSupport.subproj/WebBridge.m:
        * WebView.subproj/WebFormDelegate.h:
        * WebView.subproj/WebFormDelegate.m:
        removed these methods:
        -control:didFailToFormatString:errorDescription:
        -control:didFailToValidatePartialString:errorDescription:
        -control:isValidObject:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog-2005-08-23
WebCore/kwq/KWQTextField.mm
WebCore/kwq/WebCoreBridge.h
WebKit/ChangeLog
WebKit/WebCoreSupport.subproj/WebBridge.m
WebKit/WebView.subproj/WebFormDelegate.h
WebKit/WebView.subproj/WebFormDelegate.m

index 0a444be..3ab97b9 100644 (file)
@@ -1,3 +1,19 @@
+2005-07-20  John Sullivan  <sullivan@apple.com>
+
+        Reviewed by Vicki Murley.
+        
+        - removed some form-related methods that weren't being used anywhere, in preparation
+        for weaning WebKit's WebFormDelegate protocol from NSView.
+
+        Test cases added: none, no behavior change
+
+        * kwq/KWQTextField.mm:
+        * kwq/WebCoreBridge.h:
+        removed these methods:
+        -control:didFailToFormatString:errorDescription:
+        -control:didFailToValidatePartialString:errorDescription:
+        -control:isValidObject:
+
 2005-07-20  Adele Peterson  <adele@apple.com>
 
         Rolling fix for <rdar://problem/4046602> back in.
index 5f70b01..3d57388 100644 (file)
     return [bridge control:control textShouldEndEditing:fieldEditor];
 }
 
-- (BOOL)control:(NSControl *)control didFailToFormatString:(NSString *)string errorDescription:(NSString *)error
-{
-    if (!widget)
-       return NO;
-    
-    WebCoreBridge *bridge = KWQKHTMLPart::bridgeForWidget(widget);
-    return [bridge control:control didFailToFormatString:string errorDescription:error];
-}
-
-- (void)control:(NSControl *)control didFailToValidatePartialString:(NSString *)string errorDescription:(NSString *)error
-{
-    if (!widget)
-       return;
-    
-    WebCoreBridge *bridge = KWQKHTMLPart::bridgeForWidget(widget);
-    [bridge control:control didFailToValidatePartialString:string errorDescription:error];
-}
-
-- (BOOL)control:(NSControl *)control isValidObject:(id)obj
-{
-    if (!widget)
-       return NO;
-    
-    WebCoreBridge *bridge = KWQKHTMLPart::bridgeForWidget(widget);
-    return [bridge control:control isValidObject:obj];
-}
-
 - (BOOL)control:(NSControl *)control textView:(NSTextView *)textView doCommandBySelector:(SEL)commandSelector
 {
     if (!widget)
index a2e5d8a..12e183f 100644 (file)
@@ -590,9 +590,6 @@ typedef enum
 
 - (BOOL)control:(NSControl *)control textShouldBeginEditing:(NSText *)fieldEditor;
 - (BOOL)control:(NSControl *)control textShouldEndEditing:(NSText *)fieldEditor;
-- (BOOL)control:(NSControl *)control didFailToFormatString:(NSString *)string errorDescription:(NSString *)error;
-- (void)control:(NSControl *)control didFailToValidatePartialString:(NSString *)string errorDescription:(NSString *)error;
-- (BOOL)control:(NSControl *)control isValidObject:(id)obj;
 - (BOOL)control:(NSControl *)control textView:(NSTextView *)textView doCommandBySelector:(SEL)commandSelector;
 - (BOOL)control:(NSControl *)control textView:(NSTextView *)textView shouldHandleEvent:(NSEvent *)event;
 
index 36317c4..26ac18a 100644 (file)
@@ -1,3 +1,18 @@
+2005-07-20  John Sullivan  <sullivan@apple.com>
+
+        Reviewed by Vicki Murley.
+
+        - removed some form-related methods that weren't being used anywhere, in preparation
+        for weaning WebKit's WebFormDelegate protocol from NSView.
+
+        * WebCoreSupport.subproj/WebBridge.m:
+        * WebView.subproj/WebFormDelegate.h:
+        * WebView.subproj/WebFormDelegate.m:
+        removed these methods:
+        -control:didFailToFormatString:errorDescription:
+        -control:didFailToValidatePartialString:errorDescription:
+        -control:isValidObject:
+
 2005-07-20  Adele Peterson  <adele@apple.com>
 
           Merged fix for:
index b5c4c40..6e4c718 100644 (file)
@@ -1265,24 +1265,6 @@ static id <WebFormDelegate> formDelegate(WebBridge *self)
     return [formDelegate(self) control:control textShouldEndEditing:fieldEditor inFrame:_frame];
 }
 
-- (BOOL)control:(NSControl *)control didFailToFormatString:(NSString *)string errorDescription:(NSString *)error
-{
-    FormDelegateLog(control);
-    return [formDelegate(self) control:control didFailToFormatString:string errorDescription:error inFrame:_frame];
-}
-
-- (void)control:(NSControl *)control didFailToValidatePartialString:(NSString *)string errorDescription:(NSString *)error
-{
-    FormDelegateLog(control);
-    [formDelegate(self) control:control didFailToValidatePartialString:string errorDescription:error inFrame:_frame];
-}
-
-- (BOOL)control:(NSControl *)control isValidObject:(id)obj
-{
-    FormDelegateLog(control);
-    return [formDelegate(self) control:control isValidObject:obj inFrame:_frame];
-}
-
 - (BOOL)control:(NSControl *)control textView:(NSTextView *)textView doCommandBySelector:(SEL)commandSelector
 {
     FormDelegateLog(control);
index 9d596f8..fa00894 100644 (file)
@@ -61,9 +61,6 @@
 
 - (BOOL)control:(NSControl *)control textShouldBeginEditing:(NSText *)fieldEditor inFrame:(WebFrame *)frame;
 - (BOOL)control:(NSControl *)control textShouldEndEditing:(NSText *)fieldEditor inFrame:(WebFrame *)frame;
-- (BOOL)control:(NSControl *)control didFailToFormatString:(NSString *)string errorDescription:(NSString *)error inFrame:(WebFrame *)frame;
-- (void)control:(NSControl *)control didFailToValidatePartialString:(NSString *)string errorDescription:(NSString *)error inFrame:(WebFrame *)frame;
-- (BOOL)control:(NSControl *)control isValidObject:(id)obj inFrame:(WebFrame *)frame;
 
 - (BOOL)control:(NSControl *)control textView:(NSTextView *)textView doCommandBySelector:(SEL)commandSelector inFrame:(WebFrame *)frame;
 - (BOOL)control:(NSControl *)control textView:(NSTextView *)textView shouldHandleEvent:(NSEvent *)event inFrame:(WebFrame *)frame;
index 1ebaddd..2d44d4b 100644 (file)
@@ -63,20 +63,6 @@ static WebFormDelegate *sharedDelegate = nil;
     return YES;
 }
 
-- (BOOL)control:(NSControl *)control didFailToFormatString:(NSString *)string errorDescription:(NSString *)error inFrame:(WebFrame *)frame
-{
-    return YES;
-}
-
-- (void)control:(NSControl *)control didFailToValidatePartialString:(NSString *)string errorDescription:(NSString *)error inFrame:(WebFrame *)frame
-{
-}
-
-- (BOOL)control:(NSControl *)control isValidObject:(id)obj inFrame:(WebFrame *)frame
-{
-    return YES;
-}
-
 - (BOOL)control:(NSControl *)control textView:(NSTextView *)textView doCommandBySelector:(SEL)commandSelector inFrame:(WebFrame *)frame
 {
     return NO;