https://bugs.webkit.org/show_bug.cgi?id=173046
Reviewed by Andy Estes.
Source/WebCore:
Remove a couple of unneeded includes from RenderElement.h, and then clean up all the
follow-on compile errors that causes. Mostly, these errors are fixed by including the
correct headers at the point of use; otherwise, they're solved by forward-declaring types
and in one case by moving default constructors implementation to the cpp file from the header.
* css/parser/SizesAttributeParser.cpp:
* editing/cocoa/EditorCocoa.mm:
* platform/mac/PasteboardMac.mm:
* rendering/InlineIterator.h:
(WebCore::embedCharFromDirection):
* rendering/RenderBoxModelObject.h:
* rendering/RenderElement.cpp:
* rendering/RenderElement.h:
* rendering/RenderIterator.h:
* rendering/RenderLineBreak.cpp:
* rendering/RenderQuote.cpp:
* rendering/RenderText.h:
* rendering/SimpleLineLayoutPagination.cpp:
* rendering/SimpleLineLayoutTextFragmentIterator.cpp:
* rendering/TextAutoSizing.cpp:
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
* style/RenderTreeUpdater.cpp:
* style/StyleResolveForDocument.cpp:
* style/StyleTreeResolver.cpp:
Source/WebKit/mac:
* WebView/WebImmediateActionController.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@217893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2017-06-07 Jer Noble <jer.noble@apple.com>
+
+ Clean-up: RenderElement.h includes headers it doesn't use
+ https://bugs.webkit.org/show_bug.cgi?id=173046
+
+ Reviewed by Andy Estes.
+
+ Remove a couple of unneeded includes from RenderElement.h, and then clean up all the
+ follow-on compile errors that causes. Mostly, these errors are fixed by including the
+ correct headers at the point of use; otherwise, they're solved by forward-declaring types
+ and in one case by moving default constructors implementation to the cpp file from the header.
+
+ * css/parser/SizesAttributeParser.cpp:
+ * editing/cocoa/EditorCocoa.mm:
+ * platform/mac/PasteboardMac.mm:
+ * rendering/InlineIterator.h:
+ (WebCore::embedCharFromDirection):
+ * rendering/RenderBoxModelObject.h:
+ * rendering/RenderElement.cpp:
+ * rendering/RenderElement.h:
+ * rendering/RenderIterator.h:
+ * rendering/RenderLineBreak.cpp:
+ * rendering/RenderQuote.cpp:
+ * rendering/RenderText.h:
+ * rendering/SimpleLineLayoutPagination.cpp:
+ * rendering/SimpleLineLayoutTextFragmentIterator.cpp:
+ * rendering/TextAutoSizing.cpp:
+ * rendering/style/RenderStyle.cpp:
+ * rendering/style/RenderStyle.h:
+ * style/RenderTreeUpdater.cpp:
+ * style/StyleResolveForDocument.cpp:
+ * style/StyleTreeResolver.cpp:
+
2017-06-07 Youenn Fablet <youenn@apple.com>
Add WebRTC stats logging
#include "CSSPrimitiveValue.h"
#include "CSSToLengthConversionData.h"
#include "CSSTokenizer.h"
+#include "FontCascade.h"
#include "MediaQueryEvaluator.h"
#include "RenderView.h"
#include "SizesCalcParser.h"
#import "Editing.h"
#import "EditingStyle.h"
#import "EditorClient.h"
+#import "FontCascade.h"
#import "Frame.h"
#import "FrameSelection.h"
#import "HTMLConverter.h"
#import "Text.h"
#import "URL.h"
#import "WebCoreNSStringExtras.h"
+#import "WebCoreSystemInterface.h"
#import "WebNSAttributedStringExtras.h"
#import "markup.h"
#import <wtf/RetainPtr.h>
static inline UCharDirection embedCharFromDirection(TextDirection direction, EUnicodeBidi unicodeBidi)
{
- using namespace WTF::Unicode;
if (unicodeBidi == Embed)
return direction == RTL ? U_RIGHT_TO_LEFT_EMBEDDING : U_LEFT_TO_RIGHT_EMBEDDING;
return direction == RTL ? U_RIGHT_TO_LEFT_OVERRIDE : U_LEFT_TO_RIGHT_OVERRIDE;
#pragma once
+#include "FontBaseline.h"
#include "LayoutRect.h"
#include "RenderLayerModelObject.h"
#include "RenderElement.h"
#include "AXObjectCache.h"
+#include "CSSAnimationController.h"
#include "ContentData.h"
#include "CursorList.h"
#include "ElementChildIterator.h"
#pragma once
-#include "CSSAnimationController.h"
#include "LengthFunctions.h"
#include "RenderObject.h"
-#include "StyleInheritedData.h"
namespace WebCore {
namespace WebCore {
+class RenderText;
+
template <typename T>
class RenderIterator {
public:
#include "RenderLineBreak.h"
#include "Document.h"
+#include "FontMetrics.h"
#include "HTMLElement.h"
#include "HTMLWBRElement.h"
#include "InlineElementBox.h"
#include "QuotesData.h"
#include "RenderTextFragment.h"
#include "RenderView.h"
+#include <wtf/unicode/CharacterNames.h>
using namespace WTF::Unicode;
namespace WebCore {
+class Font;
class InlineTextBox;
struct GlyphOverflow;
#include "config.h"
#include "SimpleLineLayoutPagination.h"
+#include "FontCascade.h"
#include "RenderBlockFlow.h"
#include "SimpleLineLayout.h"
#include "SimpleLineLayoutFunctions.h"
#include "config.h"
#include "SimpleLineLayoutTextFragmentIterator.h"
+#include "FontCascade.h"
#include "Hyphenation.h"
#include "RenderBlockFlow.h"
#include "RenderChildIterator.h"
#include "CSSFontSelector.h"
#include "Document.h"
+#include "FontCascade.h"
#include "Logging.h"
#include "RenderListMarker.h"
#include "RenderText.h"
return style;
}
+RenderStyle::RenderStyle(RenderStyle&&) = default;
+RenderStyle& RenderStyle::operator=(RenderStyle&&) = default;
+
RenderStyle::RenderStyle(CreateDefaultStyleTag)
: m_boxData(StyleBoxData::create())
, m_visualData(StyleVisualData::create())
enum CreateDefaultStyleTag { CreateDefaultStyle };
public:
- RenderStyle(RenderStyle&&) = default;
- RenderStyle& operator=(RenderStyle&&) = default;
+ RenderStyle(RenderStyle&&);
+ RenderStyle& operator=(RenderStyle&&);
~RenderStyle();
RenderStyle replace(RenderStyle&&) WARN_UNUSED_RETURN;
#include "RenderTreeUpdater.h"
#include "AXObjectCache.h"
+#include "CSSAnimationController.h"
#include "ComposedTreeAncestorIterator.h"
#include "ComposedTreeIterator.h"
#include "Document.h"
#include "CSSFontSelector.h"
#include "ConstantPropertyMap.h"
#include "Document.h"
+#include "FontCascade.h"
#include "Frame.h"
#include "FrameView.h"
#include "HTMLIFrameElement.h"
#include "config.h"
#include "StyleTreeResolver.h"
+#include "CSSAnimationController.h"
#include "CSSFontSelector.h"
#include "ComposedTreeAncestorIterator.h"
#include "ComposedTreeIterator.h"
+2017-06-07 Jer Noble <jer.noble@apple.com>
+
+ Clean-up: RenderElement.h includes headers it doesn't use
+ https://bugs.webkit.org/show_bug.cgi?id=173046
+
+ Reviewed by Andy Estes.
+
+ * WebView/WebImmediateActionController.mm:
+
2017-06-07 Zalan Bujtas <zalan@apple.com>
[iOS WK1 WebThread] Do not call out to the main thread for device orientation.
#import <WebCore/Editor.h>
#import <WebCore/EventHandler.h>
#import <WebCore/FocusController.h>
+#import <WebCore/FontMetrics.h>
#import <WebCore/Frame.h>
#import <WebCore/FrameView.h>
#import <WebCore/GeometryUtilities.h>