2011-04-11 Dirk Pranke <dpranke@chromium.org>
authordpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 11 Apr 2011 19:31:50 +0000 (19:31 +0000)
committerdpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 11 Apr 2011 19:31:50 +0000 (19:31 +0000)
        Reviewed by Adam Roben.

        new-run-webkit-tests: fix crash when running under windows cmd.exe
        https://bugs.webkit.org/show_bug.cgi?id=58197

        We would intermittently crash when running NRWT directly under
        cmd.exe on windows because we were sharing the stdin file
        descriptor between the python process and the http server.
        cmd.exe really didn't like that, and there was no reason to
        share the descriptor, so we now use a PIPE instead.

        * Scripts/webkitpy/layout_tests/port/http_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/layout_tests/port/http_server.py

index 9e8c4f5..797feda 100644 (file)
@@ -1,5 +1,20 @@
 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
 
+        Reviewed by Adam Roben.
+
+        new-run-webkit-tests: fix crash when running under windows cmd.exe
+        https://bugs.webkit.org/show_bug.cgi?id=58197
+
+        We would intermittently crash when running NRWT directly under
+        cmd.exe on windows because we were sharing the stdin file
+        descriptor between the python process and the http server.
+        cmd.exe really didn't like that, and there was no reason to
+        share the descriptor, so we now use a PIPE instead.
+
+        * Scripts/webkitpy/layout_tests/port/http_server.py:
+
+2011-04-11  Dirk Pranke  <dpranke@chromium.org>
+
         Reviewed by Ojan Vafai.
 
         new-run-webkit-tests: add unit tests for Port.diff_image()
index 1753aee..5ba767f 100755 (executable)
@@ -214,7 +214,7 @@ class Lighttpd(http_server_base.HttpServerBase):
         env = self._port_obj.setup_environ_for_server()
         _log.debug('Starting http server, cmd="%s"' % str(start_cmd))
         # FIXME: Should use Executive.run_command
-        self._process = subprocess.Popen(start_cmd, env=env)
+        self._process = subprocess.Popen(start_cmd, env=env, stdin=subprocess.PIPE)
 
         # Wait for server to start.
         self.mappings = mappings