Rolling out r184660
authordbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 26 Jun 2015 22:18:55 +0000 (22:18 +0000)
committerdbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 26 Jun 2015 22:18:55 +0000 (22:18 +0000)
https://bugs.webkit.org/show_bug.cgi?id=145200

Reverting r184660 because it caused a regression.

Source/WebCore:

* English.lproj/Localizable.strings:
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createAutoFillButton): Deleted.
* platform/LocalizedStrings.cpp:
(WebCore::AXAutoFillButtonText): Deleted.
* platform/LocalizedStrings.h:
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::AXAutoFillButtonText): Deleted.
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXAutoFillButtonText): Deleted.

LayoutTests:

* accessibility/input-auto-fill-button-expected.txt: Removed.
* accessibility/input-auto-fill-button.html: Removed.
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/accessibility/input-auto-fill-button-expected.txt [deleted file]
LayoutTests/accessibility/input-auto-fill-button.html [deleted file]
LayoutTests/platform/win/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/English.lproj/Localizable.strings
Source/WebCore/html/TextFieldInputType.cpp
Source/WebCore/platform/LocalizedStrings.cpp
Source/WebCore/platform/LocalizedStrings.h
Source/WebCore/platform/efl/LocalizedStringsEfl.cpp
Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp

index 58870ff..a838c79 100644 (file)
@@ -1,5 +1,16 @@
 2015-06-26  Daniel Bates  <dabates@apple.com>
 
+        Rolling out r184660
+        https://bugs.webkit.org/show_bug.cgi?id=145200
+
+        Reverting r184660 because it caused a regression.
+
+        * accessibility/input-auto-fill-button-expected.txt: Removed.
+        * accessibility/input-auto-fill-button.html: Removed.
+        * platform/win/TestExpectations:
+
+2015-06-26  Daniel Bates  <dabates@apple.com>
+
         Rolling out r185881
         https://bugs.webkit.org/show_bug.cgi?id=146243
         And
diff --git a/LayoutTests/accessibility/input-auto-fill-button-expected.txt b/LayoutTests/accessibility/input-auto-fill-button-expected.txt
deleted file mode 100644 (file)
index 48c5d3a..0000000
+++ /dev/null
@@ -1,11 +0,0 @@
-This tests that there exists an accessibility element for the AutoFill button.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS accessibilityController.accessibleElementById("password").childAtIndex(0).description is "AXDescription: autofill"
-PASS accessibilityController.accessibleElementById("password").childAtIndex(0).role is "AXRole: AXButton"
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
diff --git a/LayoutTests/accessibility/input-auto-fill-button.html b/LayoutTests/accessibility/input-auto-fill-button.html
deleted file mode 100644 (file)
index 436a722..0000000
+++ /dev/null
@@ -1,22 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<script src="../resources/js-test-pre.js"></script>
-</head>
-<body>
-<input type="password" id="password">
-<script>
-description("This tests that there exists an accessibility element for the AutoFill button.");
-
-if (!window.internals || !window.accessibilityController)
-    testFailed("You must run this test in the test tool and have implemented window.internals and window.accessibilityController.");
-else {
-    internals.setShowAutoFillButton(document.getElementById("password"), true);
-
-    shouldBeEqualToString('accessibilityController.accessibleElementById("password").childAtIndex(0).description', "AXDescription: autofill");
-    shouldBeEqualToString('accessibilityController.accessibleElementById("password").childAtIndex(0).role', "AXRole: AXButton");
-}
-</script>
-<script src="../resources/js-test-post.js"></script>
-</body>
-</html>
index df8b8ea..2b81f54 100644 (file)
@@ -1321,8 +1321,6 @@ webkit.org/b/140798 [ Release ] accessibility/html-html-element-is-ignored.html
 webkit.org/b/140798 [ Debug ] accessibility/html-html-element-is-ignored.html [ Skip ] # Debug assertion
 webkit.org/b/140798 [ Release ] accessibility/inline-block-assertion.html [ Failure ]
 webkit.org/b/140798 [ Debug ] accessibility/inline-block-assertion.html [ Skip ] # Debug assertion
-webkit.org/b/140798 [ Release ] accessibility/input-auto-fill-button.html [ Failure ]
-webkit.org/b/140798 [ Debug ] accessibility/input-auto-fill-button.html [ Failure ]
 webkit.org/b/140798 [ Release ] accessibility/input-type-hidden-in-aria-hidden-false.html [ Failure ]
 webkit.org/b/140798 [ Debug ] accessibility/input-type-hidden-in-aria-hidden-false.html [ Skip ] # Debug assertion
 webkit.org/b/140798 [ Release ] accessibility/legend-children-are-visible.html [ Failure ]
index 549e381..c40269f 100644 (file)
@@ -1,5 +1,23 @@
 2015-06-26  Daniel Bates  <dabates@apple.com>
 
+        Rolling out r184660
+        https://bugs.webkit.org/show_bug.cgi?id=145200
+
+        Reverting r184660 because it caused a regression.
+
+        * English.lproj/Localizable.strings:
+        * html/TextFieldInputType.cpp:
+        (WebCore::TextFieldInputType::createAutoFillButton): Deleted.
+        * platform/LocalizedStrings.cpp:
+        (WebCore::AXAutoFillButtonText): Deleted.
+        * platform/LocalizedStrings.h:
+        * platform/efl/LocalizedStringsEfl.cpp:
+        (WebCore::AXAutoFillButtonText): Deleted.
+        * platform/gtk/LocalizedStringsGtk.cpp:
+        (WebCore::AXAutoFillButtonText): Deleted.
+
+2015-06-26  Daniel Bates  <dabates@apple.com>
+
         Rolling out r185881
         https://bugs.webkit.org/show_bug.cgi?id=146243
         And
index 204c41d..73ce005 100644 (file)
 /* accessibility description for a search field cancel button */
 "cancel" = "cancel";
 
-/* accessibility description for a password field AutoFill button */
-"autofill" = "autofill";
-
 /* Verb stating the action that will occur when an unchecked checkbox is clicked, as used by accessibility */
 "check" = "check";
 
index 7d5b146..4b28aa8 100644 (file)
@@ -42,7 +42,6 @@
 #include "HTMLInputElement.h"
 #include "HTMLNames.h"
 #include "KeyboardEvent.h"
-#include "LocalizedStrings.h"
 #include "NodeRenderStyle.h"
 #include "Page.h"
 #include "PlatformKeyboardEvent.h"
@@ -613,8 +612,6 @@ void TextFieldInputType::createAutoFillButton()
 
     m_autoFillButton = AutoFillButtonElement::create(element().document(), *this);
     m_autoFillButton->setPseudo(AtomicString("-webkit-auto-fill-button", AtomicString::ConstructFromLiteral));
-    m_autoFillButton->setAttribute(aria_labelAttr, AtomicString(AXAutoFillButtonText()));
-    m_autoFillButton->setAttribute(roleAttr, AtomicString("button", AtomicString::ConstructFromLiteral));
     m_container->appendChild(m_autoFillButton, IGNORE_EXCEPTION);
 }
 
index a1dedb5..93d2e90 100644 (file)
@@ -653,11 +653,6 @@ String AXListItemActionVerb()
 }
 #endif // !PLATFORM(IOS)
 
-String AXAutoFillButtonText()
-{
-    return WEB_UI_STRING("autofill", "accessibility description for a password field AutoFill button");
-}
-
 #if PLATFORM(COCOA)
 String AXARIAContentGroupText(const String& ariaType)
 {
index 4f71481..09a3800 100644 (file)
@@ -162,7 +162,7 @@ namespace WebCore {
     String AXFooterRoleDescriptionText();
     String AXFileUploadButtonText();
     String AXSearchFieldCancelButtonText();
-
+    
     String AXButtonActionVerb();
     String AXRadioButtonActionVerb();
     String AXTextFieldActionVerb();
@@ -174,8 +174,6 @@ namespace WebCore {
     String AXListItemActionVerb();
 #endif
 
-    String AXAutoFillButtonText();
-
 #if ENABLE(INPUT_TYPE_WEEK)
     // weekFormatInLDML() returns week and year format in LDML, Unicode
     // technical standard 35, Locale Data Markup Language, e.g. "'Week' ww, yyyy"
index 79009bf..3ea96d7 100644 (file)
@@ -408,11 +408,6 @@ String AXSearchFieldCancelButtonText()
     return String::fromUTF8("cancel");
 }
 
-String AXAutoFillButtonText()
-{
-    return String::fromUTF8("autofill");
-}
-
 String AXButtonActionVerb()
 {
     return String::fromUTF8("press");
index 199119c..ecbbd6f 100644 (file)
@@ -456,11 +456,6 @@ String AXSearchFieldCancelButtonText()
     return String::fromUTF8(_("cancel"));
 }
 
-String AXAutoFillButtonText()
-{
-    return String::fromUTF8(_("autofill"));
-}
-
 String AXButtonActionVerb()
 {
     return String::fromUTF8(_("press"));