-Wimplicit-fallthrough warning in ComputedStyleExtractor::propertyValue
authormcatanzaro@igalia.com <mcatanzaro@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 7 Aug 2017 22:01:26 +0000 (22:01 +0000)
committermcatanzaro@igalia.com <mcatanzaro@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 7 Aug 2017 22:01:26 +0000 (22:01 +0000)
https://bugs.webkit.org/show_bug.cgi?id=174469
<rdar://problem/33311638>

Reviewed by Simon Fraser.

Add a RELEASE_ASSERT_NOT_REACHED to silence this warning.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/css/CSSComputedStyleDeclaration.cpp

index 6b474aa..7f0a8f7 100644 (file)
@@ -1,3 +1,16 @@
+2017-08-07  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        -Wimplicit-fallthrough warning in ComputedStyleExtractor::propertyValue
+        https://bugs.webkit.org/show_bug.cgi?id=174469
+        <rdar://problem/33311638>
+
+        Reviewed by Simon Fraser.
+
+        Add a RELEASE_ASSERT_NOT_REACHED to silence this warning.
+
+        * css/CSSComputedStyleDeclaration.cpp:
+        (WebCore::ComputedStyleExtractor::propertyValue):
+
 2017-08-06  Filip Pizlo  <fpizlo@apple.com>
 
         Primitive auxiliaries and JSValue auxiliaries should have separate gigacages
index fa22248..7ec8eb8 100644 (file)
@@ -3341,6 +3341,7 @@ RefPtr<CSSValue> ComputedStyleExtractor::propertyValue(CSSPropertyID propertyID,
                 list->append(cssValuePool.createValue(style->textEmphasisMark()));
                 return WTFMove(list);
             }
+            RELEASE_ASSERT_NOT_REACHED();
         case CSSPropertyTextIndent: {
             // If CSS3_TEXT is disabled or text-indent has only one value(<length> | <percentage>),
             // getPropertyCSSValue() returns CSSValue.