EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Aug 2014 05:19:01 +0000 (05:19 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Aug 2014 05:19:01 +0000 (05:19 +0000)
https://bugs.webkit.org/show_bug.cgi?id=131668

Reviewed by Daniel Bates.

We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
to not just hardcode.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
(EWS.prototype.queueStatusURL): Added.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
(EWSQueue.prototype.get statusPageURL): Use the above function.
(EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
(EWSQueueView.prototype.update): While at it, made a popover show up even if there
are no patches in the queue. The popover has other useful information, such as charts
link and bot status.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js
Tools/ChangeLog

index 6def9d6..1177cdd 100644 (file)
@@ -57,4 +57,9 @@ EWS.prototype = {
     {
         return this.baseURL + "queue-status-json/" + encodeURIComponent(queueID) + "-ews";
     },
+
+    queueStatusURL: function(queueID)
+    {
+        return this.baseURL + "queue-status/" + encodeURIComponent(queueID) + "-ews";
+    },
 };
index 423a633..68ca99b 100644 (file)
@@ -49,7 +49,7 @@ EWSQueue.prototype = {
 
     get statusPageURL()
     {
-        return this._statusPageURL;
+        return this.ews.queueStatusURL(this.id);
     },
 
     get chartsPageURL()
@@ -132,7 +132,7 @@ EWSQueue.prototype = {
                 });
             }
 
-            this._statusPageURL = data.status_page;
+            console.assert(this._statusPageURL === data.status_page);
             this._chartsPageURL = data.charts_page;
 
             this._loadedDetailedStatus = true;
index 4e45376..d766683 100644 (file)
@@ -67,8 +67,7 @@ EWSQueueView.prototype = {
             var status = new StatusLineView(message, StatusLineView.Status.Neutral, null, patchCount || "0");
             this.element.appendChild(status.element);
 
-            if (patchCount > 0)
-                new PopoverTracker(status.statusBubbleElement, this._presentPopoverForEWSQueue.bind(this), queue);
+            new PopoverTracker(status.statusBubbleElement, this._presentPopoverForEWSQueue.bind(this), queue);
         }
 
         this.queues.forEach(function(queue) {
index c65216e..a6a8037 100644 (file)
@@ -1,5 +1,27 @@
 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
 
+        EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
+        https://bugs.webkit.org/show_bug.cgi?id=131668
+
+        Reviewed by Daniel Bates.
+
+        We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
+        to not just hardcode.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
+        (EWS.prototype.queueStatusURL): Added.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
+        (EWSQueue.prototype.get statusPageURL): Use the above function.
+        (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
+        (EWSQueueView.prototype.update): While at it, made a popover show up even if there
+        are no patches in the queue. The popover has other useful information, such as charts
+        link and bot status.
+
+2014-08-27  Alexey Proskuryakov  <ap@apple.com>
+
         https://bugs.webkit.org/show_bug.cgi?id=136317
         Dashboard metrics page sometimes shows 0 for best time