Fix iteration over repositories on bot watcher's dashboard.
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 21 Aug 2015 18:10:17 +0000 (18:10 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 21 Aug 2015 18:10:17 +0000 (18:10 +0000)
Patch by Jason Marcell <jmarcell@apple.com> on 2015-08-21
Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@188758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js
Tools/ChangeLog

index 07cd2fa..b5a89d4 100644 (file)
@@ -166,8 +166,8 @@ BuildbotQueueView.prototype = {
             var length = lines.length;
             if (length && shouldAddDivider)
                 this._addDividerToPopover(content);
-            for (var i = 0; i < length; ++i)
-                content.appendChild(lines[i]);
+            for (var j = 0; j < length; ++j)
+                content.appendChild(lines[j]);
             shouldAddDivider = shouldAddDivider || length > 0;
         }
 
index e6408d1..01b5263 100644 (file)
@@ -1,3 +1,12 @@
+2015-08-21  Jason Marcell  <jmarcell@apple.com>
+
+        Fix iteration over repositories on bot watcher's dashboard.
+
+        Reviewed by Alexey Proskuryakov.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+        (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
+
 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
 
         [EFL] Revise PlatformWebView ctor according to r188718