Unreviewed. Remove incorrect assert after r183189.
authorcarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Apr 2015 10:21:13 +0000 (10:21 +0000)
committercarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Apr 2015 10:21:13 +0000 (10:21 +0000)
In this case the assert was already there, but it's incorrect
because we are handling uninitialized attachments below in the
same function, and also when sending messages. So, if it's ok to
send uninitialized attachments, it's ok to receive them. This
didn't fail before r183189, because we were only invaliding the
attachments by setting the file descriptor to -1, and they were
handled as null attachments. After r183189, the move operator
resets the moved attachment leaving it uninitialized again.

* Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::processMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@183258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp

index 921e973..2115a34 100644 (file)
@@ -1,5 +1,21 @@
 2015-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
 
+        Unreviewed. Remove incorrect assert after r183189.
+
+        In this case the assert was already there, but it's incorrect
+        because we are handling uninitialized attachments below in the
+        same function, and also when sending messages. So, if it's ok to
+        send uninitialized attachments, it's ok to receive them. This
+        didn't fail before r183189, because we were only invaliding the
+        attachments by setting the file descriptor to -1, and they were
+        handled as null attachments. After r183189, the move operator
+        resets the moved attachment leaving it uninitialized again.
+
+        * Platform/IPC/unix/ConnectionUnix.cpp:
+        (IPC::Connection::processMessage):
+
+2015-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
+
         [SOUP] Use a webkit subdirectory for the disk cache
         https://bugs.webkit.org/show_bug.cgi?id=144048
 
index fc5f66f..f559db6 100644 (file)
@@ -187,7 +187,6 @@ bool Connection::processMessage()
                 break;
             case Attachment::Uninitialized:
             default:
-                ASSERT_NOT_REACHED();
                 break;
             }
         }