Enable CSSOMViewScrollingAPI

https://bugs.webkit.org/show_bug.cgi?id=189472

Patch by Frederic Wang <fwang@igalia.com> on 2019-01-22
Reviewed by Simon Fraser.

This patch enables the CSSOMViewScrollingAPI option by default. This feature has already been
enabled in tests since r235855. Basically, this change fixes an old compatibility issue
regarding which scrolling element correspond to the viewport in standard mode (WebKit uses
document.body while Gecko/Edge/Chromium use document.documentElement as described in the
CSSOM View specification). WebKit developers writing tests can use document.scrollingElement
for that purpose, so that they work independently of whether the option is enabled.

[1] https://lists.webkit.org/pipermail/webkit-dev/2018-January/029857.html

* Shared/WebPreferences.yaml: Enable by default and remove "experimental" category in
accordance with the new policy. Instead, keep an internal flag only for developers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
index bc5da36..82202b4 100644 (file)
--- a/Source/WebKit/ChangeLog
+++ b/Source/WebKit/ChangeLog
@@ -1,3 +1,22 @@
+2019-01-22  Frederic Wang  <fwang@igalia.com>
+
+        Enable CSSOMViewScrollingAPI
+        https://bugs.webkit.org/show_bug.cgi?id=189472
+
+        Reviewed by Simon Fraser.
+
+        This patch enables the CSSOMViewScrollingAPI option by default. This feature has already been
+        enabled in tests since r235855. Basically, this change fixes an old compatibility issue
+        regarding which scrolling element correspond to the viewport in standard mode (WebKit uses
+        document.body while Gecko/Edge/Chromium use document.documentElement as described in the
+        CSSOM View specification). WebKit developers writing tests can use document.scrollingElement
+        for that purpose, so that they work independently of whether the option is enabled.
+
+        [1] https://lists.webkit.org/pipermail/webkit-dev/2018-January/029857.html
+
+        * Shared/WebPreferences.yaml: Enable by default and remove "experimental" category in
+        accordance with the new policy. Instead, keep an internal flag only for developers.
+
 2019-01-21  Antti Koivisto  <antti@apple.com>
 
         [iOS] Handle hit testing for subframes

diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
index 82ddcbc..024322a 100644 (file)
--- a/Source/WebKit/Shared/WebPreferences.yaml
+++ b/Source/WebKit/Shared/WebPreferences.yaml
@@ -1255,10 +1255,10 @@ PointerEventsEnabled:
 
 CSSOMViewScrollingAPIEnabled:
   type: bool
-  defaultValue: false
+  defaultValue: true
   humanReadableName: "CSSOM View Scrolling API"
   humanReadableDescription: "Implement standard behavior for scrollLeft, scrollTop, scrollWidth, scrollHeight, scrollTo, scrollBy and scrollingElement."
-  category: experimental
+  category: internal
 
 WebAnimationsEnabled:
   type: bool