[ATK][WTR] accessibility/aria-invalid.html times out
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Sep 2013 15:20:32 +0000 (15:20 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Sep 2013 15:20:32 +0000 (15:20 +0000)
https://bugs.webkit.org/show_bug.cgi?id=121668

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.

Tools:

Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
false in case of aria-invalid event with empty value.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
case of aria-invalid event with empty value.

LayoutTests:

Updated the expectation of aria-invalid.html test, which was timing out
before bug 120421 and this fix.

* platform/gtk-wk2/TestExpectations: Removed aria-invalid.html because
it now passes with this fix and the patch from bug 120421.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk-wk2/TestExpectations
Tools/ChangeLog
Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp

index 7b2f243..91c3f16 100644 (file)
@@ -1,3 +1,16 @@
+2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
+
+        [ATK][WTR] accessibility/aria-invalid.html times out
+        https://bugs.webkit.org/show_bug.cgi?id=121668
+
+        Reviewed by Mario Sanchez Prada.
+
+        Updated the expectation of aria-invalid.html test, which was timing out
+        before bug 120421 and this fix.
+
+        * platform/gtk-wk2/TestExpectations: Removed aria-invalid.html because
+        it now passes with this fix and the patch from bug 120421.
+
 2013-09-20  Gabor Abraham  <abrhm@inf.u-szeged.hu>
 
         [Qt] Unreviewed gardening. Rebase after Qt 5.1.1 and skip failing tests.
index e997c7a..2d32d2b 100644 (file)
@@ -495,9 +495,6 @@ Bug(GTK) animations/combo-transform-translate+scale.html [ Failure ]
 Bug(GTK) animations/play-state-suspend.html [ Failure ]
 Bug(GTK) animations/suspend-resume-animation.html [ Failure ]
 
-# [GTK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
-webkit.org/b/120421 accessibility/aria-invalid.html [ Timeout ]
-
 #////////////////////////////////////////////////////////////////////////////////////////
 # End of Tests failing
 #////////////////////////////////////////////////////////////////////////////////////////
index b18d632..55f849c 100644 (file)
@@ -1,5 +1,19 @@
 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
 
+        [ATK][WTR] accessibility/aria-invalid.html times out
+        https://bugs.webkit.org/show_bug.cgi?id=121668
+
+        Reviewed by Mario Sanchez Prada.
+
+        Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
+        false in case of aria-invalid event with empty value.
+
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+        (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
+        case of aria-invalid event with empty value.
+
+2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
+
         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
         https://bugs.webkit.org/show_bug.cgi?id=120421
 
index 4bcfceb..02b5664 100644 (file)
@@ -569,6 +569,12 @@ JSRetainPtr<JSStringRef> AccessibilityUIElement::stringAttributeValue(JSStringRe
 
     String attributeValue = getAttributeSetValueForId(ATK_OBJECT(m_element.get()), atkAttributeName.utf8().data());
 
+    // In case of 'aria-invalid' when the attribute empty or has "false" for ATK
+    // according to http://www.w3.org/WAI/PF/aria-implementation/#mapping attribute
+    // is not mapped but layout tests will expect 'false'.
+    if (attributeValue.isEmpty() && atkAttributeName == "aria-invalid")
+        return JSStringCreateWithUTF8CString("false");
+
     // We need to translate ATK values exposed for 'aria-sort' (e.g. 'ascending')
     // into those expected by the layout tests (e.g. 'AXAscendingSortDirection').
     if (atkAttributeName == "sort") {