Fullscreen video controller can't be dragged the first time I enter fullscreen
authorjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 6 Jan 2012 19:38:46 +0000 (19:38 +0000)
committerjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 6 Jan 2012 19:38:46 +0000 (19:38 +0000)
https://bugs.webkit.org/show_bug.cgi?id=75709

Reviewed by Eric Carlson.

Source/WebCore:

No new tests; updated video-controls-drag.html.

When the media controls are created, check to see if we are full screen, and pass
that information to the newly created controls.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createMediaControls):

LayoutTests:

Update the test to cover the case where the controls do not yet exist when entering
fullscreen.

* fullscreen/video-controls-drag.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fullscreen/video-controls-drag.html
Source/WebCore/ChangeLog
Source/WebCore/html/HTMLMediaElement.cpp

index 4b5ba30..c720bb1 100644 (file)
@@ -1,3 +1,15 @@
+2012-01-06  Jer Noble  <jer.noble@apple.com>
+
+        Fullscreen video controller can't be dragged the first time I enter fullscreen
+        https://bugs.webkit.org/show_bug.cgi?id=75709
+
+        Reviewed by Eric Carlson.
+
+        Update the test to cover the case where the controls do not yet exist when entering
+        fullscreen.
+
+        * fullscreen/video-controls-drag.html:
+
 2012-01-06  Jon Lee  <jonlee@apple.com>
 
         Update test expectations with rebaseline of fast/forms/listbox-clip.html from r104299.
index b6c9c9e..cae2a56 100644 (file)
@@ -1,6 +1,6 @@
 <body>
     <p>This tests that the video element's controls are draggable in full screen.  Press any key to continue.</p>
-    <video id="video" width="300" controls></video>
+    <video id="video" width="300"></video>
     <script src="full-screen-test.js"></script>
     <script src="../media/media-controls.js"></script>
     <script>
index 26ff309..7486431 100644 (file)
@@ -1,3 +1,18 @@
+2012-01-06  Jer Noble  <jer.noble@apple.com>
+
+        Fullscreen video controller can't be dragged the first time I enter fullscreen
+        https://bugs.webkit.org/show_bug.cgi?id=75709
+
+        Reviewed by Eric Carlson.
+
+        No new tests; updated video-controls-drag.html.
+
+        When the media controls are created, check to see if we are full screen, and pass
+        that information to the newly created controls.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::createMediaControls):
+
 2012-01-05  Jer Noble  <jer.noble@apple.com>
 
         Media Element: scrubbing in full-screen mode breaks playback.
index 0b693b2..f67eace 100644 (file)
@@ -3484,6 +3484,8 @@ bool HTMLMediaElement::createMediaControls()
 
     controls->setMediaController(m_mediaController ? m_mediaController.get() : static_cast<MediaControllerInterface*>(this));
     controls->reset();
+    if (isFullscreen())
+        controls->enteredFullscreen();
 
     ensureShadowRoot()->appendChild(controls, ec);
     return true;