Source/WebCore: Contained div with right 0 sometimes overlaps parent div
authoreae@chromium.org <eae@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 26 Jul 2012 19:54:29 +0000 (19:54 +0000)
committereae@chromium.org <eae@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 26 Jul 2012 19:54:29 +0000 (19:54 +0000)
https://bugs.webkit.org/show_bug.cgi?id=91521

Reviewed by Levi Weintraub.

Due to unnecessary rounding in clientLogicalWidth and clientLogicalHeight
we lost precision when computing the width and position of render boxes.
Change clientLogicalWidth/Height to return values with subpixel precision
to avoid this.

Test: fast/sub-pixel/position-right-aligns-with-container.html

* rendering/RenderBox.h:
(WebCore::RenderBox::clientLogicalWidth):
(WebCore::RenderBox::clientLogicalHeight):
Remove unnecessary rounding.

Source/WebKit2: Add a ChromeClient method to send diagnostic logging messages from WebCore to the client.
https://bugs.webkit.org/show_bug.cgi?id=92340

Reviewed by Anders Carlsson.

Pipe the ChromeClient logDiagnosticMessage() function through WebKit2 to a new bundle class
InjectedBundlePageDiagnosticLoggingClient, to be implemented by the client.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetDiagnosticLoggingClient): Added.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Added.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Added.
(InjectedBundlePageDiagnosticLoggingClient):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::logDiagnosticMessage):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::initializeInjectedBundleDiagnosticLoggingClient):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundleDiagnosticLoggingClient):

Add a convenience class to retrieve the diagnostic message keys:
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Added.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Added.
(InjectedBundlePageDiagnosticLoggingClient):

Add the InjectedBundlePageDiagnosticLoggingClient.cpp,h files.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* win/WebKit2.vcproj:
* WebKit2.xcodeproj/project.pbxproj:

Tools: [nrwt] get rid of --skip-pixel-test-if-no-baseline
https://bugs.webkit.org/show_bug.cgi?id=92377

Reviewed by Adam Barth.

Remove the option and all code paths that handled it.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.should_run_as_pixel_test):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_repeat_each):

LayoutTests: Contained div with right 0 sometimes overlaps parent div
https://bugs.webkit.org/show_bug.cgi?id=91521

Reviewed by Levi Weintraub.

Add test for elements positioned based on the right edge and update two
existing tests that where affected by the rounding.

* fast/sub-pixel/position-right-aligns-with-container-expected.html: Added.
* fast/sub-pixel/position-right-aligns-with-container.html: Added.
* platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:
Mark new subpixel test as skipped on platforms that do not enable
subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

22 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/sub-pixel/position-right-aligns-with-container-expected.html [new file with mode: 0644]
LayoutTests/fast/sub-pixel/position-right-aligns-with-container.html [new file with mode: 0644]
LayoutTests/platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png
LayoutTests/platform/chromium-win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt
LayoutTests/platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt
LayoutTests/platform/mac-lion/Skipped
LayoutTests/platform/mac-snowleopard/Skipped
LayoutTests/platform/mac-wk2/Skipped
LayoutTests/platform/mac/Skipped
LayoutTests/platform/qt-4.8/Skipped
LayoutTests/platform/qt-5.0-wk2/Skipped
LayoutTests/platform/qt/Skipped
LayoutTests/platform/win-wk2/Skipped
LayoutTests/platform/win-xp/Skipped
LayoutTests/platform/win/Skipped
LayoutTests/platform/wincairo/Skipped
LayoutTests/platform/wk2/Skipped
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderBox.h
Source/WebKit2/ChangeLog
Tools/ChangeLog

index bced484..f416650 100644 (file)
@@ -1,3 +1,33 @@
+2012-07-26  Emil A Eklund  <eae@chromium.org>
+
+        Contained div with right 0 sometimes overlaps parent div
+        https://bugs.webkit.org/show_bug.cgi?id=91521
+
+        Reviewed by Levi Weintraub.
+
+        Add test for elements positioned based on the right edge and update two
+        existing tests that where affected by the rounding.
+
+        * fast/sub-pixel/position-right-aligns-with-container-expected.html: Added.
+        * fast/sub-pixel/position-right-aligns-with-container.html: Added.
+        * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
+        * platform/chromium-win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
+        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
+        * platform/mac-lion/Skipped:
+        * platform/mac-snowleopard/Skipped:
+        * platform/mac-wk2/Skipped:
+        * platform/mac/Skipped:
+        * platform/qt-4.8/Skipped:
+        * platform/qt-5.0-wk2/Skipped:
+        * platform/qt/Skipped:
+        * platform/win-wk2/Skipped:
+        * platform/win-xp/Skipped:
+        * platform/win/Skipped:
+        * platform/wincairo/Skipped:
+        * platform/wk2/Skipped:
+        Mark new subpixel test as skipped on platforms that do not enable
+        subpixel layout.
+
 2012-07-26  Sheriff Bot  <webkit.review.bot@gmail.com>
 
         Unreviewed, rolling out r123159, r123165, r123168, r123492,
         * platform/mac/accessibility/title-attribute-used-as-last-resort-expected.txt: Added.
         * platform/mac/accessibility/title-attribute-used-as-last-resort.html: Added.
 
+2012-07-26  Olivier Blin  <olivier.blin@softathome.com>
+
+        Add FastMalloc statistics in window.internals
+        https://bugs.webkit.org/show_bug.cgi?id=91274
+
+        Reviewed by Ryosuke Niwa.
+
+        * fast/harness/fastmallocstatistics-object-expected.txt: Added.
+        * fast/harness/fastmallocstatistics-object.html: Added.
+
+2012-07-26  Luciano Wolf  <luciano.wolf@openbossa.org>
+
+        [Qt] css3/filters, editing/undo, fast/block/lineboxcontain, fast/js and tables/layering tests need update after rebaseline and new testfonts
+        https://bugs.webkit.org/show_bug.cgi?id=92292
+
+        Reviewed by Alexis Menard.
+
+        * platform/qt-5.0/Skipped:
+        * platform/qt/css3/filters/effect-blur-expected.txt:
+        * platform/qt/css3/filters/effect-blur-hw-expected.txt:
+        * platform/qt/css3/filters/regions-expanding-expected.txt:
+        * platform/qt/editing/undo/5378473-expected.txt:
+        * platform/qt/editing/undo/undo-misspellings-expected.txt:
+        * platform/qt/fast/block/lineboxcontain/inline-box-expected.png:
+        * platform/qt/fast/block/lineboxcontain/inline-box-expected.txt:
+        * platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.png:
+        * platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.txt:
+        * platform/qt/fast/block/lineboxcontain/inline-replaced-expected.png:
+        * platform/qt/fast/block/lineboxcontain/inline-replaced-expected.txt:
+        * platform/qt/fast/block/lineboxcontain/none-expected.png:
+        * platform/qt/fast/block/lineboxcontain/none-expected.txt:
+        * platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.png:
+        * platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.txt:
+        * platform/qt/fast/block/lineboxcontain/replaced-expected.png:
+        * platform/qt/fast/block/lineboxcontain/replaced-expected.txt:
+
+2012-07-26  Chris Fleizach  <cfleizach@apple.com>
+
+        WebKit should expose @title as label (AXTitle or AXDescription) sometimes instead of AXHelp, according to the ARIA text alt computation
+        https://bugs.webkit.org/show_bug.cgi?id=91911
+
+        Reviewed by Anders Carlsson.
+
+        * platform/mac/accessibility/title-attribute-used-as-last-resort-expected.txt: Added.
+        * platform/mac/accessibility/title-attribute-used-as-last-resort.html: Added.
+
 2012-07-26  Ádám Kallai  <kadam@inf.u-szeged.hu>
 
         [Qt] Unreviewed gardening. Fix after r123733.
diff --git a/LayoutTests/fast/sub-pixel/position-right-aligns-with-container-expected.html b/LayoutTests/fast/sub-pixel/position-right-aligns-with-container-expected.html
new file mode 100644 (file)
index 0000000..ccd2f58
--- /dev/null
@@ -0,0 +1,55 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <style type='text/css'>
+    body {
+        zoom: 1.1;
+        background: white;
+    }
+    .button-wide {
+        display: inline-block;
+        position: relative;
+        border: solid black;
+        border-width: 0 1px;
+    }
+    .button-text {
+        line-height: 1.5em;
+        position: relative;
+        padding: 0 1em;
+        text-align: center;
+    }
+    .box {
+        position: relative;
+        width: 49px;
+        height: 20px;
+        background: black;
+        padding: 0 1px;
+    }
+
+    .box > div {
+        height: 1.5em;
+        background: white;
+    }
+  </style>
+</head>
+<body>
+    <div style="padding: 10px; font-size: 81.25%">
+
+        <div class="button-wide">
+            <div class="button-middle">
+                <div class="button-text">&nbsp;</div>
+            </div>
+        </div>
+    </div>
+
+    <div class="box">
+        <div>&nbsp;</div>
+    </div>
+
+    <p>
+        The two figures above should have solid 1px borders of the same height on each side. 
+    </p>
+</body>
+
+</html>
+
diff --git a/LayoutTests/fast/sub-pixel/position-right-aligns-with-container.html b/LayoutTests/fast/sub-pixel/position-right-aligns-with-container.html
new file mode 100644 (file)
index 0000000..513e38b
--- /dev/null
@@ -0,0 +1,67 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <style type='text/css'>
+    body {
+        zoom: 1.1;
+        background: white;
+    }
+    .button-wide {
+        display: inline-block;
+        position: relative;
+        border: solid black;
+        border-width: 0 1px;
+    }
+    .button-shadow {
+        background: white;
+        height: 0.75em;
+        left: 0;
+        overflow: hidden;
+        position: absolute;
+        right: 0;
+        top: 0;
+    }
+    .button-text {
+        line-height: 1.5em;
+        position: relative;
+        padding: 0 1em;
+        text-align: center;
+    }
+    .box {
+        position: relative;
+        width: 51px;
+        height: 20px;
+        background: black;
+    }
+
+    .box > div {
+        position: absolute;
+        left: 1px;
+        right: 1px;
+        height: 1.5em;
+        background: white;
+    }
+  </style>
+</head>
+<body>
+    <div style="padding: 10px; font-size: 81.25%">
+
+        <div class="button-wide">
+            <div class="button-middle">
+                <div class="button-shadow"></div>
+                <div class="button-text">&nbsp;</div>
+            </div>
+        </div>
+    </div>
+
+    <div class="box">
+        <div>&nbsp;</div>
+    </div>
+
+    <p>
+        The two figures above should have solid 1px borders of the same height on each side. 
+    </p>
+</body>
+
+</html>
+
index 5f61c95..bcd8a5d 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png and b/LayoutTests/platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png differ
index 7ecba2a..ff7b6bd 100644 (file)
@@ -108,6 +108,6 @@ layer at (0,0) size 785x896
 layer at (101,730) size 80x38
   RenderBlock (relative positioned) {DIV} at (3,676) size 80x39 [bgcolor=#008080]
 layer at (101,748) size 40x20
-  RenderBlock (positioned) {DIV} at (0,18) size 40x20 [bgcolor=#FFFFFF]
+  RenderBlock (positioned) {DIV} at (0,17) size 40x21 [bgcolor=#FFFFFF]
     RenderText {#text} at (0,0) size 6x19
       text run at (0,0) width 6: "-"
index 639bea3..38a2822 100644 (file)
@@ -21,43 +21,43 @@ layer at (173,32) size 454x454
       RenderInline {SPAN} at (0,0) size 0x0
 layer at (173,47) size 454x188
   RenderBlock (positioned) {H1} at (0,15) size 454x189 [color=#DD9955]
-    RenderInline {SPAN} at (0,0) size 340x189
-      RenderText {#text} at (63,-1) size 340x189
-        text run at (63,-1) width 328: "CSS ZEN"
-        text run at (57,93) width 340: "GARDEN"
+    RenderInline {SPAN} at (0,0) size 341x189
+      RenderText {#text} at (63,-1) size 341x189
+        text run at (63,-1) width 327: "CSS ZEN"
+        text run at (56,93) width 341: "GARDEN"
 layer at (173,119) size 454x21
   RenderBlock (positioned) {H2} at (0,87) size 454x22 [color=#EEFF00]
-    RenderInline {SPAN} at (0,0) size 150x19
-      RenderText {#text} at (152,1) size 89x19
-        text run at (152,1) width 89: "The Beauty of "
-      RenderInline {ACRONYM} at (0,0) size 21x19
-        RenderText {#text} at (240,1) size 21x19
-          text run at (240,1) width 21: "CSS"
-      RenderText {#text} at (260,1) size 42x19
-        text run at (260,1) width 42: " Design"
-layer at (173,352) size 454x134
+    RenderInline {SPAN} at (0,0) size 149x19
+      RenderText {#text} at (152,1) size 88x19
+        text run at (152,1) width 88: "The Beauty of "
+      RenderInline {ACRONYM} at (0,0) size 22x19
+        RenderText {#text} at (239,1) size 22x19
+          text run at (239,1) width 22: "CSS"
+      RenderText {#text} at (260,1) size 41x19
+        text run at (260,1) width 41: " Design"
+layer at (173,351) size 454x135
   RenderBlock (positioned) {DIV} at (0,319) size 454x135
-    RenderInline {P} at (0,0) size 430x28
-      RenderInline {SPAN} at (0,0) size 430x28
-        RenderText {#text} at (12,0) size 430x28
-          text run at (12,0) width 430: "Littering a dark and dreary road lay the past relics of browser-"
-          text run at (12,14) width 196: "specific tags, incompatible "
+    RenderInline {P} at (0,0) size 429x28
+      RenderInline {SPAN} at (0,0) size 429x28
+        RenderText {#text} at (12,0) size 429x28
+          text run at (12,0) width 429: "Littering a dark and dreary road lay the past relics of browser-"
+          text run at (12,14) width 195: "specific tags, incompatible "
         RenderInline {ACRONYM} at (0,0) size 32x14
-          RenderText {#text} at (208,14) size 32x14
-            text run at (208,14) width 32: "DOM"
-        RenderText {#text} at (240,14) size 111x14
-          text run at (240,14) width 111: "s, and broken "
+          RenderText {#text} at (207,14) size 32x14
+            text run at (207,14) width 32: "DOM"
+        RenderText {#text} at (239,14) size 111x14
+          text run at (239,14) width 111: "s, and broken "
         RenderInline {ACRONYM} at (0,0) size 27x14
-          RenderText {#text} at (351,14) size 27x14
-            text run at (351,14) width 27: "CSS"
-        RenderText {#text} at (378,14) size 64x14
-          text run at (378,14) width 64: " support."
+          RenderText {#text} at (350,14) size 27x14
+            text run at (350,14) width 27: "CSS"
+        RenderText {#text} at (377,14) size 64x14
+          text run at (377,14) width 64: " support."
     RenderText {#text} at (0,0) size 0x0
-    RenderInline {P} at (0,0) size 430x42
-      RenderInline {SPAN} at (0,0) size 430x42
-        RenderText {#text} at (12,28) size 430x42
-          text run at (12,28) width 430: "Today, we must clear the mind of past practices. Web"
-          text run at (12,42) width 430: "enlightenment has been achieved thanks to the tireless efforts of"
+    RenderInline {P} at (0,0) size 429x42
+      RenderInline {SPAN} at (0,0) size 429x42
+        RenderText {#text} at (12,28) size 429x42
+          text run at (12,28) width 429: "Today, we must clear the mind of past practices. Web"
+          text run at (12,42) width 429: "enlightenment has been achieved thanks to the tireless efforts of"
           text run at (12,56) width 88: "folk like the "
         RenderInline {ACRONYM} at (0,0) size 32x14
           RenderText {#text} at (100,56) size 32x14
@@ -67,21 +67,21 @@ layer at (173,352) size 454x134
         RenderInline {ACRONYM} at (0,0) size 40x14
           RenderText {#text} at (142,56) size 40x14
             text run at (142,56) width 40: "WaSP"
-        RenderText {#text} at (182,56) size 229x14
-          text run at (182,56) width 229: " and the major browser creators."
-    RenderText {#text} at (411,56) size 7x14
-      text run at (411,56) width 7: " "
+        RenderText {#text} at (182,56) size 228x14
+          text run at (182,56) width 228: " and the major browser creators."
+    RenderText {#text} at (410,56) size 7x14
+      text run at (410,56) width 7: " "
     RenderInline {P} at (0,0) size 430x70
       RenderInline {SPAN} at (0,0) size 430x70
-        RenderText {#text} at (418,56) size 430x70
-          text run at (418,56) width 24: "The"
-          text run at (12,70) width 430: "css Zen Garden invites you to relax and meditate on the"
+        RenderText {#text} at (417,56) size 430x70
+          text run at (417,56) width 24: "The"
+          text run at (12,70) width 429: "css Zen Garden invites you to relax and meditate on the"
           text run at (12,84) width 430: "important lessons of the masters. Begin to see with clarity. Learn"
-          text run at (12,98) width 430: "to use the (yet to be) time-honored techniques in new and"
+          text run at (12,98) width 429: "to use the (yet to be) time-honored techniques in new and"
           text run at (12,112) width 313: "invigorating fashion. Become one with the web."
     RenderText {#text} at (0,0) size 0x0
-layer at (322,236) size 306x80
-  RenderBlock (positioned) {H3} at (148,-117) size 306x81 [color=#CCCC77] [bgcolor=#888811] [border: (3px solid #888811) none (3px solid #888811)]
+layer at (321,235) size 306x80
+  RenderBlock (positioned) {H3} at (148,-116) size 306x81 [color=#CCCC77] [bgcolor=#888811] [border: (3px solid #888811) none (3px solid #888811)]
     RenderInline {SPAN} at (0,0) size 277x83
       RenderText {#text} at (45,-2) size 277x83
         text run at (45,-2) width 230: "The Road to"
index 5e1d465..ca06881 100644 (file)
@@ -111,6 +111,7 @@ fast/sub-pixel/float-wrap-with-subpixel-top.html
 fast/sub-pixel/inline-block-with-margin.html
 fast/sub-pixel/inline-block-with-padding.html
 fast/sub-pixel/layout-boxes-with-zoom.html
+fast/sub-pixel/position-right-aligns-with-container.html
 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
 fast/sub-pixel/size-of-box-with-zoom.html
 fast/sub-pixel/table-rows-no-gaps.html
index 2a451a7..0e368c9 100644 (file)
@@ -205,6 +205,7 @@ fast/sub-pixel/float-wrap-with-subpixel-top.html
 fast/sub-pixel/inline-block-with-margin.html
 fast/sub-pixel/inline-block-with-padding.html
 fast/sub-pixel/layout-boxes-with-zoom.html
+fast/sub-pixel/position-right-aligns-with-container.html
 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
 fast/sub-pixel/size-of-box-with-zoom.html
 fast/sub-pixel/table-rows-no-gaps.html
index b183884..2bccbcd 100644 (file)
@@ -211,6 +211,7 @@ fast/sub-pixel/float-wrap-with-subpixel-top.html
 fast/sub-pixel/inline-block-with-margin.html
 fast/sub-pixel/inline-block-with-padding.html
 fast/sub-pixel/layout-boxes-with-zoom.html
+fast/sub-pixel/position-right-aligns-with-container.html
 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
 fast/sub-pixel/size-of-box-with-zoom.html
 fast/sub-pixel/table-rows-no-gaps.html
index eea7552..3e461f6 100644 (file)
@@ -819,6 +819,7 @@ fast/sub-pixel/float-wrap-with-subpixel-top.html
 fast/sub-pixel/inline-block-with-margin.html
 fast/sub-pixel/inline-block-with-padding.html
 fast/sub-pixel/layout-boxes-with-zoom.html
+fast/sub-pixel/position-right-aligns-with-container.html
 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
 fast/sub-pixel/size-of-box-with-zoom.html
 fast/sub-pixel/table-rows-no-gaps.html
index 7737705..3a5228a 100644 (file)
@@ -98,6 +98,7 @@ fast/sub-pixel/float-wrap-with-subpixel-top.html
 fast/sub-pixel/inline-block-with-margin.html
 fast/sub-pixel/inline-block-with-padding.html
 fast/sub-pixel/layout-boxes-with-zoom.html
+fast/sub-pixel/position-right-aligns-with-container.html
 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
 fast/sub-pixel/size-of-box-with-zoom.html
 fast/sub-pixel/table-rows-no-gaps.html
index 95999fa..5ba11fd 100644 (file)
@@ -547,6 +547,7 @@ fast/images/imagemap-scroll.html
 fast/multicol/progression-reverse.html
 fast/overflow/scroll-vertical-not-horizontal.html
 fast/repaint/fixed-tranformed.html
+fast/sub-pixel/position-right-aligns-with-container.html
 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
 fast/sub-pixel/table-rows-have-stable-height.html
 fast/table/height-percent-test-vertical.html
index 48780c5..e64ae41 100644 (file)
@@ -271,6 +271,7 @@ fast/sub-pixel/float-wrap-with-subpixel-top.html
 fast/sub-pixel/inline-block-with-margin.html
 fast/sub-pixel/inline-block-with-padding.html
 fast/sub-pixel/layout-boxes-with-zoom.html
+fast/sub-pixel/position-right-aligns-with-container.html
 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
 fast/sub-pixel/size-of-box-with-zoom.html
 fast/sub-pixel/table-rows-no-gaps.html
index e826927..ece88dd 100644 (file)
@@ -944,6 +944,7 @@ fast/sub-pixel/float-wrap-with-subpixel-top.html
 fast/sub-pixel/inline-block-with-margin.html
 fast/sub-pixel/inline-block-with-padding.html
 fast/sub-pixel/layout-boxes-with-zoom.html
+fast/sub-pixel/position-right-aligns-with-container.html
 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
 fast/sub-pixel/size-of-box-with-zoom.html
 fast/sub-pixel/table-rows-no-gaps.html
index 0dc22a8..7b101d3 100644 (file)
@@ -44,6 +44,7 @@ fast/sub-pixel/float-wrap-with-subpixel-top.html
 fast/sub-pixel/inline-block-with-margin.html
 fast/sub-pixel/inline-block-with-padding.html
 fast/sub-pixel/layout-boxes-with-zoom.html
+fast/sub-pixel/position-right-aligns-with-container.html
 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
 fast/sub-pixel/size-of-box-with-zoom.html
 fast/sub-pixel/table-rows-no-gaps.html
index f7f8cc8..a5fac59 100644 (file)
@@ -1736,6 +1736,7 @@ fast/sub-pixel/float-wrap-with-subpixel-top.html
 fast/sub-pixel/inline-block-with-margin.html
 fast/sub-pixel/inline-block-with-padding.html
 fast/sub-pixel/layout-boxes-with-zoom.html
+fast/sub-pixel/position-right-aligns-with-container.html
 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
 fast/sub-pixel/size-of-box-with-zoom.html
 fast/sub-pixel/table-rows-no-gaps.html
index 76fc98f..936c03d 100644 (file)
@@ -2125,6 +2125,7 @@ fast/sub-pixel/float-wrap-with-subpixel-top.html
 fast/sub-pixel/inline-block-with-margin.html
 fast/sub-pixel/inline-block-with-padding.html
 fast/sub-pixel/layout-boxes-with-zoom.html
+fast/sub-pixel/position-right-aligns-with-container.html
 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
 fast/sub-pixel/size-of-box-with-zoom.html
 fast/sub-pixel/table-rows-no-gaps.html
index efec0d6..24df713 100644 (file)
@@ -94,6 +94,7 @@ fast/sub-pixel/float-wrap-with-subpixel-top.html
 fast/sub-pixel/inline-block-with-margin.html
 fast/sub-pixel/inline-block-with-padding.html
 fast/sub-pixel/layout-boxes-with-zoom.html
+fast/sub-pixel/position-right-aligns-with-container.html
 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
 fast/sub-pixel/size-of-box-with-zoom.html
 fast/sub-pixel/table-rows-no-gaps.html
index 149f57f..a0c4c7d 100644 (file)
@@ -1,3 +1,22 @@
+2012-07-26  Emil A Eklund  <eae@chromium.org>
+
+        Contained div with right 0 sometimes overlaps parent div
+        https://bugs.webkit.org/show_bug.cgi?id=91521
+
+        Reviewed by Levi Weintraub.
+
+        Due to unnecessary rounding in clientLogicalWidth and clientLogicalHeight
+        we lost precision when computing the width and position of render boxes.
+        Change clientLogicalWidth/Height to return values with subpixel precision
+        to avoid this.
+
+        Test: fast/sub-pixel/position-right-aligns-with-container.html
+
+        * rendering/RenderBox.h:
+        (WebCore::RenderBox::clientLogicalWidth):
+        (WebCore::RenderBox::clientLogicalHeight):
+        Remove unnecessary rounding.
+
 2012-07-26  Chang Shu  <cshu@webkit.org>
 
         Build broken when svg is disabled.
         * platform/win/ScrollbarThemeWin.cpp:
         (WebCore::ScrollbarThemeWin::paintThumb):
 
+2012-07-26  Olivier Blin  <olivier.blin@softathome.com>
+
+        Add FastMalloc statistics in window.internals
+        https://bugs.webkit.org/show_bug.cgi?id=91274
+
+        Reviewed by Ryosuke Niwa.
+
+        Test: fast/harness/fastmallocstatistics-object.html
+
+        * CMakeLists.txt:
+        * DerivedSources.make:
+        * DerivedSources.pri:
+        * GNUmakefile.list.am:
+        * Target.pri:
+        * WebCore.gyp/WebCore.gyp:
+        * WebCore.gypi:
+        * WebCore.vcproj/WebCoreTestSupport.vcproj:
+        * WebCore.xcodeproj/project.pbxproj:
+        * testing/FastMallocStatistics.h: Added.
+        (WebCore):
+        (FastMallocStatistics):
+        (WebCore::FastMallocStatistics::create):
+        (WebCore::FastMallocStatistics::reservedVMBytes):
+        (WebCore::FastMallocStatistics::committedVMBytes):
+        (WebCore::FastMallocStatistics::freeListBytes):
+        (WebCore::FastMallocStatistics::FastMallocStatistics):
+        * testing/FastMallocStatistics.idl: Added.
+        * testing/Internals.cpp:
+        (WebCore::Internals::fastMallocStatistics):
+        (WebCore):
+        * testing/Internals.h:
+        (WebCore):
+        (Internals):
+        * testing/Internals.idl:
+
+2012-07-26  Adrienne Walker  <enne@google.com>
+
+        [chromium] Remove redundant surface origin transforms
+        https://bugs.webkit.org/show_bug.cgi?id=91815
+
+        Reviewed by Stephen White.
+
+        Bug 91417 changed draw transforms to become equivalent to origin
+        transforms for surfaces. This change removes them as they are no
+        longer needed for anything.
+
+        No new tests. Just a refactoring.
+
+        * platform/graphics/chromium/RenderSurfaceChromium.h:
+        (RenderSurfaceChromium):
+        * platform/graphics/chromium/cc/CCDamageTracker.cpp:
+        (WebCore::CCDamageTracker::extendDamageForRenderSurface):
+        * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
+        (WebCore::computeScrollCompensationMatrixForChildren):
+        (WebCore::calculateDrawTransformsInternal):
+        * platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
+        (WebCore::::leaveToRenderTarget):
+        (WebCore::::unoccludedContributingSurfaceContentRect):
+        * platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
+        (WebCore::CCRenderPassDrawQuad::create):
+        (WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
+        * platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
+        (CCRenderPassDrawQuad):
+        * platform/graphics/chromium/cc/CCRenderSurface.cpp:
+        (WebCore::CCRenderSurface::createSharedQuadState):
+        (WebCore::CCRenderSurface::createReplicaSharedQuadState):
+        (WebCore::CCRenderSurface::appendQuads):
+        * platform/graphics/chromium/cc/CCRenderSurface.h:
+        (CCRenderSurface):
+
+2012-07-25  Andrey Kosyakov  <caseq@chromium.org>
+
+        Web Inspector: simplify handling of status bar items
+        https://bugs.webkit.org/show_bug.cgi?id=92143
+
+        Reviewed by Pavel Feldman.
+
+        - split status bars into "global" (always in the bottom) and "panel"
+            (on top of the drawer when drawer is shown)
+        - use "inner" status bar section in global status bar to display either
+            panel status bar items or drawer view items (depending on drawer visibility)
+        - let panels/views manage their counters as part of their status bar
+            items, not through special interface members;
+        - get rid of absolute positioning in the status bars where possible;
+
+        * inspector/front-end/AdvancedSearchController.js:
+        (WebInspector.SearchView.prototype.get statusBarItems):
+        * inspector/front-end/Drawer.js:
+        (WebInspector.Drawer):
+        (WebInspector.Drawer.prototype.show.animationFinished):
+        (WebInspector.Drawer.prototype.show):
+        (WebInspector.Drawer.prototype.hide.animationFinished):
+        (WebInspector.Drawer.prototype.hide):
+        (WebInspector.Drawer.prototype._startStatusBarDragging):
+        * inspector/front-end/Panel.js:
+        (WebInspector.Panel.prototype.wasShown):
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel.prototype.get statusBarItems):
+        (WebInspector.TimelinePanel.prototype.willHide):
+        * inspector/front-end/elementsPanel.css:
+        (.crumbs):
+        * inspector/front-end/inspector.css:
+        (#main):
+        (body.drawer-visible #main-panels):
+        (.status-bar):
+        (.status-bar-item):
+        (#panel-status-bar-placeholder):
+        (body.drawer-visible #panel-status-bar-placeholder):
+        (#panel-status-bar-resizer):
+        (#panel-status-bar):
+        (#panel-status-bar > div):
+        (#error-warning-count):
+        (#drawer):
+        (#drawer-contents):
+        (.status-bar-items):
+        (.drawer-header):
+        (#inner-status-bar):
+        (.search-status-bar-item):
+        (.search-status-bar-message):
+        (.search-status-bar-progress):
+        (body:not(.platform-mac) .search-status-bar-progress):
+        (body.platform-mac .search-status-bar-progress):
+        (.search-status-bar-stop-button-item):
+        (.search-status-bar-stop-button .glyph):
+        (.search-results-status-bar-message):
+        * inspector/front-end/inspector.html:
+        * inspector/front-end/inspector.js:
+        (WebInspector._createGlobalStatusBarItems):
+        (WebInspector.showViewInDrawer):
+        (WebInspector._closePreviousDrawerView):
+        * inspector/front-end/timelinePanel.css:
+        (.timeline-records-counter):
+
+2012-07-26  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL][WK2] Implement Network Information provider
+        https://bugs.webkit.org/show_bug.cgi?id=92343
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Moved Network Information provider code from WebKit1
+        to WebCore so that it can be shared with WebKit2.
+
+        No new tests, no behavior change.
+
+        * PlatformEfl.cmake:
+        * platform/efl/NetworkInfoProviderEfl.cpp: Copied from Source/WebKit/efl/WebCoreSupport/NetworkInfoClientEfl.cpp.
+        (WebCore):
+        (WebCore::NetworkInfoProviderEfl::NetworkInfoProviderEfl):
+        (WebCore::NetworkInfoProviderEfl::startUpdating):
+        (WebCore::NetworkInfoProviderEfl::stopUpdating):
+        (WebCore::NetworkInfoProviderEfl::bandwidth):
+        * platform/efl/NetworkInfoProviderEfl.h: Added.
+        (WebCore):
+        (NetworkInfoProviderEfl):
+
+2012-07-25  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: SASS source mapping straw man (behind experiment)
+        https://bugs.webkit.org/show_bug.cgi?id=92265
+
+        Reviewed by Vsevolod Vlasov.
+
+        This change introduces SASS mapping support (behind the experiment).
+
+        * WebCore.gypi:
+        * WebCore.vcproj/WebCore.vcproj:
+        * inspector/compile-front-end.py:
+        * inspector/front-end/CSSStyleModel.js:
+        (WebInspector.CSSStyleModel):
+        (WebInspector.CSSStyleModel.prototype.resourceBinding):
+        (WebInspector.CSSStyleModel.prototype.setSourceMapping):
+        (WebInspector.CSSStyleModel.prototype.resetSourceMappings):
+        (WebInspector.CSSStyleModel.prototype._rawLocationToUILocation):
+        (WebInspector.CSSLocation):
+        (WebInspector.CSSRule):
+        (WebInspector.CSSRule.prototype.get isRegular):
+        (WebInspector.CSSRule.prototype.uiLocation):
+        * inspector/front-end/ContentProviders.js:
+        (WebInspector.StaticContentProvider.prototype.contentType):
+        * inspector/front-end/SASSSourceMapping.js: Added.
+        (WebInspector.SASSSourceMapping):
+        (WebInspector.SASSSourceMapping.prototype._populate):
+        (WebInspector.SASSSourceMapping.prototype._resourceAdded.didRequestContent):
+        (WebInspector.SASSSourceMapping.prototype._resourceAdded):
+        (rawLocationToUILocation):
+        (uiLocationToRawLocation):
+        (uiSourceCodes):
+        (reset):
+        (WebInspector.SASSSource):
+        (WebInspector.SASSSource.prototype.isEditable):
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel.prototype._createSourceFrame):
+        * inspector/front-end/Settings.js:
+        (WebInspector.ExperimentsSettings):
+        * inspector/front-end/StylesPanel.js:
+        (WebInspector.StylesUISourceCodeProvider):
+        (WebInspector.StylesUISourceCodeProvider.prototype.rawLocationToUILocation):
+        (WebInspector.StylesUISourceCodeProvider.prototype.uiLocationToRawLocation):
+        (WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
+        (WebInspector.StylesUISourceCodeProvider.prototype.reset):
+        * inspector/front-end/StylesSidebarPane.js:
+        (WebInspector.StylePropertyTreeElement.prototype):
+        * inspector/front-end/UISourceCode.js:
+        (WebInspector.UILocation.prototype.uiLocationToRawLocation):
+        (WebInspector.UILocation.prototype.url):
+        * inspector/front-end/Workspace.js:
+        (WebInspector.Workspace):
+        * inspector/front-end/inspector.html:
+
+2012-07-26  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Unreviewed r123761 follow-up, inspector closure compilation fix.
+
+        * inspector/front-end/Script.js:
+        (WebInspector.Script.Location.prototype.uiLocation):
+        * inspector/front-end/ScriptSnippetModel.js:
+
+2012-07-26  Patrick Gansterer  <paroga@webkit.org>
+
+        Cleanup GraphicsContext::(getWindowsContext|releaseWindowsContext)
+        https://bugs.webkit.org/show_bug.cgi?id=92113
+
+        Reviewed by Simon Hausmann.
+
+        Cleanup the definition of the two methods across different ports and
+        replace the calls to them with LocalWindowsContext where possible.
+
+        * platform/graphics/GraphicsContext.h:
+        (GraphicsContext):
+        * platform/win/ScrollbarThemeWin.cpp:
+        (WebCore::ScrollbarThemeWin::paintThumb):
+
+2012-07-27 Chris Fleizach <cfleizach@apple.com>
+
+        WebKit should expose @title as label (AXTitle or AXDescription) sometimes instead of AXHelp, according to the ARIA text alt computation
+        https://bugs.webkit.org/show_bug.cgi?id=91911
+
+        Reviewed by Anders Carlsson.
+
+        The ARIA spec states that the title attribute should be used as the last resort for a description of an element. WebKit needs to honor that.
+
+        Test: platform/mac/accessibility/title-attribute-used-as-last-resort.html
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::helpText):
+        (WebCore::AccessibilityRenderObject::accessibilityDescription):
+
+2012-07-26  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Unreviewed r123761 follow-up, inspector closure compilation fix.
+
+        * inspector/front-end/Script.js:
+        (WebInspector.Script.Location.prototype.uiLocation):
+        * inspector/front-end/ScriptSnippetModel.js:
+
+2012-07-26  Patrick Gansterer  <paroga@webkit.org>
+
+        Cleanup GraphicsContext::(getWindowsContext|releaseWindowsContext)
+        https://bugs.webkit.org/show_bug.cgi?id=92113
+
+        Reviewed by Simon Hausmann.
+
+        Cleanup the definition of the two methods across different ports and
+        replace the calls to them with LocalWindowsContext where possible.
+
+        * platform/graphics/GraphicsContext.h:
+        (GraphicsContext):
+        * platform/win/ScrollbarThemeWin.cpp:
+        (WebCore::ScrollbarThemeWin::paintThumb):
+
+2012-07-26  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Unreviewed r123761 follow-up, inspector closure compilation fix.
+
+        * inspector/front-end/Script.js:
+        (WebInspector.Script.Location.prototype.uiLocation):
+        * inspector/front-end/ScriptSnippetModel.js:
+
+2012-07-26  Patrick Gansterer  <paroga@webkit.org>
+
+        Cleanup GraphicsContext::(getWindowsContext|releaseWindowsContext)
+        https://bugs.webkit.org/show_bug.cgi?id=92113
+
+        Reviewed by Simon Hausmann.
+
+        Cleanup the definition of the two methods across different ports and
+        replace the calls to them with LocalWindowsContext where possible.
+
+        * platform/graphics/GraphicsContext.h:
+        (GraphicsContext):
+        * platform/win/ScrollbarThemeWin.cpp:
+        (WebCore::ScrollbarThemeWin::paintThumb):
+
 2012-07-26  Vsevolod Vlasov  <vsevik@chromium.org>
 
         Web Inspector: Introduce generic LiveLocation, make Script.Location inherit it.
index 488c584..bbb0344 100644 (file)
@@ -201,8 +201,8 @@ public:
     LayoutUnit clientTop() const { return borderTop(); }
     LayoutUnit clientWidth() const;
     LayoutUnit clientHeight() const;
-    LayoutUnit clientLogicalWidth() const { return style()->isHorizontalWritingMode() ? pixelSnappedClientWidth() : pixelSnappedClientHeight(); }
-    LayoutUnit clientLogicalHeight() const { return style()->isHorizontalWritingMode() ? pixelSnappedClientHeight() : pixelSnappedClientWidth(); }
+    LayoutUnit clientLogicalWidth() const { return style()->isHorizontalWritingMode() ? clientWidth() : clientHeight(); }
+    LayoutUnit clientLogicalHeight() const { return style()->isHorizontalWritingMode() ? clientHeight() : clientWidth(); }
     LayoutUnit clientLogicalBottom() const { return borderBefore() + clientLogicalHeight(); }
     LayoutRect clientBoxRect() const { return LayoutRect(clientLeft(), clientTop(), clientWidth(), clientHeight()); }
 
index 94fa880..986c536 100644 (file)
         * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:
         (EWK2UnitTestServer::EWK2UnitTestServer):
 
+2012-07-26  Thiago Marcos P. Santos  <thiago.santos@intel.com>
+
+        [EFL][WK2] Regression(r123731): Linking errors due to efreet functions
+        https://bugs.webkit.org/show_bug.cgi?id=92378
+
+        Unreviewed build fix.
+
+        The library list created by PlatformEfl.cmake was being erased by a
+        SET called after including the platform specific file. Luckily the
+        dependencies were fulfilled by other targets until efreet was add.
+
+        * CMakeLists.txt:
+
+2012-07-26  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL][WK2] Compilation warning in EWK2UnitTestServer.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=92387
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Fix compilation warning in EWK2UnitTestServer.cpp.
+
+        * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:
+        (EWK2UnitTestServer::EWK2UnitTestServer):
+
+2012-07-26  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL][WK2] Implement Network Information provider
+        https://bugs.webkit.org/show_bug.cgi?id=92343
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Add Network Information provider for WebKit2 EFL
+        by using NetworkInfoProviderEfl class from
+        WebCore.
+
+        * CMakeLists.txt:
+        * PlatformEfl.cmake:
+        * UIProcess/API/efl/NetworkInfoProvider.cpp: Added.
+        (toNetworkInfoProvider):
+        (startUpdatingCallback):
+        (stopUpdatingCallback):
+        (getBandwidthCallback):
+        (isMeteredCallback):
+        (NetworkInfoProvider::create):
+        (NetworkInfoProvider::NetworkInfoProvider):
+        (NetworkInfoProvider::~NetworkInfoProvider):
+        (NetworkInfoProvider::bandwidth):
+        (NetworkInfoProvider::metered):
+        (NetworkInfoProvider::startUpdating):
+        (NetworkInfoProvider::stopUpdating):
+        * UIProcess/API/efl/NetworkInfoProvider.h: Added.
+        (NetworkInfoProvider):
+
+2012-07-26  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL][WK2] Compilation warning in EWK2UnitTestServer.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=92387
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Fix compilation warning in EWK2UnitTestServer.cpp.
+
+        * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:
+        (EWK2UnitTestServer::EWK2UnitTestServer):
+
 2012-07-26  Christophe Dumez  <christophe.dumez@intel.com>
 
         [EFL][WK2] Add unit tests for Ewk_Context
index 9066cf3..33c7112 100644 (file)
 
         * GNUmakefile.am:
 
+2012-07-26  Olivier Blin  <olivier.blin@softathome.com>
+
+        Add FastMalloc statistics in window.internals
+        https://bugs.webkit.org/show_bug.cgi?id=91274
+
+        Reviewed by Ryosuke Niwa.
+
+        * GNUmakefile.am:
+
 2012-07-20  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
 
         buildbot: Remove the configuration of hfreyther*