[CSS Blending] Log blending as a layer creation reason in the WI
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 10 Jan 2014 21:42:07 +0000 (21:42 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 10 Jan 2014 21:42:07 +0000 (21:42 +0000)
https://bugs.webkit.org/show_bug.cgi?id=126159

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-01-10
Reviewed by Timothy Hatcher.

Source/WebCore:

* inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
* inspector/protocol/LayerTree.json:

Source/WebInspectorUI:

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._populateListOfCompositingReasons):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/inspector/InspectorLayerTreeAgent.cpp
Source/WebCore/inspector/protocol/LayerTree.json
Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
Source/WebInspectorUI/UserInterface/LayerTreeSidebarPanel.js

index 0cf1a83..f1c5ef1 100644 (file)
@@ -1,3 +1,14 @@
+2014-01-10  Joseph Pecoraro  <pecoraro@apple.com>
+
+        [CSS Blending] Log blending as a layer creation reason in the WI
+        https://bugs.webkit.org/show_bug.cgi?id=126159
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/InspectorLayerTreeAgent.cpp:
+        (WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
+        * inspector/protocol/LayerTree.json:
+
 2014-01-10  Andy Estes  <aestes@apple.com>
 
         Fix some iOS build errors during bindings generation.
index c96830e..385a397 100644 (file)
@@ -307,6 +307,9 @@ void InspectorLayerTreeAgent::reasonsForCompositingLayer(ErrorString* errorStrin
 
     if (reasonsBitmask & CompositingReasonRoot)
         compositingReasons->setRoot(true);
+
+    if (reasonsBitmask & CompositingReasonBlending)
+        compositingReasons->setBlending(true);
 }
 
 String InspectorLayerTreeAgent::bind(const RenderLayer* layer)
index 1e2a471..33f7dbf 100644 (file)
@@ -69,7 +69,8 @@
                 { "name": "blendingWithCompositedDescendants", "type": "boolean", "optional": true, "description": "Composition due to association with an element with CSS blending applied and composited descendants." },
                 { "name": "perspective", "type": "boolean", "optional": true, "description": "Composition due to association with an element with perspective applied." },
                 { "name": "preserve3D", "type": "boolean", "optional": true, "description": "Composition due to association with an element with a \"transform-style: preserve-3d\" style." },
-                { "name": "root", "type": "boolean", "optional": true, "description": "Composition due to association with the root element." }
+                { "name": "root", "type": "boolean", "optional": true, "description": "Composition due to association with the root element." },
+                { "name": "blending", "type": "boolean", "optional": true, "description": "Composition due to association with an element with a \"blend-mode\" style." }
             ]
         }
     ],
index 9fe3d27..f769ff4 100644 (file)
@@ -1,3 +1,14 @@
+2014-01-10  Joseph Pecoraro  <pecoraro@apple.com>
+
+        [CSS Blending] Log blending as a layer creation reason in the WI
+        https://bugs.webkit.org/show_bug.cgi?id=126159
+
+        Reviewed by Timothy Hatcher.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/LayerTreeSidebarPanel.js:
+        (WebInspector.LayerTreeSidebarPanel.prototype._populateListOfCompositingReasons):
+
 2014-01-10  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
 
         Add missing function stub in InspectorFrontendHostStub.js
index d138ecc..94d8865 100644 (file)
Binary files a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js and b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js differ
index 9310431..fbe9ed0 100644 (file)
@@ -428,6 +428,8 @@ WebInspector.LayerTreeSidebarPanel.prototype = {
             addReason(WebInspector.UIString("Element has “transform-style: preserve-3d” style"));
         if (compositingReasons.root)
             addReason(WebInspector.UIString("Element is the root element"));
+        if (compositingReasons.blending)
+            addReason(WebInspector.UIString("Element has “blend-mode” style"));
     }
 };