[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https...
authorjiewen_tan@apple.com <jiewen_tan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 21 Dec 2018 22:39:32 +0000 (22:39 +0000)
committerjiewen_tan@apple.com <jiewen_tan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 21 Dec 2018 22:39:32 +0000 (22:39 +0000)
https://bugs.webkit.org/show_bug.cgi?id=192061

Reviewed by Dewei Zhu.

Part 5.

Add some additional temporary logging info to determine if the time out value passed to the timer is respected.
Once the bug is determined and fixed, we should remove all logging added in this patch.

Reviewed by Dewei Zhu.

* UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::initTimeOutTimer):
(WebKit::AuthenticatorManager::timeOutTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp

index 7a618e9..3f243d7 100644 (file)
@@ -1,3 +1,21 @@
+2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
+
+        [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
+        https://bugs.webkit.org/show_bug.cgi?id=192061
+
+        Reviewed by Dewei Zhu.
+
+        Part 5.
+
+        Add some additional temporary logging info to determine if the time out value passed to the timer is respected.
+        Once the bug is determined and fixed, we should remove all logging added in this patch.
+
+        Reviewed by Dewei Zhu.
+
+        * UIProcess/WebAuthentication/AuthenticatorManager.cpp:
+        (WebKit::AuthenticatorManager::initTimeOutTimer):
+        (WebKit::AuthenticatorManager::timeOutTimerFired):
+
 2018-12-21  Keith Rollin  <krollin@apple.com>
 
         Crash in com.apple.WebKit: WebKit::WebResourceLoader::willSendRequest + 223
index 73f55a4..2f924c9 100644 (file)
@@ -30,6 +30,7 @@
 
 #include <WebCore/AuthenticatorTransport.h>
 #include <WebCore/PublicKeyCredentialCreationOptions.h>
+#include <wtf/MonotonicTime.h>
 
 namespace WebKit {
 using namespace WebCore;
@@ -226,15 +227,16 @@ void AuthenticatorManager::initTimeOutTimer(const Optional<unsigned>& timeOutInM
 
     unsigned timeOutInMsValue = std::min(maxTimeOutValue, timeOutInMs.valueOr(maxTimeOutValue));
     // FIXME(192061)
-    LOG_ERROR("Start timer. %d", timeOutInMsValue);
+    LOG_ERROR("Start timer: %d. Current time: %f.", timeOutInMsValue, MonotonicTime::now().secondsSinceEpoch().value());
     m_requestTimeOutTimer.startOneShot(Seconds::fromMilliseconds(timeOutInMsValue));
+    LOG_ERROR("Seconds until fire: %f", m_requestTimeOutTimer.secondsUntilFire().value());
 }
 
 void AuthenticatorManager::timeOutTimerFired()
 {
     ASSERT(m_requestTimeOutTimer.isActive());
     // FIXME(192061)
-    LOG_ERROR("Timer fired.");
+    LOG_ERROR("Timer fired: %f, Current time: %f", m_requestTimeOutTimer.secondsUntilFire().value(), MonotonicTime::now().secondsSinceEpoch().value());
     m_pendingCompletionHandler((ExceptionData { NotAllowedError, "Operation timed out."_s }));
     clearStateAsync();
 }