2010-07-25 Darin Adler <darin@apple.com>
authordarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 26 Jul 2010 06:57:55 +0000 (06:57 +0000)
committerdarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 26 Jul 2010 06:57:55 +0000 (06:57 +0000)
        Reviewed by Dan Bernstein.

        WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
        https://bugs.webkit.org/show_bug.cgi?id=42326

        * platform/mac-wk2/Skipped: Removed all the tests from the list
        that were there only because they called dumpSelectionRect. Most of
        them pass now.
2010-07-25  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
        https://bugs.webkit.org/show_bug.cgi?id=42326

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        Added dumpSelectionRect.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
        (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
        does nothing because its purpose is to change pixel test output and
        we do not have pixel tests implemented yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/mac-wk2/Skipped
WebKitTools/ChangeLog
WebKitTools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl
WebKitTools/WebKitTestRunner/InjectedBundle/LayoutTestController.h

index 2ff6263..f24be96 100644 (file)
@@ -1,3 +1,14 @@
+2010-07-25  Darin Adler  <darin@apple.com>
+
+        Reviewed by Dan Bernstein.
+
+        WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
+        https://bugs.webkit.org/show_bug.cgi?id=42326
+
+        * platform/mac-wk2/Skipped: Removed all the tests from the list
+        that were there only because they called dumpSelectionRect. Most of
+        them pass now.
+
 2010-07-23  Philippe Normand  <pnormand@igalia.com>
 
         Reviewed by Eric Carlson.
index f292462..42f5b26 100644 (file)
@@ -1779,37 +1779,6 @@ webarchive/test-table-background.html
 webarchive/test-td-background.html
 webarchive/test-xml-stylesheet.xml
 
-# WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
-# <https://bugs.webkit.org/show_bug.cgi?id=42326>
-svg/text/foreignObject-text-clipping-bug.xml
-svg/text/text-align-01-b.svg
-svg/text/text-align-02-b.svg
-svg/text/text-align-03-b.svg
-svg/text/text-align-04-b.svg
-svg/text/text-align-05-b.svg
-svg/text/text-align-06-b.svg
-svg/text/text-altglyph-01-b.svg
-svg/text/text-deco-01-b.svg
-svg/text/text-fonts-01-t.svg
-svg/text/text-fonts-02-t.svg
-svg/text/text-intro-05-t.svg
-svg/text/text-path-01-b.svg
-svg/text/text-spacing-01-b.svg
-svg/text/text-text-01-b.svg
-svg/text/text-text-03-b.svg
-svg/text/text-text-04-t.svg
-svg/text/text-text-05-t.svg
-svg/text/text-text-06-t.svg
-svg/text/text-text-07-t.svg
-svg/text/text-text-08-b.svg
-svg/text/text-tref-01-b.svg
-svg/text/text-tselect-01-b.svg
-svg/text/text-tselect-02-f.svg
-svg/text/text-tspan-01-b.svg
-svg/text/text-ws-01-t.svg
-svg/text/text-ws-02-t.svg
-svg/text/textPathBoundsBug.svg
-
 # WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
 # <https://bugs.webkit.org/show_bug.cgi?id=42327>
 http/tests/security/isolatedWorld/all-window-properties.html
index 4cd7ab0..317c4f4 100644 (file)
@@ -1,5 +1,20 @@
 2010-07-25  Darin Adler  <darin@apple.com>
 
+        Reviewed by Dan Bernstein.
+
+        WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
+        https://bugs.webkit.org/show_bug.cgi?id=42326
+
+        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
+        Added dumpSelectionRect.
+
+        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
+        (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
+        does nothing because its purpose is to change pixel test output and
+        we do not have pixel tests implemented yet.
+
+2010-07-25  Darin Adler  <darin@apple.com>
+
         Reviewed by Maciej Stachowiak.
 
         WebKitTestRunner needs to support layoutTestController.keepWebHistory
index ea7b835..08e93b6 100644 (file)
@@ -35,6 +35,7 @@ module WTR {
         // Other dumping.
         void dumpChildFrameScrollPositions();
         void dumpEditingCallbacks();
+        void dumpSelectionRect();
         void dumpStatusCallbacks();
 
         // Special options.
index 8d52bb7..3f24064 100644 (file)
@@ -53,6 +53,7 @@ public:
     // Other dumping.
     void dumpChildFrameScrollPositions() { m_shouldDumpAllFrameScrollPositions = true; }
     void dumpEditingCallbacks() { m_dumpEditingCallbacks = true; }
+    void dumpSelectionRect() { } // Will need to do something when we support pixel tests.
     void dumpStatusCallbacks() { m_dumpStatusCallbacks = true; }
 
     // Special options.