[GTK][WPE] Stop adding volume-box class to volume box element
authorcarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Mar 2020 08:54:57 +0000 (08:54 +0000)
committercarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Mar 2020 08:54:57 +0000 (08:54 +0000)
https://bugs.webkit.org/show_bug.cgi?id=208510

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

The class was removed in r257705 because it's not used by our css.

* Modules/mediacontrols/mediaControlsAdwaita.js:
(Controller.prototype.createControls):

LayoutTests:

Update expectations of http/tests/media/hls/video-controls-live-stream.html.

* platform/gtk/http/tests/media/hls/video-controls-live-stream-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk/http/tests/media/hls/video-controls-live-stream-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js

index badaf87..5657c34 100644 (file)
@@ -1,3 +1,14 @@
+2020-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK][WPE] Stop adding volume-box class to volume box element
+        https://bugs.webkit.org/show_bug.cgi?id=208510
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Update expectations of http/tests/media/hls/video-controls-live-stream.html.
+
+        * platform/gtk/http/tests/media/hls/video-controls-live-stream-expected.txt:
+
 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
 
         REGRESSION(iOS): editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds.html is always timing out
index fb65e90..a87cae5 100644 (file)
@@ -7,10 +7,10 @@ EXPECTED (video.duration == 'Infinity') OK
 -webkit-media-controls-panel: classes: [paused show]
 -webkit-media-controls-play-button: classes: [paused]
 -webkit-media-controls-timeline: classes: []
--webkit-media-controls-current-time-display: classes: [no-duration hour-long-time]
+-webkit-media-controls-current-time-display: classes: []
 none: classes: [mute-box]
 -webkit-media-controls-mute-button: classes: []
--webkit-media-controls-volume-slider-container: classes: [volume-box hiding]
+-webkit-media-controls-volume-slider-container: classes: [hiding]
 -webkit-media-controls-volume-slider: classes: []
 -webkit-media-controls-toggle-closed-captions-button: classes: [hidden]
 -webkit-media-controls-fullscreen-button: classes: []
index 73a88d6..e799bb0 100644 (file)
@@ -1,3 +1,15 @@
+2020-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK][WPE] Stop adding volume-box class to volume box element
+        https://bugs.webkit.org/show_bug.cgi?id=208510
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        The class was removed in r257705 because it's not used by our css.
+
+        * Modules/mediacontrols/mediaControlsAdwaita.js:
+        (Controller.prototype.createControls):
+
 2020-03-03  Devin Rousso  <drousso@apple.com>
 
         Web Inspector: re-add `InspectorFrontendHost` support for moving the inspected window
index 800373b..4b14981 100644 (file)
@@ -268,7 +268,6 @@ Controller.prototype = {
         var volumeBox = this.controls.volumeBox = document.createElement('div');
         volumeBox.setAttribute('pseudo', '-webkit-media-controls-volume-slider-container');
         volumeBox.classList.add(this.ClassNames.hiding);
-        volumeBox.classList.add(this.ClassNames.volumeBox);
         this.listenFor(volumeBox, 'mouseover', this.handleMuteButtonMouseOver);
 
         var volume = this.controls.volume = document.createElement('input');