REGRESSION(r153222, 32-bit): NULL JSValue() seen when running peacekeeper benchmark.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 29 Aug 2013 20:35:32 +0000 (20:35 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 29 Aug 2013 20:35:32 +0000 (20:35 +0000)
https://bugs.webkit.org/show_bug.cgi?id=120080

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-08-29
Reviewed by Michael Saboff.

* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emitSlow_op_get_argument_by_val): Revert changes introduced by r153222 in this function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@154839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/jit/JITOpcodes32_64.cpp

index a8f721d..657ac95 100644 (file)
@@ -1,3 +1,13 @@
+2013-08-29  Julien Brianceau  <jbriance@cisco.com>
+
+        REGRESSION(r153222, 32-bit): NULL JSValue() seen when running peacekeeper benchmark.
+        https://bugs.webkit.org/show_bug.cgi?id=120080
+
+        Reviewed by Michael Saboff.
+
+        * jit/JITOpcodes32_64.cpp:
+        (JSC::JIT::emitSlow_op_get_argument_by_val): Revert changes introduced by r153222 in this function.
+
 2013-08-29  Filip Pizlo  <fpizlo@apple.com>
 
         Kill code that became dead after http://trac.webkit.org/changeset/154833
index 88e143a..9213e6c 100644 (file)
@@ -1262,8 +1262,9 @@ void JIT::emitSlow_op_get_argument_by_val(Instruction* currentInstruction, Vecto
     linkSlowCase(iter);
     linkSlowCase(iter);
 
-    JITSlowPathCall slowPathCall(this, currentInstruction, slow_path_create_arguments);
-    slowPathCall.call();
+    JITStubCall(this, cti_op_create_arguments).call();
+    emitStore(arguments, regT1, regT0);
+    emitStore(unmodifiedArgumentsRegister(arguments), regT1, regT0);
     
     skipArgumentsCreation.link(this);
     JITStubCall stubCall(this, cti_op_get_by_val_generic);