[CSS Parser] Unskip more tests
authorhyatt@apple.com <hyatt@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Dec 2016 16:47:12 +0000 (16:47 +0000)
committerhyatt@apple.com <hyatt@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Dec 2016 16:47:12 +0000 (16:47 +0000)
https://bugs.webkit.org/show_bug.cgi?id=165602

Reviewed by Zalan Bujtas.

* TestExpectations:
* fast/css/remove-shorthand-expected.txt:
* fast/css/transform-inline-style-expected.txt:
* fast/regions/region-styling/parsing-region-style-rule.html:
* fast/shapes/parsing/parsing-shape-image-threshold-expected.txt:
* fast/shapes/parsing/parsing-shape-image-threshold.html:
* fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
* fast/shapes/shape-outside-floats/shape-outside-animation.html:
* platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt:
* svg/webarchive/svg-cursor-subresources.svg:
* transitions/transitions-parsing-expected.txt:
* transitions/transitions-parsing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 files changed:
LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/fast/css/remove-shorthand-expected.txt
LayoutTests/fast/css/transform-inline-style-expected.txt
LayoutTests/fast/regions/region-styling/parsing-region-style-rule.html
LayoutTests/fast/shapes/parsing/parsing-shape-image-threshold-expected.txt
LayoutTests/fast/shapes/parsing/parsing-shape-image-threshold.html
LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt
LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation.html
LayoutTests/platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt
LayoutTests/svg/webarchive/svg-cursor-subresources.svg
LayoutTests/transitions/transitions-parsing-expected.txt
LayoutTests/transitions/transitions-parsing.html

index dee1d53..051efab 100644 (file)
@@ -1,3 +1,23 @@
+2016-12-08  Dave Hyatt  <hyatt@apple.com>
+
+        [CSS Parser] Unskip more tests
+        https://bugs.webkit.org/show_bug.cgi?id=165602
+
+        Reviewed by Zalan Bujtas.
+
+        * TestExpectations:
+        * fast/css/remove-shorthand-expected.txt:
+        * fast/css/transform-inline-style-expected.txt:
+        * fast/regions/region-styling/parsing-region-style-rule.html:
+        * fast/shapes/parsing/parsing-shape-image-threshold-expected.txt:
+        * fast/shapes/parsing/parsing-shape-image-threshold.html:
+        * fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
+        * fast/shapes/shape-outside-floats/shape-outside-animation.html:
+        * platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt:
+        * svg/webarchive/svg-cursor-subresources.svg:
+        * transitions/transitions-parsing-expected.txt:
+        * transitions/transitions-parsing.html:
+
 2016-12-08  Antti Koivisto  <antti@apple.com>
 
         :after and :before don't work on :host
index b23fd88..e8c36f0 100644 (file)
@@ -1008,22 +1008,13 @@ webkit.org/b/165195 fast/css/parsing-css-nth-child.html [ Pass Failure ]
 webkit.org/b/165195 fast/css/parsing-text-emphasis.html [ Pass Failure ]
 webkit.org/b/165195 fast/css/css-selector-text.html [ Pass Failure ]
 webkit.org/b/165195 fast/css/css-set-selector-text.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/remove-shorthand.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/transform-inline-style.html [ Pass Failure ]
 webkit.org/b/165195 fast/css/uri-token-parsing.html [ Pass Failure ]
 webkit.org/b/165195 fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html [ Pass Failure ]
-webkit.org/b/165195 fast/regions/region-styling/parsing-region-style-rule.html [ Pass Failure ]
 webkit.org/b/165195 fast/selectors/querySelector-pseudo-element.html [ Pass Failure ]
 webkit.org/b/165195 fast/selectors/querySelector-pseudo-element-inside-functional-pseudo-class-any.html [ Pass Failure ]
-webkit.org/b/165195 fast/shapes/parsing/parsing-shape-image-threshold.html [ Pass Failure ]
-webkit.org/b/165195 fast/shapes/shape-outside-floats/shape-outside-animation.html [ Pass Failure ]
-webkit.org/b/165195 svg/webarchive/svg-cursor-subresources.svg [ Pass Failure ]
 webkit.org/b/165195 fast/backgrounds/background-shorthand-after-set-backgroundSize.html [ Pass Failure ]
 webkit.org/b/165195 fast/backgrounds/background-position-parsing-2.html [ Pass Failure ]
 webkit.org/b/165195 fast/backgrounds/background-shorthand-with-backgroundSize-style.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/font-family-parse-keyword.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/variables/custom-property-dynamic-update.html [ Skip ]
-webkit.org/b/165195 transitions/transitions-parsing.html [ Pass Failure ]
 webkit.org/b/165195 fast/css/aspect-ratio-parsing-tests.html [ Pass Failure ]
 webkit.org/b/165195 fast/css-grid-layout/grid-auto-flow-get-set.html [ Pass Failure ]
 webkit.org/b/165195 fast/css-grid-layout/grid-columns-rows-get-set.html [ Pass Failure ]
index 3d01dca..cabfdcf 100644 (file)
@@ -72,5 +72,5 @@ Removing padding
 removes "padding"
 and adds "".
 Removing -webkit-text-stroke
-removes "-webkit-text-stroke-color, -webkit-text-stroke-width"
+removes "-webkit-text-stroke-width, -webkit-text-stroke-color"
 and adds "".
index 4e7c4cb..b1b76ba 100644 (file)
@@ -2,5 +2,5 @@ Tests reading inline style of transition, and -webkit-transform-origin
 https://bugs.webkit.org/show_bug.cgi?id=22594
 
 style: all 1s ease, left 3s cubic-bezier(0.2, 0.3, 0.6, 0.8) 2s
-style: 0% 30%
+style: left 30%
 
index af3da30..2eefe5d 100644 (file)
@@ -47,6 +47,7 @@
                 "@-webkit-region #region1 { div { margin-top: 10px; } }",
                 "@-webkit-region #region2 { div { margin-left: 5px; } }",
                 "@-webkit-region #region1 { p { color: red; } }",
+                "@-webkit-region #region1 {}",
                 "@-webkit-region #region1, #region2 { p > p { color: green; } }"
             ];
 
index a124243..429fd02 100644 (file)
@@ -10,7 +10,7 @@ PASS getCSSText("-webkit-shape-image-threshold", "-0.1") is "-0.1"
 PASS getCSSText("-webkit-shape-image-threshold", "1.1") is "1.1"
 PASS getCSSText("-webkit-shape-image-threshold", "identifier") is ""
 PASS getCSSText("-webkit-shape-image-threshold", "'string'") is ""
-PASS getCSSText("-webkit-shape-image-threshold", "calc(0.1 + 0.4)") is "calc(0.5)"
+PASS getCSSText("-webkit-shape-image-threshold", "calc(0.1 + 0.4)") is "0.5"
 PASS getComputedStyleValue("-webkit-shape-image-threshold", "0") is "0"
 PASS getComputedStyleValue("-webkit-shape-image-threshold", "0.5") is "0.5"
 PASS getComputedStyleValue("-webkit-shape-image-threshold", "1") is "1"
index d5dbbfd..ad4207e 100644 (file)
@@ -20,7 +20,7 @@ applyToEachArglist(
      ["-webkit-shape-image-threshold", "1.1", "1.1"],
      ["-webkit-shape-image-threshold", "identifier", ""],
      ["-webkit-shape-image-threshold", "\'string\'", ""],
-     ["-webkit-shape-image-threshold", "calc(0.1 + 0.4)", "calc(0.5)"]
+     ["-webkit-shape-image-threshold", "calc(0.1 + 0.4)", "0.5"]
     ]
 );
 
index 8afe5cf..0640831 100644 (file)
@@ -19,8 +19,8 @@ PASS - "webkitShapeOutside" property for "polygon2-box" element at 1s saw someth
 PASS - "webkitShapeOutside" property for "circle-auto-box" element at 1s saw something close to: circle(50% at 50% 50%)
 PASS - "webkitShapeOutside" property for "circle-to-topleft-box" element at 1s saw something close to: circle(35% at 25% 25%)
 PASS - "webkitShapeOutside" property for "circle-to-topleft-box" element at 1s saw something close to: circle(35% at 25% 25%)
-PASS - "webkitShapeOutside" property for "circle-to-bottomright-using-keyword-box" element at 1s saw something close to: circle(35% at 75% 75%)
-PASS - "webkitShapeOutside" property for "circle-to-bottomright-using-keyword-box" element at 1s saw something close to: circle(35% at 75% 75%)
+PASS - "webkitShapeOutside" property for "circle-to-bottomright-using-keyword-box" element at 1s saw something close to: circle(35% at calc((50% * 0.5) + ((100% - 0px) * 0.5)) calc((50% * 0.5) + ((100% - 0px) * 0.5)))
+PASS - "webkitShapeOutside" property for "circle-to-bottomright-using-keyword-box" element at 1s saw something close to: circle(35% at calc((50% * 0.5) + ((100% - 0px) * 0.5)) calc((50% * 0.5) + ((100% - 0px) * 0.5)))
 PASS - "webkitShapeOutside" property for "circle-to-bottomright-extended-box" element at 1s saw something close to: circle(35% at 75% 75%)
 PASS - "webkitShapeOutside" property for "circle-to-bottomright-extended-using-keyword-box" element at 1s saw something close to: circle(35% at calc((50% * 0.5) + ((100% - 10%) * 0.5)) calc((50% * 0.5) + ((100% - 20px) * 0.5)))
 PASS - "webkitShapeOutside" property for "circle-to-bottomright-extended-using-keyword-2-box" element at 1s saw something close to: circle(35% at calc((50% * 0.5) + ((100% - 10%) * 0.5)) calc((50% * 0.5) + ((100% - 10px) * 0.5)))
index 82e701e..89c24e8 100644 (file)
       ["circle-auto-anim",  1, "circle-auto-box", "webkitShapeOutside", "circle(50% at 50% 50%)", 0.05],
       ["circle-to-topleft-anim",  1, "circle-to-topleft-box", "webkitShapeOutside", "circle(35% at 25% 25%)", 0.05],
       ["circle-to-topleft-anim",  1, "circle-to-topleft-box", "webkitShapeOutside", "circle(35% at 25% 25%)", 0.05],
-      ["circle-to-bottomright-using-keyword-anim",  1, "circle-to-bottomright-using-keyword-box", "webkitShapeOutside", "circle(35% at 75% 75%)", 0.05],
-      ["circle-to-bottomright-using-keyword-anim",  1, "circle-to-bottomright-using-keyword-box", "webkitShapeOutside", "circle(35% at 75% 75%)", 0.05],
+      ["circle-to-bottomright-using-keyword-anim",  1, "circle-to-bottomright-using-keyword-box", "webkitShapeOutside", "circle(35% at calc((50% * 0.5) + ((100% - 0px) * 0.5)) calc((50% * 0.5) + ((100% - 0px) * 0.5)))", 0.05],
+      ["circle-to-bottomright-using-keyword-anim",  1, "circle-to-bottomright-using-keyword-box", "webkitShapeOutside", "circle(35% at calc((50% * 0.5) + ((100% - 0px) * 0.5)) calc((50% * 0.5) + ((100% - 0px) * 0.5)))", 0.05],
       ["circle-to-bottomright-extended-anim",  1, "circle-to-bottomright-extended-box", "webkitShapeOutside", "circle(35% at 75% 75%)", 0.05],
       ["circle-to-bottomright-extended-using-keyword-anim",  1, "circle-to-bottomright-extended-using-keyword-box", "webkitShapeOutside", "circle(35% at calc((50% * 0.5) + ((100% - 10%) * 0.5)) calc((50% * 0.5) + ((100% - 20px) * 0.5)))", 0.01],
       ["circle-to-bottomright-extended-using-keyword-2-anim",  1, "circle-to-bottomright-extended-using-keyword-2-box", "webkitShapeOutside", "circle(35% at calc((50% * 0.5) + ((100% - 10%) * 0.5)) calc((50% * 0.5) + ((100% - 10px) * 0.5)))", 0.01],
index fea9bc5..dcd956e 100644 (file)
@@ -7,7 +7,7 @@
                <key>WebResourceData</key>
                <string>&lt;svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"&gt;
   &lt;cursor id="mycursor" xlink:href="resources/green-checker.png"/&gt;
-  &lt;rect style="cursor: url(#mycursor)" width="100" height="100" fill="white" stroke="blue"/&gt;
+  &lt;rect style="cursor: url(#mycursor), default" width="100" height="100" fill="white" stroke="blue"/&gt;
   
   &lt;text x="10" y="130"&gt;Hover over the rect, you should see a (large) custom cursor&lt;/text&gt;
   &lt;script&gt;
index 80cc4d8..aceb94b 100644 (file)
@@ -1,6 +1,6 @@
 <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
   <cursor id="mycursor" xlink:href="resources/green-checker.png" />
-  <rect style="cursor: url(#mycursor)" width="100" height="100" fill="white" stroke="blue" />
+  <rect style="cursor: url(#mycursor), default" width="100" height="100" fill="white" stroke="blue" />
   
   <text x="10" y="130">Hover over the rect, you should see a (large) custom cursor</text>
   <script>
index a1868e1..57e5371 100644 (file)
@@ -45,17 +45,17 @@ PASS computedStyle.transitionProperty is 'font-size, all, color'
 PASS style.webkitTransitionProperty is 'font-size, all, color'
 PASS computedStyle.webkitTransitionProperty is 'font-size, all, color'
 Invalid transition-property values.
-PASS style.transitionProperty is ''
+PASS style.transitionProperty is 'solid, font-size'
 PASS computedStyle.transitionProperty is 'all'
-PASS style.webkitTransitionProperty is ''
+PASS style.webkitTransitionProperty is 'solid, font-size'
 PASS computedStyle.webkitTransitionProperty is 'all'
-PASS style.transitionProperty is ''
+PASS style.transitionProperty is 'solid, left'
 PASS computedStyle.transitionProperty is 'all'
-PASS style.webkitTransitionProperty is ''
+PASS style.webkitTransitionProperty is 'solid, left'
 PASS computedStyle.webkitTransitionProperty is 'all'
-PASS style.transitionProperty is ''
+PASS style.transitionProperty is 'solid'
 PASS computedStyle.transitionProperty is 'all'
-PASS style.webkitTransitionProperty is ''
+PASS style.webkitTransitionProperty is 'solid'
 PASS computedStyle.webkitTransitionProperty is 'all'
 PASS style.transitionProperty is ''
 PASS computedStyle.transitionProperty is 'all'
@@ -422,9 +422,9 @@ PASS style.transition is ''
 PASS computedStyle.transition is 'all 0s ease 0s'
 PASS style.webkitTransition is ''
 PASS computedStyle.webkitTransition is 'all 0s ease 0s'
-PASS style.transition is ''
+PASS style.transition is 'widthFoo'
 PASS computedStyle.transition is 'all 0s ease 0s'
-PASS style.webkitTransition is ''
+PASS style.webkitTransition is 'widthFoo'
 PASS computedStyle.webkitTransition is 'all 0s ease 0s'
 PASS style.transition is ''
 PASS computedStyle.transition is 'all 0s ease 0s'
index 60f9e70..82fa649 100644 (file)
@@ -89,23 +89,25 @@ debug("Invalid transition-property values.");
 style.transitionProperty = "";
 
 style.transitionProperty = "solid, font-size";
-shouldBe("style.transitionProperty", "''");
+shouldBe("style.transitionProperty", "'solid, font-size'");
 shouldBe("computedStyle.transitionProperty", "'all'");
-shouldBe("style.webkitTransitionProperty", "''");
+shouldBe("style.webkitTransitionProperty", "'solid, font-size'");
 shouldBe("computedStyle.webkitTransitionProperty", "'all'");
 
 style.transitionProperty = "solid, left";
-shouldBe("style.transitionProperty", "''");
+shouldBe("style.transitionProperty", "'solid, left'");
 shouldBe("computedStyle.transitionProperty", "'all'");
-shouldBe("style.webkitTransitionProperty", "''");
+shouldBe("style.webkitTransitionProperty", "'solid, left'");
 shouldBe("computedStyle.webkitTransitionProperty", "'all'");
 
 style.transitionProperty = "solid";
-shouldBe("style.transitionProperty", "''");
+shouldBe("style.transitionProperty", "'solid'");
 shouldBe("computedStyle.transitionProperty", "'all'");
-shouldBe("style.webkitTransitionProperty", "''");
+shouldBe("style.webkitTransitionProperty", "'solid'");
 shouldBe("computedStyle.webkitTransitionProperty", "'all'");
 
+style.transitionProperty = '';
+
 style.transitionProperty = "20px";
 shouldBe("style.transitionProperty", "''");
 shouldBe("computedStyle.transitionProperty", "'all'");
@@ -665,11 +667,13 @@ shouldBe("style.webkitTransition", "''");
 shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
 
 style.transition = "widthFoo";
-shouldBe("style.transition", "''");
+shouldBe("style.transition", "'widthFoo'");
 shouldBe("computedStyle.transition", "'all 0s ease 0s'");
-shouldBe("style.webkitTransition", "''");
+shouldBe("style.webkitTransition", "'widthFoo'");
 shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
 
+style.transition = '';
+
 style.transition = "all 30s width ease-in";
 shouldBe("style.transition", "''");
 shouldBe("computedStyle.transition", "'all 0s ease 0s'");