Stop generating stripped symbols for Release builds
authoraroben@apple.com <aroben@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 12 Jul 2010 19:21:56 +0000 (19:21 +0000)
committeraroben@apple.com <aroben@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 12 Jul 2010 19:21:56 +0000 (19:21 +0000)
It turns out we can strip the symbols after-the-fact using PDBCopy.

Fixes <http://webkit.org/b/42085>.

Reviewed by Steve Falkenburg.

JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
Removed the pre-link event, which just created the public\sym
directory.

WebKit2:

* win/WebKit2.vcproj: Removed the no-longer-needed Release override of
the StripPrivateSymbols attribute. (This attribute is no longer set in
release.vsprops, so doesn't need to be overridden.)

WebKitLibraries:

* win/tools/vsprops/release.vsprops: Removed the StripPrivateSymbols
attribute, which caused link.exe to generate a stripped PDB file for
each project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

JavaScriptCore/ChangeLog
JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops
WebKit2/ChangeLog
WebKit2/win/WebKit2.vcproj
WebKitLibraries/ChangeLog
WebKitLibraries/win/tools/vsprops/release.vsprops

index cbf783e..3be8f77 100644 (file)
@@ -1,3 +1,17 @@
+2010-07-12  Adam Roben  <aroben@apple.com>
+
+        Stop generating stripped symbols for Release builds
+
+        It turns out we can strip the symbols after-the-fact using PDBCopy.
+
+        Fixes <http://webkit.org/b/42085>.
+
+        Reviewed by Steve Falkenburg.
+
+        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
+        Removed the pre-link event, which just created the public\sym
+        directory.
+
 2010-07-12  Anders Carlsson  <andersca@apple.com>
 
         Reviewed by Dan Bernstein.
index e940511..ad81c36 100644 (file)
@@ -23,8 +23,4 @@
                Name="VCPreBuildEventTool"
                CommandLine="%SystemDrive%\cygwin\bin\which.exe bash&#x0D;&#x0A;if errorlevel 1 set PATH=%SystemDrive%\cygwin\bin;%PATH%&#x0D;&#x0A;cmd /c&#x0D;&#x0A;if exist &quot;$(WebKitOutputDir)\buildfailed&quot; grep XX$(ProjectName)XX &quot;$(WebKitOutputDir)\buildfailed&quot;&#x0D;&#x0A;if errorlevel 1 exit 1&#x0D;&#x0A;echo XX$(ProjectName)XX &gt; &quot;$(WebKitOutputDir)\buildfailed&quot;&#x0D;&#x0A;&#x0D;&#x0A;bash &quot;$(WebKitLibrariesDir)\tools\scripts\auto-version.sh&quot; &quot;$(IntDir)&quot;&#x0D;&#x0A;"
        />
-       <Tool
-               Name="VCPreLinkEventTool"
-               CommandLine="if not exist &quot;$(WebKitOutputDir)\public\sym&quot; mkdir &quot;$(WebKitOutputDir)\public\sym&quot;"
-       />
 </VisualStudioPropertySheet>
index 138966f..4a34753 100644 (file)
@@ -1,3 +1,17 @@
+2010-07-12  Adam Roben  <aroben@apple.com>
+
+        Stop generating stripped symbols for Release builds
+
+        It turns out we can strip the symbols after-the-fact using PDBCopy.
+
+        Fixes <http://webkit.org/b/42085>.
+
+        Reviewed by Steve Falkenburg.
+
+        * win/WebKit2.vcproj: Removed the no-longer-needed Release override of
+        the StripPrivateSymbols attribute. (This attribute is no longer set in
+        release.vsprops, so doesn't need to be overridden.)
+
 2010-07-12  Brian Weinstein  <bweinstein@apple.com>
 
         WebKit2 build fix for Windows.
index e4adb5f..752f369 100755 (executable)
                                OutputFile="$(OutDir)\$(ProjectName)$(WebKitDLLConfigSuffix).dll"\r
                                AdditionalLibraryDirectories="$(DXSDK_DIR)\Lib\x86"\r
                                DelayLoadDLLs="usp10.dll;comctl32.dll;version.dll;libxslt$(LibraryConfigSuffix).dll;SQLite3$(LibraryConfigSuffix).dll;msimg32.dll;QTMovieWin$(WebKitConfigSuffix).dll;iphlpapi.dll"\r
-                               StripPrivateSymbols=""\r
                        />\r
                        <Tool\r
                                Name="VCALinkTool"\r
index c912775..bc2150b 100644 (file)
@@ -1,3 +1,17 @@
+2010-07-12  Adam Roben  <aroben@apple.com>
+
+        Stop generating stripped symbols for Release builds
+
+        It turns out we can strip the symbols after-the-fact using PDBCopy.
+
+        Fixes <http://webkit.org/b/42085>.
+
+        Reviewed by Steve Falkenburg.
+
+        * win/tools/vsprops/release.vsprops: Removed the StripPrivateSymbols
+        attribute, which caused link.exe to generate a stripped PDB file for
+        each project.
+
 2010-07-08  Eric Carlson  <eric.carlson@apple.com>
 
         Reviewed by Dan Bernstein.
index 109176d..8b38b73 100644 (file)
@@ -13,7 +13,6 @@
        <Tool
                Name="VCLinkerTool"
                LinkIncremental="1"
-               StripPrivateSymbols="$(WebKitOutputDir)\public\sym\$(TargetName).pdb"
                OptimizeReferences="2"
                EnableCOMDATFolding="2"
                OptimizeForWindows98="1"