Fix resourcetimingbufferfull bubbles attribute
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 2 Jan 2019 23:41:56 +0000 (23:41 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 2 Jan 2019 23:41:56 +0000 (23:41 +0000)
https://bugs.webkit.org/show_bug.cgi?id=193087

Patch by Charles Vazac <cvazac@gmail.com> on 2019-01-02
Reviewed by Chris Dumez.

Source/WebCore:

This change is covered by web-platform-tests [1].

[1] https://github.com/web-platform-tests/wpt/blob/master/resource-timing/buffer-full-when-populate-entries.html#L20

* page/Performance.cpp:
(WebCore::Performance::resourceTimingBufferFullTimerFired):

LayoutTests:

* http/wpt/resource-timing/rt-performance-extensions.js:
(promise_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/http/wpt/resource-timing/rt-performance-extensions.js
Source/WebCore/ChangeLog
Source/WebCore/page/Performance.cpp

index 1f36ebf..c2882eb 100644 (file)
@@ -1,3 +1,13 @@
+2019-01-02  Charles Vazac  <cvazac@gmail.com>
+
+        Fix resourcetimingbufferfull bubbles attribute
+        https://bugs.webkit.org/show_bug.cgi?id=193087
+
+        Reviewed by Chris Dumez.
+
+        * http/wpt/resource-timing/rt-performance-extensions.js:
+        (promise_test):
+
 2019-01-02  Simon Fraser  <simon.fraser@apple.com>
 
         Support css-color-4 rgb functions
index 0ba50aa..9fa40a1 100644 (file)
@@ -102,7 +102,7 @@ promise_test(function(t) {
         assert_equals(entries.length, 2, "context should have observed 1 resource");
         assert_equals(performance.getEntriesByType("resource").length, 1, "context global buffer should be full at 1 resource");
         assert_equals(bufferFullEvent.target, performance, "event should dispatch at the performance object");
-        assert_true(bufferFullEvent.bubbles, "event should bubble");
+        assert_false(bufferFullEvent.bubbles, "event should not bubble");
     });
 }, "resourcetimingbufferfull event properties", {timeout: 3000});
 
index 081d6d7..510b23b 100644 (file)
@@ -1,3 +1,17 @@
+2019-01-02  Charles Vazac  <cvazac@gmail.com>
+
+        Fix resourcetimingbufferfull bubbles attribute
+        https://bugs.webkit.org/show_bug.cgi?id=193087
+
+        Reviewed by Chris Dumez.
+
+        This change is covered by web-platform-tests [1].
+
+        [1] https://github.com/web-platform-tests/wpt/blob/master/resource-timing/buffer-full-when-populate-entries.html#L20
+
+        * page/Performance.cpp:
+        (WebCore::Performance::resourceTimingBufferFullTimerFired):
+
 2019-01-02  Simon Fraser  <simon.fraser@apple.com>
 
         Rename LayerScrollCoordinationRole to ScrollCoordinationRole and make an enum class
index 80e9dae..d51b26d 100644 (file)
@@ -216,7 +216,7 @@ void Performance::resourceTimingBufferFullTimerFired()
         ASSERT(m_backupResourceTimingBuffer.isEmpty());
 
         m_resourceTimingBufferFullFlag = true;
-        dispatchEvent(Event::create(eventNames().resourcetimingbufferfullEvent, Event::CanBubble::Yes, Event::IsCancelable::No));
+        dispatchEvent(Event::create(eventNames().resourcetimingbufferfullEvent, Event::CanBubble::No, Event::IsCancelable::No));
 
         if (m_resourceTimingBufferFullFlag) {
             for (auto& entry : backupBuffer)