2011-01-19 Andrey Kosyakov <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] delete pending callback from callback map before invoking it
        https://bugs.webkit.org/show_bug.cgi?id=52707

        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI.ExtensionServerClient.prototype._onCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index cd1b927..7dfe09b 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,13 @@
+2011-01-19  Andrey Kosyakov  <caseq@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: [Extensions API] delete pending callback from callback map before invoking it
+        https://bugs.webkit.org/show_bug.cgi?id=52707
+
+        * inspector/front-end/ExtensionAPI.js:
+        (WebInspector.injectedExtensionAPI.ExtensionServerClient.prototype._onCallback):
+

 2011-01-19  Levi Weintraub  <leviw@google.com>
 
         Reviewed by Ryosuke Niwa.
 2011-01-19  Levi Weintraub  <leviw@google.com>
 
         Reviewed by Ryosuke Niwa.

diff --git a/Source/WebCore/inspector/front-end/ExtensionAPI.js b/Source/WebCore/inspector/front-end/ExtensionAPI.js
index a9a2423..b10452d 100644 (file)
--- a/Source/WebCore/inspector/front-end/ExtensionAPI.js
+++ b/Source/WebCore/inspector/front-end/ExtensionAPI.js
@@ -450,8 +450,9 @@ ExtensionServerClient.prototype = {
     _onCallback: function(request)
     {
         if (request.requestId in this._callbacks) {
     _onCallback: function(request)
     {
         if (request.requestId in this._callbacks) {

-            this._callbacks[request.requestId](request.result);
+            var callback = this._callbacks[request.requestId];

             delete this._callbacks[request.requestId];
             delete this._callbacks[request.requestId];

+            callback(request.result);

         }
     },
 
         }
     },