Unreviewed, rolling out r236524.
authorachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 26 Sep 2018 23:35:14 +0000 (23:35 +0000)
committerachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 26 Sep 2018 23:35:14 +0000 (23:35 +0000)
Broke API tests

Reverted changeset:

"URLWithUserTypedString should return nil for URLs deemed to
be invalid by WebCore::URL"
https://bugs.webkit.org/show_bug.cgi?id=189979
https://trac.webkit.org/changeset/236524

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/imported/w3c/ChangeLog
Source/WebCore/ChangeLog
Source/WebCore/platform/mac/WebCoreNSURLExtras.mm
Tools/ChangeLog
Tools/TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm

index b045c1d..1f000e4 100644 (file)
@@ -1,3 +1,16 @@
+2018-09-26  Alex Christensen  <achristensen@webkit.org>
+
+        Unreviewed, rolling out r236524.
+
+        Broke API tests
+
+        Reverted changeset:
+
+        "URLWithUserTypedString should return nil for URLs deemed to
+        be invalid by WebCore::URL"
+        https://bugs.webkit.org/show_bug.cgi?id=189979
+        https://trac.webkit.org/changeset/236524
+
 2018-09-26  Per Arne Vollan  <pvollan@apple.com>
 
         WebVTT cue alignment broken
index 8ced87c..271f640 100644 (file)
@@ -1,3 +1,16 @@
+2018-09-26  Alex Christensen  <achristensen@webkit.org>
+
+        Unreviewed, rolling out r236524.
+
+        Broke API tests
+
+        Reverted changeset:
+
+        "URLWithUserTypedString should return nil for URLs deemed to
+        be invalid by WebCore::URL"
+        https://bugs.webkit.org/show_bug.cgi?id=189979
+        https://trac.webkit.org/changeset/236524
+
 2018-09-26  Chris Dumez  <cdumez@apple.com>
 
         Ignore-opens-during-unload counter of a parent should apply to its children during beforeunload event
index 5dca5b5..e319902 100644 (file)
@@ -1,3 +1,16 @@
+2018-09-26  Alex Christensen  <achristensen@webkit.org>
+
+        Unreviewed, rolling out r236524.
+
+        Broke API tests
+
+        Reverted changeset:
+
+        "URLWithUserTypedString should return nil for URLs deemed to
+        be invalid by WebCore::URL"
+        https://bugs.webkit.org/show_bug.cgi?id=189979
+        https://trac.webkit.org/changeset/236524
+
 2018-09-26  Per Arne Vollan  <pvollan@apple.com>
 
         WebVTT cue alignment broken
index 1e82b91..e45fdaa 100644 (file)
@@ -853,9 +853,6 @@ NSURL *URLWithData(NSData *data, NSURL *baseURL)
     } else
         result = [NSURL URLWithString:@""];
 
-    if (!WebCore::URL(result).isValid())
-        return nil;
-    
     return result;
 }
 static NSData *dataWithUserTypedString(NSString *string)
index 841bd3f..473cef4 100644 (file)
@@ -1,3 +1,16 @@
+2018-09-26  Alex Christensen  <achristensen@webkit.org>
+
+        Unreviewed, rolling out r236524.
+
+        Broke API tests
+
+        Reverted changeset:
+
+        "URLWithUserTypedString should return nil for URLs deemed to
+        be invalid by WebCore::URL"
+        https://bugs.webkit.org/show_bug.cgi?id=189979
+        https://trac.webkit.org/changeset/236524
+
 2018-09-26  James Savage  <james.savage@apple.com>
 
         Allow override of viewport configuration.
index 699acbb..6ffd7da 100644 (file)
@@ -192,8 +192,6 @@ TEST(WebCore, URLExtras_ParsingError)
 
     NSString *encodedHostName = WebCore::encodeHostName(@"http://.com");
     EXPECT_TRUE(encodedHostName == nil);
-    
-    EXPECT_TRUE(WebCore::URLWithUserTypedString(@"https://a@/b", nil) == nil);
 }
 
 TEST(WebCore, URLExtras_Nil)