Web Inspector: Audit: unable to import audits
authordrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 26 Jan 2019 03:24:03 +0000 (03:24 +0000)
committerdrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 26 Jan 2019 03:24:03 +0000 (03:24 +0000)
https://bugs.webkit.org/show_bug.cgi?id=193861

Reviewed by Joseph Pecoraro.

* UserInterface/Controllers/AuditManager.js:
(WI.AuditManager.prototype.async processJSON):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js

index ffe7c47..0b3f63c 100644 (file)
@@ -1,5 +1,15 @@
 2019-01-25  Devin Rousso  <drousso@apple.com>
 
+        Web Inspector: Audit: unable to import audits
+        https://bugs.webkit.org/show_bug.cgi?id=193861
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Controllers/AuditManager.js:
+        (WI.AuditManager.prototype.async processJSON):
+
+2019-01-25  Devin Rousso  <drousso@apple.com>
+
         Web Inspector: Uncaught Exception: No node with given id found
         https://bugs.webkit.org/show_bug.cgi?id=193833
 
index 45a789d..815212d 100644 (file)
@@ -198,8 +198,8 @@ WI.AuditManager = class AuditManager extends WI.Object
             return;
         }
 
-        if (json.type !== WI.AuditTestCase.TypeIdentifier || json.type !== WI.AuditTestGroup.TypeIdentifier
-            || json.type !== WI.AuditTestCaseResult.TypeIdentifier || json.type !== WI.AuditTestGroupResult.TypeIdentifier) {
+        if (json.type !== WI.AuditTestCase.TypeIdentifier && json.type !== WI.AuditTestGroup.TypeIdentifier
+            && json.type !== WI.AuditTestCaseResult.TypeIdentifier && json.type !== WI.AuditTestGroupResult.TypeIdentifier) {
             WI.AuditManager.synthesizeError(WI.UIString("unknown %s \u0022%s\u0022").format(WI.unlocalizedString("type"), json.type));
             return;
         }