REGRESSION (r217078): window.ApplePaySession is undefined on macOS Sierra
authoraestes@apple.com <aestes@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 19 May 2017 16:16:52 +0000 (16:16 +0000)
committeraestes@apple.com <aestes@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 19 May 2017 16:16:52 +0000 (16:16 +0000)
https://bugs.webkit.org/show_bug.cgi?id=172344

Reviewed by Tim Horton.

Source/WebCore:

r213673 mistakenly changed the ApplePaySession interface from being conditional on
APPLE_PAY to being conditional on APPLE_PAY_DELEGATE, so when r217078 disabled
APPLE_PAY_DELEGATE on Sierra and earlier it disabled ApplePaySession.

Fix this by reverting ApplePaySession to being conditional on APPLE_PAY.

Fixes http/tests/ssl/applepay/ApplePaySession.html

* Modules/applepay/ApplePaySession.idl:

LayoutTests:

* TestExpectations: Removed http/tests/ssl/applepay/ApplePaySession.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@217129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/Modules/applepay/ApplePaySession.idl

index b9b132a..bc9897d 100644 (file)
@@ -1,3 +1,12 @@
+2017-05-19  Andy Estes  <aestes@apple.com>
+
+        REGRESSION (r217078): window.ApplePaySession is undefined on macOS Sierra
+        https://bugs.webkit.org/show_bug.cgi?id=172344
+
+        Reviewed by Tim Horton.
+
+        * TestExpectations: Removed http/tests/ssl/applepay/ApplePaySession.html
+
 2017-05-19  Chris Dumez  <cdumez@apple.com>
 
         CSSOM insertRule() index argument is optional with default 0
index c2f3111..a76822c 100644 (file)
@@ -1298,5 +1298,3 @@ webkit.org/b/171031 imported/w3c/web-platform-tests/XMLHttpRequest/getallrespons
 webkit.org/b/170701 webrtc/datachannel/bufferedAmountLowThreshold.html [ Pass Failure ]
 
 webkit.org/b/170835 fast/mediacapturefromelement/CanvasCaptureMediaStream-2d-events.html [ Pass Failure ]
-
-webkit.org/b/172344 http/tests/ssl/applepay/ApplePaySession.html [ Failure ]
index c0f6cc3..d872e71 100644 (file)
@@ -1,3 +1,20 @@
+2017-05-19  Andy Estes  <aestes@apple.com>
+
+        REGRESSION (r217078): window.ApplePaySession is undefined on macOS Sierra
+        https://bugs.webkit.org/show_bug.cgi?id=172344
+
+        Reviewed by Tim Horton.
+
+        r213673 mistakenly changed the ApplePaySession interface from being conditional on
+        APPLE_PAY to being conditional on APPLE_PAY_DELEGATE, so when r217078 disabled
+        APPLE_PAY_DELEGATE on Sierra and earlier it disabled ApplePaySession.
+
+        Fix this by reverting ApplePaySession to being conditional on APPLE_PAY.
+
+        Fixes http/tests/ssl/applepay/ApplePaySession.html
+
+        * Modules/applepay/ApplePaySession.idl:
+
 2017-05-19  Chris Dumez  <cdumez@apple.com>
 
         CSSOM insertRule() index argument is optional with default 0
index 6612c2c..13fb5a9 100644 (file)
@@ -25,7 +25,7 @@
 
 [
     ActiveDOMObject,
-    Conditional=APPLE_PAY_DELEGATE,
+    Conditional=APPLE_PAY,
     Constructor(unsigned long version, ApplePayPaymentRequest paymentRequest),
     ConstructorCallWith=Document,
     ConstructorMayThrowException,