The unused ScrollView* argument can and should be removed from
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 30 Aug 2011 16:10:11 +0000 (16:10 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 30 Aug 2011 16:10:11 +0000 (16:10 +0000)
scrollRectIntoView.
https://bugs.webkit.org/show_bug.cgi?id=67117

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-08-30
Reviewed by Darin Adler.

Source/WebCore:

* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::scrollRectIntoView):
* page/Chrome.cpp:
(WebCore::Chrome::scrollRectIntoView):
* page/ChromeClient.h:
(WebCore::ChromeClient::scrollRectIntoView):

Source/WebKit/chromium:

* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::scrollRectIntoView):
* src/WebPopupMenuImpl.h:

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.h:
(WebCore::ChromeClientEfl::scrollRectIntoView):

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.h:
(WebKit::ChromeClient::scrollRectIntoView):

Source/WebKit/haiku:

* WebCoreSupport/ChromeClientHaiku.cpp:
(WebCore::ChromeClientHaiku::scrollRectIntoView):

Source/WebKit/mac:

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::scrollRectIntoView):

Source/WebKit/qt:

* WebCoreSupport/ChromeClientQt.h:
(WebCore::ChromeClientQt::scrollRectIntoView):

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::scrollRectIntoView):

Source/WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

* WebKitSupport/ChromeClientWx.h:
(WebCore::ChromeClientWx::scrollRectIntoView):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::scrollRectIntoView):
* WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

27 files changed:
Source/WebCore/ChangeLog
Source/WebCore/loader/EmptyClients.h
Source/WebCore/page/Chrome.cpp
Source/WebCore/page/ChromeClient.h
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/src/WebPopupMenuImpl.cpp
Source/WebKit/chromium/src/WebPopupMenuImpl.h
Source/WebKit/efl/ChangeLog
Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h
Source/WebKit/gtk/ChangeLog
Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h
Source/WebKit/haiku/ChangeLog
Source/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/WebCoreSupport/WebChromeClient.h
Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm
Source/WebKit/qt/ChangeLog
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.h
Source/WebKit/win/ChangeLog
Source/WebKit/win/WebCoreSupport/WebChromeClient.h
Source/WebKit/wince/ChangeLog
Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h
Source/WebKit/wx/ChangeLog
Source/WebKit/wx/WebKitSupport/ChromeClientWx.h
Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h

index 32209d0..ab562a4 100644 (file)
@@ -1,3 +1,18 @@
+2011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
+
+        The unused ScrollView* argument can and should be removed from
+        scrollRectIntoView.
+        https://bugs.webkit.org/show_bug.cgi?id=67117
+
+        Reviewed by Darin Adler.
+
+        * loader/EmptyClients.h:
+        (WebCore::EmptyChromeClient::scrollRectIntoView):
+        * page/Chrome.cpp:
+        (WebCore::Chrome::scrollRectIntoView):
+        * page/ChromeClient.h:
+        (WebCore::ChromeClient::scrollRectIntoView):
+
 2011-08-30  Ben Wells  <benwells@chromium.org>
 
         Update registerProtocolHandler scheme whitelist to match spec
index 6ef2092..9365b8e 100644 (file)
@@ -214,7 +214,7 @@ public:
     virtual void setCursor(const Cursor&) { }
     virtual void setCursorHiddenUntilMouseMoves(bool) { }
 
-    virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const {}
+    virtual void scrollRectIntoView(const IntRect&) const { }
 
     virtual void requestGeolocationPermissionForFrame(Frame*, Geolocation*) {}
     virtual void cancelGeolocationPermissionRequestForFrame(Frame*, Geolocation*) {}
index 1b7ad29..5c4a40d 100644 (file)
@@ -127,8 +127,7 @@ void Chrome::layoutUpdated(Frame* frame) const
 
 void Chrome::scrollRectIntoView(const IntRect& rect) const
 {
-    // FIXME: The unused ScrollView* argument can and should be removed from ChromeClient::scrollRectIntoView.
-    m_client->scrollRectIntoView(rect, 0);
+    m_client->scrollRectIntoView(rect);
 }
 
 void Chrome::scrollbarsModeDidChange() const
index e36cf82..7827c5f 100644 (file)
@@ -168,7 +168,7 @@ namespace WebCore {
 
         virtual void contentsSizeChanged(Frame*, const IntSize&) const = 0;
         virtual void layoutUpdated(Frame*) const { }
-        virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const = 0; // Currently only Mac has a non empty implementation.
+        virtual void scrollRectIntoView(const IntRect&) { }; // Currently only Mac has a non empty implementation.
        
         virtual bool shouldMissingPluginMessageBeButton() const { return false; }
         virtual void missingPluginButtonClicked(Element*) const { }
index c77e459..2a2bf0b 100644 (file)
@@ -1,3 +1,15 @@
+2011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
+
+        The unused ScrollView* argument can and should be removed from
+        scrollRectIntoView.
+        https://bugs.webkit.org/show_bug.cgi?id=67117
+
+        Reviewed by Darin Adler.
+
+        * src/WebPopupMenuImpl.cpp:
+        (WebKit::WebPopupMenuImpl::scrollRectIntoView):
+        * src/WebPopupMenuImpl.h:
+
 2011-08-29  Greg Billock  <gbillock@google.com>
 
         [Chromium] Add ability to do static SerializedScriptValue deserialization
index 675c43a..2cff6a6 100644 (file)
@@ -397,7 +397,7 @@ IntRect WebPopupMenuImpl::windowToScreen(const IntRect& rect) const
     return IntRect();
 }
 
-void WebPopupMenuImpl::scrollRectIntoView(const IntRect&, const ScrollView*) const
+void WebPopupMenuImpl::scrollRectIntoView(const IntRect&) const
 {
     // Nothing to be done here since we do not have the concept of a container
     // that implements its own scrolling.
index e449653..b331e7d 100644 (file)
@@ -128,7 +128,7 @@ public:
     virtual WebCore::IntPoint screenToWindow(const WebCore::IntPoint&) const;
     virtual WebCore::IntRect windowToScreen(const WebCore::IntRect&) const;
     virtual PlatformPageClient platformPageClient() const { return 0; }
-    virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const;
+    virtual void scrollRectIntoView(const WebCore::IntRect&) const;
     virtual void scrollbarsModeDidChange() const;
     virtual void setCursor(const WebCore::Cursor&);
     virtual void setCursorHiddenUntilMouseMoves(bool);
index 6f32212..8b9100d 100755 (executable)
@@ -1,3 +1,14 @@
+2011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
+
+        The unused ScrollView* argument can and should be removed from
+        scrollRectIntoView.
+        https://bugs.webkit.org/show_bug.cgi?id=67117
+
+        Reviewed by Darin Adler.
+
+        * WebCoreSupport/ChromeClientEfl.h:
+        (WebCore::ChromeClientEfl::scrollRectIntoView):
+
 2011-08-30  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
 
         [EFL] Add const modifier to passed objects where it's recommended
index 8257d0a..6d05119 100644 (file)
@@ -147,7 +147,7 @@ public:
     virtual void setCursor(const Cursor&);
     virtual void setCursorHiddenUntilMouseMoves(bool);
 
-    virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const { }
+    virtual void scrollRectIntoView(const IntRect&) const { }
 
     virtual void requestGeolocationPermissionForFrame(Frame*, Geolocation*);
     virtual void cancelGeolocationPermissionRequestForFrame(Frame*, Geolocation*);
index 8e7adf1..d6f5326 100644 (file)
@@ -1,3 +1,14 @@
+2011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
+
+        The unused ScrollView* argument can and should be removed from
+        scrollRectIntoView.
+        https://bugs.webkit.org/show_bug.cgi?id=67117
+
+        Reviewed by Darin Adler.
+
+        * WebCoreSupport/ChromeClientGtk.h:
+        (WebKit::ChromeClient::scrollRectIntoView):
+
 2011-08-26  Gustavo Noronha Silva  <gns@gnome.org>
 
         Minor style fix in the sample code for WebKitWebFrame.
index ef4982a..698cdeb 100644 (file)
@@ -133,7 +133,7 @@ namespace WebKit {
         virtual void setCursor(const WebCore::Cursor&);
         virtual void setCursorHiddenUntilMouseMoves(bool);
 
-        virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const {}
+        virtual void scrollRectIntoView(const WebCore::IntRect&) const { }
         virtual void requestGeolocationPermissionForFrame(WebCore::Frame*, WebCore::Geolocation*);
         virtual void cancelGeolocationPermissionRequestForFrame(WebCore::Frame*, WebCore::Geolocation*);
 
index b2d6ec3..3e269c6 100644 (file)
@@ -1,3 +1,14 @@
+2011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
+
+        The unused ScrollView* argument can and should be removed from
+        scrollRectIntoView.
+        https://bugs.webkit.org/show_bug.cgi?id=67117
+
+        Reviewed by Darin Adler.
+
+        * WebCoreSupport/ChromeClientHaiku.cpp:
+        (WebCore::ChromeClientHaiku::scrollRectIntoView):
+
 2011-08-17  Adam Roben  <aroben@apple.com>
 
         Make WebCore keep track of the current device scale factor
index 88136b9..a0138bf 100644 (file)
@@ -301,7 +301,7 @@ void ChromeClientHaiku::contentsSizeChanged(Frame*, const IntSize&) const
     notImplemented();
 }
 
-void ChromeClientHaiku::scrollRectIntoView(const IntRect&, const ScrollView*) const
+void ChromeClientHaiku::scrollRectIntoView(const IntRect&) const
 {
     notImplemented();
 }
index 7a23f5e..5e4f6b5 100644 (file)
@@ -1,3 +1,15 @@
+2011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
+
+        The unused ScrollView* argument can and should be removed from
+        scrollRectIntoView.
+        https://bugs.webkit.org/show_bug.cgi?id=67117
+
+        Reviewed by Darin Adler.
+
+        * WebCoreSupport/WebChromeClient.h:
+        * WebCoreSupport/WebChromeClient.mm:
+        (WebChromeClient::scrollRectIntoView):
+
 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
 
         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
index 36f7303..dc47e87 100644 (file)
@@ -97,7 +97,7 @@ public:
     virtual WebCore::IntRect windowToScreen(const WebCore::IntRect&) const;
     virtual PlatformPageClient platformPageClient() const;
     virtual void contentsSizeChanged(WebCore::Frame*, const WebCore::IntSize&) const;
-    virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const;
+    virtual void scrollRectIntoView(const WebCore::IntRect&) const;
     
     virtual void setStatusbarText(const WTF::String&);
 
index d2cecbe..96d657e 100644 (file)
@@ -608,7 +608,7 @@ void WebChromeClient::contentsSizeChanged(Frame*, const IntSize&) const
 {
 }
 
-void WebChromeClient::scrollRectIntoView(const IntRect& r, const ScrollView*) const
+void WebChromeClient::scrollRectIntoView(const IntRect& r) const
 {
     // FIXME: This scrolling behavior should be under the control of the embedding client,
     // perhaps in a delegate method, rather than something WebKit does unconditionally.
index 8c4c9b7..a4979bb 100644 (file)
@@ -1,3 +1,14 @@
+2011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
+
+        The unused ScrollView* argument can and should be removed from
+        scrollRectIntoView.
+        https://bugs.webkit.org/show_bug.cgi?id=67117
+
+        Reviewed by Darin Adler.
+
+        * WebCoreSupport/ChromeClientQt.h:
+        (WebCore::ChromeClientQt::scrollRectIntoView):
+
 2011-08-25  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
 
         Unreviewed QtWebKit.pro fix for when building inside Qt
index 2bad806..66a5912 100644 (file)
@@ -180,7 +180,7 @@ public:
     virtual void setCursor(const Cursor&);
     virtual void setCursorHiddenUntilMouseMoves(bool) { }
 
-    virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const { }
+    virtual void scrollRectIntoView(const IntRect&) const { }
 
     virtual void requestGeolocationPermissionForFrame(Frame*, Geolocation*) { }
     virtual void cancelGeolocationPermissionRequestForFrame(Frame*, Geolocation*) { }
index 10ddcb1..c194926 100644 (file)
@@ -1,3 +1,14 @@
+2011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
+
+        The unused ScrollView* argument can and should be removed from
+        scrollRectIntoView.
+        https://bugs.webkit.org/show_bug.cgi?id=67117
+
+        Reviewed by Darin Adler.
+
+        * WebCoreSupport/WebChromeClient.h:
+        (WebChromeClient::scrollRectIntoView):
+
 2011-08-29  Ryosuke Niwa  <rniwa@webkit.org>
 
         Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
index ae997b8..97e7ba1 100644 (file)
@@ -153,7 +153,7 @@ public:
         virtual void scheduleCompositingLayerSync();
 #endif
 
-    virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const {}
+    virtual void scrollRectIntoView(const WebCore::IntRect&) const { }
 
     // FIXME: Remove once all ports are using client-based geolocation. https://bugs.webkit.org/show_bug.cgi?id=40373
     // For client-based geolocation, these two methods have been moved to WebGeolocationClient. https://bugs.webkit.org/show_bug.cgi?id=50061
index a3e3667..295cdef 100644 (file)
@@ -1,3 +1,13 @@
+2011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
+
+        The unused ScrollView* argument can and should be removed from
+        scrollRectIntoView.
+        https://bugs.webkit.org/show_bug.cgi?id=67117
+
+        Reviewed by Darin Adler.
+
+        * WebCoreSupport/ChromeClientWinCE.h:
+
 2011-08-17  Adam Roben  <aroben@apple.com>
 
         Make WebCore keep track of the current device scale factor
index 06c578e..5c98d8f 100644 (file)
@@ -101,7 +101,7 @@ public:
     virtual WebCore::IntRect windowToScreen(const WebCore::IntRect&) const;
     virtual PlatformPageClient platformPageClient() const;
     virtual void contentsSizeChanged(WebCore::Frame*, const WebCore::IntSize&) const;
-    virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const; // Currently only Mac has a non empty implementation.
+    virtual void scrollRectIntoView(const WebCore::IntRect&) const; // Currently only Mac has a non empty implementation.
     virtual void scrollbarsModeDidChange() const;
     virtual void setCursor(const WebCore::Cursor&);
     virtual void setCursorHiddenUntilMouseMoves(bool);
index 1e82e80..536037f 100644 (file)
@@ -1,3 +1,14 @@
+2011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
+
+        The unused ScrollView* argument can and should be removed from
+        scrollRectIntoView.
+        https://bugs.webkit.org/show_bug.cgi?id=67117
+
+        Reviewed by Darin Adler.
+
+        * WebKitSupport/ChromeClientWx.h:
+        (WebCore::ChromeClientWx::scrollRectIntoView):
+
 2011-08-17  Adam Roben  <aroben@apple.com>
 
         Make WebCore keep track of the current device scale factor
index 793ee4a..dd8a964 100644 (file)
@@ -141,7 +141,7 @@ public:
     virtual void setCursor(const Cursor&);
     virtual void setCursorHiddenUntilMouseMoves(bool) { }
 
-    virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const {}
+    virtual void scrollRectIntoView(const IntRect&) const { }
 
     virtual void requestGeolocationPermissionForFrame(Frame*, Geolocation*);
     virtual void cancelGeolocationPermissionRequestForFrame(Frame*, Geolocation*) { }
index 29e955e..238c035 100644 (file)
@@ -1,3 +1,15 @@
+2011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
+
+        The unused ScrollView* argument can and should be removed from
+        scrollRectIntoView.
+        https://bugs.webkit.org/show_bug.cgi?id=67117
+
+        Reviewed by Darin Adler.
+
+        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+        (WebKit::WebChromeClient::scrollRectIntoView):
+        * WebProcess/WebCoreSupport/WebChromeClient.h:
+
 2011-08-29  Ryosuke Niwa  <rniwa@webkit.org>
 
         Another Windows build fix after r94047.
index 6b0fa82..9632c80 100644 (file)
@@ -463,7 +463,7 @@ void WebChromeClient::contentsSizeChanged(Frame* frame, const IntSize& size) con
     }
 }
 
-void WebChromeClient::scrollRectIntoView(const IntRect&, const ScrollView*) const
+void WebChromeClient::scrollRectIntoView(const IntRect&) const
 {
     notImplemented();
 }
index 216f9f1..8601666 100644 (file)
@@ -119,7 +119,7 @@ private:
     virtual WebCore::IntRect windowToScreen(const WebCore::IntRect&) const;
     virtual PlatformPageClient platformPageClient() const;
     virtual void contentsSizeChanged(WebCore::Frame*, const WebCore::IntSize&) const;
-    virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const; // Currently only Mac has a non empty implementation.
+    virtual void scrollRectIntoView(const WebCore::IntRect&) const; // Currently only Mac has a non empty implementation.
     // End methods used by HostWindow.
 
     virtual bool shouldMissingPluginMessageBeButton() const;