[SOUP] Network process assertion in NetworkDataTask::continueHTTPRedirection
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 25 Oct 2016 23:42:43 +0000 (23:42 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 25 Oct 2016 23:42:43 +0000 (23:42 +0000)
https://bugs.webkit.org/show_bug.cgi?id=163941

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2016-10-25
Reviewed by Michael Catanzaro.

equalLettersIgnoringASCIICase() expects the second argument to be the letters to compare in lowercase, so use
"get" instead of "GET".

* NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::continueHTTPRedirection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@207856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/NetworkProcess/soup/NetworkDataTaskSoup.cpp

index ef7d112..2582f75 100644 (file)
@@ -1,3 +1,16 @@
+2016-10-25  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [SOUP] Network process assertion in NetworkDataTask::continueHTTPRedirection
+        https://bugs.webkit.org/show_bug.cgi?id=163941
+
+        Reviewed by Michael Catanzaro.
+
+        equalLettersIgnoringASCIICase() expects the second argument to be the letters to compare in lowercase, so use
+        "get" instead of "GET".
+
+        * NetworkProcess/soup/NetworkDataTaskSoup.cpp:
+        (WebKit::NetworkDataTaskSoup::continueHTTPRedirection):
+
 2016-10-25  Eric Carlson  <eric.carlson@apple.com>
 
         [MediaStream] Add "has capture device" bit to media state flags
index 8331c39..1763652 100644 (file)
@@ -619,7 +619,7 @@ void NetworkDataTaskSoup::continueHTTPRedirection()
         request.clearHTTPReferrer();
 
     bool isCrossOrigin = !protocolHostAndPortAreEqual(m_firstRequest.url(), request.url());
-    if (!equalLettersIgnoringASCIICase(request.httpMethod(), "GET")) {
+    if (!equalLettersIgnoringASCIICase(request.httpMethod(), "get")) {
         // Change newRequest method to GET if change was made during a previous redirection or if current redirection says so.
         if (m_soupMessage->method == SOUP_METHOD_GET || !request.url().protocolIsInHTTPFamily() || shouldRedirectAsGET(m_soupMessage.get(), isCrossOrigin)) {
             request.setHTTPMethod("GET");