Regression: Unable to trigger context menu on empty tabs in Safari
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 27 Mar 2020 01:35:59 +0000 (01:35 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 27 Mar 2020 01:35:59 +0000 (01:35 +0000)
https://bugs.webkit.org/show_bug.cgi?id=209628

Reviewed by Geoffrey Garen.

Launch the WebPageProxy's initial process if it starts processing mouse events.
As an optimization, the WebPageProxy only launches its initial process when it
really needs to.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/WebPageProxy.cpp

index 6d417b9..e786c2a 100644 (file)
@@ -1,3 +1,17 @@
+2020-03-26  Chris Dumez  <cdumez@apple.com>
+
+        Regression: Unable to trigger context menu on empty tabs in Safari
+        https://bugs.webkit.org/show_bug.cgi?id=209628
+
+        Reviewed by Geoffrey Garen.
+
+        Launch the WebPageProxy's initial process if it starts processing mouse events.
+        As an optimization, the WebPageProxy only launches its initial process when it
+        really needs to.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::handleMouseEvent):
+
 2020-03-26  Michael Catanzaro  <mcatanzaro@gnome.org>
 
         Fix various compiler warnings
index a1c26ed..552a0dd 100644 (file)
@@ -2497,6 +2497,9 @@ static bool removeOldRedundantEvent(Deque<NativeWebMouseEvent>& queue, WebEvent:
 
 void WebPageProxy::handleMouseEvent(const NativeWebMouseEvent& event)
 {
+    if (event.type() == WebEvent::MouseDown)
+        launchInitialProcessIfNecessary();
+
     if (!hasRunningProcess())
         return;