Remove chromium EWS support, and fix broken test.
authorglenn@skynav.com <glenn@skynav.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 9 Apr 2013 00:22:33 +0000 (00:22 +0000)
committerglenn@skynav.com <glenn@skynav.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 9 Apr 2013 00:22:33 +0000 (00:22 +0000)
https://bugs.webkit.org/show_bug.cgi?id=114221

Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractChromiumEWS): Removed.
(ChromiumLinuxEWS): Removed.
(ChromiumLinuxDebugEWS): Removed.
(ChromiumWindowsEWS): Removed.
(ChromiumAndroidEWS): Removed.
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest): Fix misspelled class name.
(test_ewses): Fix entry point name to ensure test is run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py
Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py

index badb637..fdddbad 100644 (file)
@@ -1,3 +1,20 @@
+2013-04-08  Glenn Adams  <glenn@skynav.com>
+
+        Remove chromium EWS support, and fix broken test.
+        https://bugs.webkit.org/show_bug.cgi?id=114221
+
+        Reviewed by Ryosuke Niwa.
+
+        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+        (AbstractChromiumEWS): Removed.
+        (ChromiumLinuxEWS): Removed.
+        (ChromiumLinuxDebugEWS): Removed.
+        (ChromiumWindowsEWS): Removed.
+        (ChromiumAndroidEWS): Removed.
+        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
+        (EarlyWarningSystemTest): Fix misspelled class name.
+        (test_ewses): Fix entry point name to ensure test is run.
+
 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
 
         [WIN] Remove WebKit2 source code
index 04408f3..86e851f 100644 (file)
@@ -176,38 +176,6 @@ class WinEWS(AbstractEarlyWarningSystem):
     port_name = "win"
     _default_run_tests = True
 
-class AbstractChromiumEWS(AbstractEarlyWarningSystem):
-    port_name = "chromium"
-    watchers = AbstractEarlyWarningSystem.watchers + [
-        "dglazkov@chromium.org",
-    ]
-
-
-class ChromiumLinuxEWS(AbstractChromiumEWS):
-    # FIXME: We should rename this command to cr-linux-ews, but that requires
-    #        a database migration. :(
-    name = "chromium-ews"
-    port_name = "chromium-xvfb"
-
-
-class ChromiumLinuxDebugEWS(AbstractChromiumEWS):
-    name = "cr-linux-debug-ews"
-    port_name = "chromium-xvfb"
-    _build_style = "debug"
-
-
-class ChromiumWindowsEWS(AbstractChromiumEWS):
-    name = "cr-win-ews"
-
-
-class ChromiumAndroidEWS(AbstractChromiumEWS):
-    name = "cr-android-ews"
-    port_name = "chromium-android"
-    watchers = AbstractChromiumEWS.watchers + [
-        "peter+ews@chromium.org",
-    ]
-
-
 class MacEWS(AbstractEarlyWarningSystem):
     name = "mac-ews"
     port_name = "mac"
index 5f0b806..d8c602a 100644 (file)
@@ -50,7 +50,7 @@ class AbstractEarlyWarningSystemTest(QueuesTest):
         self.assertMultiLineEqual(ews._failing_tests_message(task, patch), "New failing tests:\nbar.html\nfoo.html")
 
 
-class EarlyWarningSytemTest(QueuesTest):
+class EarlyWarningSystemTest(QueuesTest):
     def _default_expected_logs(self, ews):
         string_replacements = {
             "name": ews.name,
@@ -83,12 +83,9 @@ MOCK: release_work_item: %(name)s 10000
         options.run_tests = ews._default_run_tests
         self.assert_queue_outputs(ews, expected_logs=self._default_expected_logs(ews), options=options)
 
-    def _test_ewses(self):
+    def test_ewses(self):
         self._test_ews(MacEWS())
         self._test_ews(MacWK2EWS())
-        self._test_ews(ChromiumLinuxEWS())
-        self._test_ews(ChromiumWindowsEWS())
-        self._test_ews(ChromiumAndroidEWS())
         self._test_ews(QtEWS())
         self._test_ews(QtWK2EWS())
         self._test_ews(GtkEWS())