dialog-enabled.html and dialog-disabled.html don't really test what they think they do
authortsepez@chromium.org <tsepez@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Mar 2013 23:04:44 +0000 (23:04 +0000)
committertsepez@chromium.org <tsepez@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Mar 2013 23:04:44 +0000 (23:04 +0000)
https://bugs.webkit.org/show_bug.cgi?id=112848

Reviewed by Adam Barth.

* fast/dom/HTMLDialogElement/dialog-disabled.html:
* fast/dom/HTMLDialogElement/dialog-enabled.html:
Set the dialog element enabled setting before parsing <dialog> element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/dom/HTMLDialogElement/dialog-disabled.html
LayoutTests/fast/dom/HTMLDialogElement/dialog-enabled.html

index 8a8f5d2..ae88887 100644 (file)
@@ -1,3 +1,14 @@
+2013-03-20  Tom Sepez  <tsepez@chromium.org>
+
+        dialog-enabled.html and dialog-disabled.html don't really test what they think they do
+        https://bugs.webkit.org/show_bug.cgi?id=112848
+
+        Reviewed by Adam Barth.
+
+        * fast/dom/HTMLDialogElement/dialog-disabled.html:
+        * fast/dom/HTMLDialogElement/dialog-enabled.html:
+        Set the dialog element enabled setting before parsing <dialog> element.
+
 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
 
         Mac rebaseline after r142152.
index 959db0e..014c88c 100644 (file)
@@ -1,14 +1,16 @@
 <!DOCTYPE html>
 <html>
 <head>
+<script>
+if (window.internals)
+    internals.settings.setDialogElementEnabled(false);
+</script>
 <script src="../../js/resources/js-test-pre.js"></script>
 </head>
 <body>
 <dialog id="mydialog"></dialog>
 <script>
 description("The DIALOG element should not be recognized if the dialog feature is off.");
-if (window.internals)
-    internals.settings.setDialogElementEnabled(false);
 dialog = document.getElementById('mydialog');
 shouldBeTrue("typeof dialog.show == 'undefined'");
 </script>
index d1253bb..b76e2c4 100644 (file)
@@ -1,14 +1,16 @@
 <!DOCTYPE html>
 <html>
 <head>
+<script>
+if (window.internals)
+    internals.settings.setDialogElementEnabled(true);
+</script>
 <script src="../../js/resources/js-test-pre.js"></script>
 </head>
 <body>
 <dialog id="mydialog"></dialog>
 <script>
 description("The DIALOG element should be recognized if the dialog feature is on.");
-if (window.internals)
-    internals.settings.setDialogElementEnabled(true);
 dialog = document.getElementById('mydialog');
 shouldBeTrue("typeof dialog.show == 'function'");
 </script>