[SOUP] Layout test media/track/track-text-track-cue-list.html crash with g_source_set...
authorcarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 27 Nov 2017 13:20:53 +0000 (13:20 +0000)
committercarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 27 Nov 2017 13:20:53 +0000 (13:20 +0000)
https://bugs.webkit.org/show_bug.cgi?id=176806

Reviewed by Carlos Alberto Lopez Perez.

Tools:

This was caused by a GLib bug that has already been fixed. Upgrade glib to 2.54.2.

* gtk/jhbuild.modules:
* gtk/patches/gdate-suppress-string-format-literal-warning.patch: Removed.

LayoutTests:

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk/TestExpectations
Tools/ChangeLog
Tools/gtk/jhbuild.modules
Tools/gtk/patches/gdate-suppress-string-format-literal-warning.patch [deleted file]

index 260a418..e2b871c 100644 (file)
@@ -1,3 +1,12 @@
+2017-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [SOUP] Layout test media/track/track-text-track-cue-list.html crash with g_source_set_ready_time: assertion 'source->ref_count > 0' failed
+        https://bugs.webkit.org/show_bug.cgi?id=176806
+
+        Reviewed by Carlos Alberto Lopez Perez.
+
+        * platform/gtk/TestExpectations:
+
 2017-11-27  Javier Fernandez  <jfernandez@igalia.com>
 
         [css-grid] Display issues with child with max-width
index 3ea86a1..55afb62 100644 (file)
@@ -1313,9 +1313,6 @@ webkit.org/b/176803 http/tests/local/blob/send-hybrid-blob-using-open-panel.html
 
 webkit.org/b/176805 media/media-higher-prio-audio-stream.html [ Crash ]
 
-webkit.org/b/176806 media/track/track-text-track-cue-list.html [ Crash Pass ]
-webkit.org/b/176806 media/track/track-id.html [ Crash Pass ]
-
 webkit.org/b/176856 fast/mediastream/apply-constraints-video.html [ Crash ]
 
 # See also webkit.org/b/141699
index 0a5122e..3d33330 100644 (file)
@@ -1,3 +1,15 @@
+2017-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [SOUP] Layout test media/track/track-text-track-cue-list.html crash with g_source_set_ready_time: assertion 'source->ref_count > 0' failed
+        https://bugs.webkit.org/show_bug.cgi?id=176806
+
+        Reviewed by Carlos Alberto Lopez Perez.
+
+        This was caused by a GLib bug that has already been fixed. Upgrade glib to 2.54.2.
+
+        * gtk/jhbuild.modules:
+        * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Removed.
+
 2017-11-24  Darin Adler  <darin@apple.com>
 
         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
index 8131f22..14ee307 100644 (file)
     <dependencies>
       <dep package="libffi"/>
     </dependencies>
-    <branch module="/pub/GNOME/sources/glib/2.52/glib-2.52.1.tar.xz" version="2.52.1"
+    <branch module="/pub/GNOME/sources/glib/2.54/glib-2.54.2.tar.xz" version="2.54.2"
             repo="ftp.gnome.org"
-            hash="sha256:948c26b817f2d77e2a6cdd5082c60a51bf5dea854890286a1d5d4ccde5ce586f">
-      <patch file="gdate-suppress-string-format-literal-warning.patch" strip="1"/>
-    </branch>
+            hash="sha256:bb89e5c5aad33169a8c7f28b45671c7899c12f74caf707737f784d7102758e6c"/>
   </autotools>
 
   <autotools id="glib-networking"
diff --git a/Tools/gtk/patches/gdate-suppress-string-format-literal-warning.patch b/Tools/gtk/patches/gdate-suppress-string-format-literal-warning.patch
deleted file mode 100644 (file)
index 90cb951..0000000
+++ /dev/null
@@ -1,29 +0,0 @@
-From 3a7efd598d39366c2c9de0def2fdfb35e5e9f2a1 Mon Sep 17 00:00:00 2001
-From: coypu <coypu@sdf.org>
-Date: Mon, 8 Feb 2016 00:06:06 +0200
-Subject: [PATCH 1/1] gdate: Suppress string format literal warning
-
-Newer versions of GCC emit an error here, but we know it's safe.
-https://bugzilla.gnome.org/761550
----
- glib/gdate.c | 3 +++
- 1 file changed, 3 insertions(+)
-
-diff --git a/glib/gdate.c b/glib/gdate.c
-index 4aece02..cdc735c 100644
---- a/glib/gdate.c
-+++ b/glib/gdate.c
-@@ -2494,7 +2494,10 @@ g_date_strftime (gchar       *s,
-        * recognize whether strftime actually failed or just returned "".
-        */
-       tmpbuf[0] = '\1';
-+      #pragma GCC diagnostic push
-+      #pragma GCC diagnostic ignored "-Wformat-nonliteral"
-       tmplen = strftime (tmpbuf, tmpbufsize, locale_format, &tm);
-+      #pragma GCC diagnostic pop
-       if (tmplen == 0 && tmpbuf[0] != '\0')
-         {
--- 
-2.7.0
-