[mac-wk1 debug] LayoutTest media/modern-media-controls/airplay-placard/airplay-placar...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 15 Mar 2017 10:19:04 +0000 (10:19 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 15 Mar 2017 10:19:04 +0000 (10:19 +0000)
https://bugs.webkit.org/show_bug.cgi?id=169654
<rdar://problem/31059092>

Patch by Antoine Quint <graouts@apple.com> on 2017-03-15
Reviewed by Dean Jackson.

Using an asynchronous assertion to improve reliability.

* media/modern-media-controls/airplay-placard/airplay-placard-text-section-expected.txt:
* media/modern-media-controls/airplay-placard/airplay-placard-text-section.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/media/modern-media-controls/airplay-placard/airplay-placard-text-section-expected.txt
LayoutTests/media/modern-media-controls/airplay-placard/airplay-placard-text-section.html

index 46648af..4c42b83 100644 (file)
@@ -1,3 +1,16 @@
+2017-03-15  Antoine Quint  <graouts@apple.com>
+
+        [mac-wk1 debug] LayoutTest media/modern-media-controls/airplay-placard/airplay-placard-text-section.html is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=169654
+        <rdar://problem/31059092>
+
+        Reviewed by Dean Jackson.
+
+        Using an asynchronous assertion to improve reliability.
+
+        * media/modern-media-controls/airplay-placard/airplay-placard-text-section-expected.txt:
+        * media/modern-media-controls/airplay-placard/airplay-placard-text-section.html:
+
 2017-03-14  Youenn Fablet  <youenn@apple.com>
 
         CanvasCapture should not generate a frame per each canvas draw command
index a328c81..f1de82c 100644 (file)
@@ -3,6 +3,7 @@ Testing that text selection is turned off for AirplayPlacard.
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
+PASS !!document.querySelector('.placard') became true
 PASS window.getComputedStyle(document.querySelector('.title')).webkitUserSelect is "none"
 PASS window.getComputedStyle(document.querySelector('.title')).cursor is "default"
 PASS window.getComputedStyle(document.querySelector('.description')).webkitUserSelect is "none"
index 48df516..e37ffff 100644 (file)
@@ -12,8 +12,7 @@ const mediaControls = new MacOSInlineMediaControls({ width: 600, height: 300 });
 mediaControls.showPlacard(mediaControls.airplayPlacard);
 document.body.appendChild(mediaControls.element);
 
-scheduler.frameDidFire = function()
-{
+shouldBecomeEqual("!!document.querySelector('.placard')", "true", () => {
     shouldBeEqualToString("window.getComputedStyle(document.querySelector('.title')).webkitUserSelect", "none");
     shouldBeEqualToString("window.getComputedStyle(document.querySelector('.title')).cursor", "default");
     shouldBeEqualToString("window.getComputedStyle(document.querySelector('.description')).webkitUserSelect", "none");
@@ -21,8 +20,8 @@ scheduler.frameDidFire = function()
 
     mediaControls.element.remove();
     debug("");
-    finishMediaControlsTest();
-};
+    finishJSTest();
+});
 
 </script>
 <script src="../../../resources/js-test-post.js"></script>