Reviewed by John.
authormjs <mjs@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 17 Jun 2004 01:19:22 +0000 (01:19 +0000)
committermjs <mjs@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 17 Jun 2004 01:19:22 +0000 (01:19 +0000)
<rdar://problem/3697602> REGRESSION (144.2-TOT) Selection highlight does not draw

        * khtml/rendering/render_canvas.cpp:
        (RenderCanvas::setSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@6872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog-2005-08-23
WebCore/khtml/rendering/render_canvas.cpp

index 97ce926..de01419 100644 (file)
@@ -1,3 +1,12 @@
+2004-06-16  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by John.
+
+       <rdar://problem/3697602> REGRESSION (144.2-TOT) Selection highlight does not draw
+
+        * khtml/rendering/render_canvas.cpp:
+        (RenderCanvas::setSelection):
+
 === Safari-145 ===
 
 2004-06-16  Richard Williamson   <rjw@apple.com>
index eca83aa..67ecf94 100644 (file)
@@ -425,7 +425,7 @@ void RenderCanvas::setSelection(RenderObject *s, int sp, RenderObject *e, int ep
     
     while (o && o!=e)
     {
-        if (o->style()->userSelect())
+        if (o->style()->userSelect() != SELECT_NONE)
             o->setSelectionState(SelectionInside);
 //      kdDebug( 6040 ) << "setting selected " << o << ", " << o->isText() << endl;
         RenderObject* no = 0;
@@ -446,11 +446,11 @@ void RenderCanvas::setSelection(RenderObject *s, int sp, RenderObject *e, int ep
         o=no;
     }
     
-    if (s->style()->userSelect())
+    if (s->style()->userSelect() != SELECT_NONE)
         s->setSelectionState(SelectionStart);
-    if (e->style()->userSelect())
+    if (e->style()->userSelect() != SELECT_NONE)
         e->setSelectionState(SelectionEnd);
-    if (s == e && s->style()->userSelect())
+    if (s == e && s->style()->userSelect() != SELECT_NONE)
         s->setSelectionState(SelectionBoth);
 
 #if APPLE_CHANGES