REGRESSION(r200474): Exception in autocompletion - `getCompletions` not found
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 6 May 2016 03:14:48 +0000 (03:14 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 6 May 2016 03:14:48 +0000 (03:14 +0000)
https://bugs.webkit.org/show_bug.cgi?id=157408

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-05-05
Reviewed by Timothy Hatcher.

* UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
(WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.evaluated):
This function was renamed, but this instance was missed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@200505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js

index ac7f322..75b9c5a 100644 (file)
@@ -1,5 +1,16 @@
 2016-05-05  Joseph Pecoraro  <pecoraro@apple.com>
 
 2016-05-05  Joseph Pecoraro  <pecoraro@apple.com>
 
+        REGRESSION(r200474): Exception in autocompletion - `getCompletions` not found
+        https://bugs.webkit.org/show_bug.cgi?id=157408
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
+        (WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.evaluated):
+        This function was renamed, but this instance was missed.
+
+2016-05-05  Joseph Pecoraro  <pecoraro@apple.com>
+
         Web Inspector: Provide go-to links next to Functions in GC Root Path popover
         https://bugs.webkit.org/show_bug.cgi?id=157381
         <rdar://problem/26122531>
         Web Inspector: Provide go-to links next to Functions in GC Root Path popover
         https://bugs.webkit.org/show_bug.cgi?id=157381
         <rdar://problem/26122531>
index e64661f..7059922 100644 (file)
@@ -186,7 +186,7 @@ WebInspector.JavaScriptRuntimeCompletionProvider = class JavaScriptRuntimeComple
             else if (result.type === "object" || result.type === "function")
                 result.callFunctionJSON(inspectedPage_evalResult_getCompletions, undefined, receivedPropertyNames.bind(this));
             else if (result.type === "string" || result.type === "number" || result.type === "boolean" || result.type === "symbol")
             else if (result.type === "object" || result.type === "function")
                 result.callFunctionJSON(inspectedPage_evalResult_getCompletions, undefined, receivedPropertyNames.bind(this));
             else if (result.type === "string" || result.type === "number" || result.type === "boolean" || result.type === "symbol")
-                WebInspector.runtimeManager.evaluateInInspectedWindow("(" + getCompletions + ")(\"" + result.type + "\")", "completion", false, true, true, false, false, receivedPropertyNamesFromEvaluate.bind(this));
+                WebInspector.runtimeManager.evaluateInInspectedWindow("(" + inspectedPage_evalResult_getCompletions + ")(\"" + result.type + "\")", "completion", false, true, true, false, false, receivedPropertyNamesFromEvaluate.bind(this));
             else
                 console.error("Unknown result type: " + result.type);
         }
             else
                 console.error("Unknown result type: " + result.type);
         }