Bag's move operator= leaks memory
authorsbarati@apple.com <sbarati@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 11 May 2019 00:39:58 +0000 (00:39 +0000)
committersbarati@apple.com <sbarati@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 11 May 2019 00:39:58 +0000 (00:39 +0000)
https://bugs.webkit.org/show_bug.cgi?id=197757

Reviewed by Keith Miller.

It was unused. So I'm just removing it. We can implement it properly
if we ever need it.

* wtf/Bag.h:
(WTF::Bag::operator=): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WTF/ChangeLog
Source/WTF/wtf/Bag.h

index fd827f1..a5f9d96 100644 (file)
@@ -1,3 +1,16 @@
+2019-05-10  Saam barati  <sbarati@apple.com>
+
+        Bag's move operator= leaks memory
+        https://bugs.webkit.org/show_bug.cgi?id=197757
+
+        Reviewed by Keith Miller.
+
+        It was unused. So I'm just removing it. We can implement it properly
+        if we ever need it.
+
+        * wtf/Bag.h:
+        (WTF::Bag::operator=): Deleted.
+
 2019-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
 
         [WinCairo] storage/indexeddb tests are timing out
index 1f85720..1e585b0 100644 (file)
@@ -65,14 +65,6 @@ public:
         other.m_head = nullptr;
     }
 
-    template<typename U>
-    Bag& operator=(Bag<T, U>&& other)
-    {
-        m_head = other.unwrappedHead();
-        other.m_head = nullptr;
-        return *this;
-    }
-    
     ~Bag()
     {
         clear();