Move editing history scripts to WebCore PrivateHeaders
authorwenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 5 Jan 2017 05:09:04 +0000 (05:09 +0000)
committerwenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 5 Jan 2017 05:09:04 +0000 (05:09 +0000)
https://bugs.webkit.org/show_bug.cgi?id=166709
<rdar://problem/29876612>

Reviewed by Dan Bernstein.

Source/WebCore:

Move editing history scripts out of InternalScripts and into Scripts, and update the WebCore Copy Script build
phase to copy the editing scripts into PrivateHeaders.

No new tests, because there should be no behavior change.

* Scripts/DumpEditingHistory.js: Renamed from Source/WebCore/InternalScripts/DumpEditingHistory.js.
* Scripts/EditingHistoryUtil.js: Renamed from Source/WebCore/InternalScripts/EditingHistoryUtil.js.
* WebCore.xcodeproj/project.pbxproj:

Tools:

Update references to editing script files in WebCore that were moved.

* EditingHistory/EditingHistory.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@210318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/Scripts/DumpEditingHistory.js [moved from Source/WebCore/InternalScripts/DumpEditingHistory.js with 100% similarity]
Source/WebCore/Scripts/EditingHistoryUtil.js [moved from Source/WebCore/InternalScripts/EditingHistoryUtil.js with 100% similarity]
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Tools/ChangeLog
Tools/EditingHistory/EditingHistory.xcodeproj/project.pbxproj

index 03b78ba..af32356 100644 (file)
@@ -1,3 +1,20 @@
+2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Move editing history scripts to WebCore PrivateHeaders
+        https://bugs.webkit.org/show_bug.cgi?id=166709
+        <rdar://problem/29876612>
+
+        Reviewed by Dan Bernstein.
+
+        Move editing history scripts out of InternalScripts and into Scripts, and update the WebCore Copy Script build
+        phase to copy the editing scripts into PrivateHeaders.
+
+        No new tests, because there should be no behavior change.
+
+        * Scripts/DumpEditingHistory.js: Renamed from Source/WebCore/InternalScripts/DumpEditingHistory.js.
+        * Scripts/EditingHistoryUtil.js: Renamed from Source/WebCore/InternalScripts/EditingHistoryUtil.js.
+        * WebCore.xcodeproj/project.pbxproj:
+
 2017-01-04  Joseph Pecoraro  <pecoraro@apple.com>
 
         Web Inspector: forced pseudo classes aren't cleared from inspected page when Inspector closes
index 102bc56..ca6bef5 100644 (file)
                51C81B8A0C4422F70019ECE3 /* FTPDirectoryParser.h in Headers */ = {isa = PBXBuildFile; fileRef = 51C81B880C4422F70019ECE3 /* FTPDirectoryParser.h */; };
                51CBFC990D10E483002DBF51 /* CachedFramePlatformData.h in Headers */ = {isa = PBXBuildFile; fileRef = 51CBFC980D10E483002DBF51 /* CachedFramePlatformData.h */; settings = {ATTRIBUTES = (Private, ); }; };
                51D0C5160DAA90B7003B3831 /* JSStorageCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51D0C5150DAA90B7003B3831 /* JSStorageCustom.cpp */; };
-               51D394781DF2492200ABE875 /* DumpEditingHistory.js in Copy Internal Scripts */ = {isa = PBXBuildFile; fileRef = 51D394741DF2454000ABE875 /* DumpEditingHistory.js */; };
-               51D394791DF2492200ABE875 /* EditingHistoryUtil.js in Copy Internal Scripts */ = {isa = PBXBuildFile; fileRef = 51D394751DF2454000ABE875 /* EditingHistoryUtil.js */; };
                51D7236C1BB6174900478CA3 /* IDBResultData.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51D7236A1BB60BFE00478CA3 /* IDBResultData.cpp */; };
                51D7236D1BB6174900478CA3 /* IDBResultData.h in Headers */ = {isa = PBXBuildFile; fileRef = 51D7236B1BB60BFE00478CA3 /* IDBResultData.h */; settings = {ATTRIBUTES = (Private, ); }; };
                51D7EFEA1BDE8F8C00E93E10 /* ThreadSafeDataBuffer.h in Headers */ = {isa = PBXBuildFile; fileRef = 511FAEA91BDC989A00B4AFE4 /* ThreadSafeDataBuffer.h */; settings = {ATTRIBUTES = (Private, ); }; };
                F478755519983AFF0024A287 /* ScrollSnapAnimatorState.mm in Sources */ = {isa = PBXBuildFile; fileRef = F478755319983AFF0024A287 /* ScrollSnapAnimatorState.mm */; };
                F47A5E3E195B8C8A00483100 /* StyleScrollSnapPoints.h in Headers */ = {isa = PBXBuildFile; fileRef = F47A5E3B195B8C8A00483100 /* StyleScrollSnapPoints.h */; settings = {ATTRIBUTES = (Private, ); }; };
                F47A5E3F195B8E4800483100 /* StyleScrollSnapPoints.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F47A5E3A195B8C8A00483100 /* StyleScrollSnapPoints.cpp */; };
+               F4BFB9851E1DDF9B00862C24 /* DumpEditingHistory.js in Copy Scripts */ = {isa = PBXBuildFile; fileRef = F48389831E1DDF2B0076B7EA /* DumpEditingHistory.js */; };
+               F4BFB9861E1DDF9B00862C24 /* EditingHistoryUtil.js in Copy Scripts */ = {isa = PBXBuildFile; fileRef = F48389841E1DDF2B0076B7EA /* EditingHistoryUtil.js */; };
                F50664F7157F52DC00AC226F /* FormController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F50664F5157F52DC00AC226F /* FormController.cpp */; };
                F50664F8157F52DC00AC226F /* FormController.h in Headers */ = {isa = PBXBuildFile; fileRef = F50664F6157F52DC00AC226F /* FormController.h */; };
                F513A3EA15FF4841001526DB /* ValidationMessageClient.h in Headers */ = {isa = PBXBuildFile; fileRef = F513A3E915FF4841001526DB /* ValidationMessageClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
                        dstPath = PrivateHeaders/Scripts;
                        dstSubfolderSpec = 1;
                        files = (
+                               F4BFB9851E1DDF9B00862C24 /* DumpEditingHistory.js in Copy Scripts */,
+                               F4BFB9861E1DDF9B00862C24 /* EditingHistoryUtil.js in Copy Scripts */,
                                3717D7E817ECC591003C276D /* extract-localizable-strings.pl in Copy Scripts */,
                                37D456FD1A9A50D8003330A1 /* LocalizableStrings.pm in Copy Scripts */,
                        );
                        name = "Copy Scripts";
                        runOnlyForDeploymentPostprocessing = 0;
                };
-               51D394771DF2486700ABE875 /* Copy Internal Scripts */ = {
-                       isa = PBXCopyFilesBuildPhase;
-                       buildActionMask = 8;
-                       dstPath = "$(APPLE_INTERNAL_LIBRARY_DIR)/WebKit/InternalScripts";
-                       dstSubfolderSpec = 0;
-                       files = (
-                               51D394781DF2492200ABE875 /* DumpEditingHistory.js in Copy Internal Scripts */,
-                               51D394791DF2492200ABE875 /* EditingHistoryUtil.js in Copy Internal Scripts */,
-                       );
-                       name = "Copy Internal Scripts";
-                       runOnlyForDeploymentPostprocessing = 1;
-               };
                CD0DBF001422765700280263 /* Copy Audio Resources */ = {
                        isa = PBXCopyFilesBuildPhase;
                        buildActionMask = 2147483647;
                51C81B880C4422F70019ECE3 /* FTPDirectoryParser.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = FTPDirectoryParser.h; sourceTree = "<group>"; };
                51CBFC980D10E483002DBF51 /* CachedFramePlatformData.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CachedFramePlatformData.h; sourceTree = "<group>"; };
                51D0C5150DAA90B7003B3831 /* JSStorageCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSStorageCustom.cpp; sourceTree = "<group>"; };
-               51D394741DF2454000ABE875 /* DumpEditingHistory.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; name = DumpEditingHistory.js; path = InternalScripts/DumpEditingHistory.js; sourceTree = "<group>"; };
-               51D394751DF2454000ABE875 /* EditingHistoryUtil.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; name = EditingHistoryUtil.js; path = InternalScripts/EditingHistoryUtil.js; sourceTree = "<group>"; };
                51D7196C181106DF0016DC51 /* DOMWindowIndexedDatabase.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DOMWindowIndexedDatabase.cpp; sourceTree = "<group>"; };
                51D7196D181106DF0016DC51 /* DOMWindowIndexedDatabase.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMWindowIndexedDatabase.h; sourceTree = "<group>"; };
                51D7196E181106DF0016DC51 /* DOMWindowIndexedDatabase.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = DOMWindowIndexedDatabase.idl; sourceTree = "<group>"; };
                F478755319983AFF0024A287 /* ScrollSnapAnimatorState.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ScrollSnapAnimatorState.mm; sourceTree = "<group>"; };
                F47A5E3A195B8C8A00483100 /* StyleScrollSnapPoints.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = StyleScrollSnapPoints.cpp; sourceTree = "<group>"; };
                F47A5E3B195B8C8A00483100 /* StyleScrollSnapPoints.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StyleScrollSnapPoints.h; sourceTree = "<group>"; };
+               F48389831E1DDF2B0076B7EA /* DumpEditingHistory.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; name = DumpEditingHistory.js; path = Scripts/DumpEditingHistory.js; sourceTree = "<group>"; };
+               F48389841E1DDF2B0076B7EA /* EditingHistoryUtil.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; name = EditingHistoryUtil.js; path = Scripts/EditingHistoryUtil.js; sourceTree = "<group>"; };
                F50664F5157F52DC00AC226F /* FormController.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = FormController.cpp; sourceTree = "<group>"; };
                F50664F6157F52DC00AC226F /* FormController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = FormController.h; sourceTree = "<group>"; };
                F513A3E915FF4841001526DB /* ValidationMessageClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ValidationMessageClient.h; sourceTree = "<group>"; };
                                2E4346310F546A6800B0F1BA /* workers */,
                                E1F0424309839389006694EA /* xml */,
                                656580EC09D12B20000E61D7 /* Derived Sources */,
-                               51D394731DF244BA00ABE875 /* InternalScripts */,
                                089C1665FE841158C02AAC07 /* Resources */,
                                3717D7E417ECC36C003C276D /* Scripts */,
                                0867D69AFE84028FC02AAC07 /* Frameworks */,
                3717D7E417ECC36C003C276D /* Scripts */ = {
                        isa = PBXGroup;
                        children = (
+                               F48389791E1DD23A0076B7EA /* EditingHistory */,
                                3717D7E517ECC3A6003C276D /* extract-localizable-strings.pl */,
                                37D456FB1A9A50B6003330A1 /* LocalizableStrings.pm */,
                        );
                        path = mac;
                        sourceTree = "<group>";
                };
-               51D394731DF244BA00ABE875 /* InternalScripts */ = {
-                       isa = PBXGroup;
-                       children = (
-                               51D394741DF2454000ABE875 /* DumpEditingHistory.js */,
-                               51D394751DF2454000ABE875 /* EditingHistoryUtil.js */,
-                       );
-                       name = InternalScripts;
-                       sourceTree = "<group>";
-               };
                59B5977111086556007159E8 /* jsc */ = {
                        isa = PBXGroup;
                        children = (
                        path = mac;
                        sourceTree = "<group>";
                };
+               F48389791E1DD23A0076B7EA /* EditingHistory */ = {
+                       isa = PBXGroup;
+                       children = (
+                               F48389831E1DDF2B0076B7EA /* DumpEditingHistory.js */,
+                               F48389841E1DDF2B0076B7EA /* EditingHistoryUtil.js */,
+                       );
+                       name = EditingHistory;
+                       sourceTree = "<group>";
+               };
                F523D18402DE42E8018635CA /* css */ = {
                        isa = PBXGroup;
                        children = (
                                37A1EAA3142699BC0087F425 /* Check For Inappropriate Objective-C Class Names */,
                                5DF50887116F3077005202AB /* Check For Inappropriate Files In Framework */,
                                71D6AA381DA4E69400B23969 /* Copy modern media controls code and assets */,
-                               51D394771DF2486700ABE875 /* Copy Internal Scripts */,
                        );
                        buildRules = (
                        );
index c0af584..6b87705 100644 (file)
@@ -1,3 +1,15 @@
+2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Move editing history scripts to WebCore PrivateHeaders
+        https://bugs.webkit.org/show_bug.cgi?id=166709
+        <rdar://problem/29876612>
+
+        Reviewed by Dan Bernstein.
+
+        Update references to editing script files in WebCore that were moved.
+
+        * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
+
 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
 
         Unreviewed, build fix after r210313 part 2
index d234bb8..49965ef 100644 (file)
                516ADBE61DE156BB00E2B98D /* main.m in Sources */ = {isa = PBXBuildFile; fileRef = 516ADBB11DE155BD00E2B98D /* main.m */; };
                516ADBF31DE157AD00E2B98D /* RewindAndPlaybackTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 516ADBF21DE157AD00E2B98D /* RewindAndPlaybackTests.m */; };
                517FD93C1DE18DC900A73673 /* DOMTestingUtil.js in Resources */ = {isa = PBXBuildFile; fileRef = 517FD93B1DE18DC900A73673 /* DOMTestingUtil.js */; };
-               51D394801DF2541D00ABE875 /* DumpEditingHistory.js in Resources */ = {isa = PBXBuildFile; fileRef = 51D3947E1DF2541D00ABE875 /* DumpEditingHistory.js */; };
-               51D394811DF2541D00ABE875 /* EditingHistoryUtil.js in Resources */ = {isa = PBXBuildFile; fileRef = 51D3947F1DF2541D00ABE875 /* EditingHistoryUtil.js */; };
                51ECC3E71DEE33CE00CB267E /* TestUtil.m in Sources */ = {isa = PBXBuildFile; fileRef = 516ADBB51DE155BD00E2B98D /* TestUtil.m */; };
                51ECC3E91DEE33D200CB267E /* WKWebViewAdditions.m in Sources */ = {isa = PBXBuildFile; fileRef = 516ADBB71DE155BD00E2B98D /* WKWebViewAdditions.m */; };
                51ECC3EA1DEE33DD00CB267E /* TestRunner.m in Sources */ = {isa = PBXBuildFile; fileRef = 516ADBB31DE155BD00E2B98D /* TestRunner.m */; };
+               F4BFB9891E1DE82D00862C24 /* DumpEditingHistory.js in Resources */ = {isa = PBXBuildFile; fileRef = F4BFB9871E1DE82D00862C24 /* DumpEditingHistory.js */; };
+               F4BFB98A1E1DE82D00862C24 /* EditingHistoryUtil.js in Resources */ = {isa = PBXBuildFile; fileRef = F4BFB9881E1DE82D00862C24 /* EditingHistoryUtil.js */; };
 /* End PBXBuildFile section */
 
 /* Begin PBXContainerItemProxy section */
@@ -47,6 +47,8 @@
                517FD93B1DE18DC900A73673 /* DOMTestingUtil.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; name = DOMTestingUtil.js; path = EditingHistory/Resources/DOMTestingUtil.js; sourceTree = SOURCE_ROOT; };
                51D3947E1DF2541D00ABE875 /* DumpEditingHistory.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; name = DumpEditingHistory.js; path = ../../Source/WebCore/InternalScripts/DumpEditingHistory.js; sourceTree = SOURCE_ROOT; };
                51D3947F1DF2541D00ABE875 /* EditingHistoryUtil.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; name = EditingHistoryUtil.js; path = ../../Source/WebCore/InternalScripts/EditingHistoryUtil.js; sourceTree = SOURCE_ROOT; };
+               F4BFB9871E1DE82D00862C24 /* DumpEditingHistory.js */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.javascript; name = DumpEditingHistory.js; path = ../../Source/WebCore/Scripts/DumpEditingHistory.js; sourceTree = "<group>"; };
+               F4BFB9881E1DE82D00862C24 /* EditingHistoryUtil.js */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.javascript; name = EditingHistoryUtil.js; path = ../../Source/WebCore/Scripts/EditingHistoryUtil.js; sourceTree = "<group>"; };
 /* End PBXFileReference section */
 
 /* Begin PBXFrameworksBuildPhase section */
@@ -70,6 +72,8 @@
                512D7A8A1DE0FBEF0028F0E6 = {
                        isa = PBXGroup;
                        children = (
+                               F4BFB9871E1DE82D00862C24 /* DumpEditingHistory.js */,
+                               F4BFB9881E1DE82D00862C24 /* EditingHistoryUtil.js */,
                                512D7A951DE0FBEF0028F0E6 /* EditingHistory */,
                                516ADBF11DE157AD00E2B98D /* EditingHistoryTests */,
                                512D7A941DE0FBEF0028F0E6 /* Products */,
                        isa = PBXResourcesBuildPhase;
                        buildActionMask = 2147483647;
                        files = (
-                               51D394801DF2541D00ABE875 /* DumpEditingHistory.js in Resources */,
+                               F4BFB9891E1DE82D00862C24 /* DumpEditingHistory.js in Resources */,
+                               F4BFB98A1E1DE82D00862C24 /* EditingHistoryUtil.js in Resources */,
                                516ADBE21DE156A900E2B98D /* CaptureHarness.html in Resources */,
                                517FD93C1DE18DC900A73673 /* DOMTestingUtil.js in Resources */,
                                516ADBE51DE156A900E2B98D /* PlaybackHarness.html in Resources */,
-                               51D394811DF2541D00ABE875 /* EditingHistoryUtil.js in Resources */,
                        );
                        runOnlyForDeploymentPostprocessing = 0;
                };