Reviewed by Tim H.
authorweinig <weinig@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 27 Dec 2006 23:47:30 +0000 (23:47 +0000)
committerweinig <weinig@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 27 Dec 2006 23:47:30 +0000 (23:47 +0000)
        Bug 11993: REGRESSION(r18320): Web Inspector scroll bars not drawn
        http://bugs.webkit.org/show_bug.cgi?id=11993

        AppleVerticalScrollbar tries to set a NaN value as the scroll height which
        causes DOM Exceptions after r18320.  This overrides the _setObjectLength
        method and checks for NaN until a system update can fix this.  See rdar://4901491

        * WebInspector/webInspector/inspector.html:
        * WebInspector/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/ChangeLog
WebKit/WebInspector/webInspector/inspector.html
WebKit/WebInspector/webInspector/inspector.js

index 231c449..be98a37 100644 (file)
@@ -1,3 +1,17 @@
+2006-12-27  Matt Lilek  <pewtermoose@gmail.com>
+
+        Reviewed by Tim H.
+        
+        Bug 11993: REGRESSION(r18320): Web Inspector scroll bars not drawn
+        http://bugs.webkit.org/show_bug.cgi?id=11993
+        
+        AppleVerticalScrollbar tries to set a NaN value as the scroll height which
+        causes DOM Exceptions after r18320.  This overrides the _setObjectLength
+        method and checks for NaN until a system update can fix this.  See rdar://4901491
+
+        * WebInspector/webInspector/inspector.html:
+        * WebInspector/webInspector/inspector.js:
+
 2006-12-27  Geoffrey Garen  <ggaren@apple.com>
 
         Reviewed by Oliver Hunt.
index 465f557..6ae2ca6 100644 (file)
@@ -30,9 +30,9 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 <head>
     <meta http-equiv="content-type" content="text/html; charset=utf-8" />
     <title>Web Inspector</title>
-    <script type="text/javascript" src="inspector.js"></script> 
-    <script type="text/javascript" src="file:///System/Library/WidgetResources/AppleClasses/AppleScrollbar.js"></script>    
+    <script type="text/javascript" src="file:///System/Library/WidgetResources/AppleClasses/AppleScrollbar.js"></script>
     <script type="text/javascript" src="file:///System/Library/WidgetResources/AppleClasses/AppleScrollArea.js"></script>
+    <script type="text/javascript" src="inspector.js"></script>
     <style type="text/css">
         @import "inspector.css";
     </style>
index a4c0ff7..5dda765 100644 (file)
@@ -927,3 +927,10 @@ function updatePropertiesPane()
 
     jsPropertiesScrollArea.refresh();
 }
+
+// This is a workaround for rdar://4901491 - Dashboard AppleClasses try to set a NaN value and break the scrollbar.
+AppleVerticalScrollbar.prototype._setObjectLength = function(object, length)
+{
+    if (!isNaN(length))
+        object.style.height = length + "px";
+}