Slightly clean up WebCore's Base.xcconfig
authormitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 28 Dec 2012 17:02:29 +0000 (17:02 +0000)
committermitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 28 Dec 2012 17:02:29 +0000 (17:02 +0000)
https://bugs.webkit.org/show_bug.cgi?id=105808

Reviewed by Sam Weinig.

* Configurations/Base.xcconfig: Simplify the definition of GCC_GENERATE_DEBUGGING_SYMBOLS,
which is always YES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/Configurations/Base.xcconfig

index e25b06b..29beaa6 100644 (file)
@@ -1,3 +1,13 @@
+2012-12-28  Dan Bernstein  <mitz@apple.com>
+
+        Slightly clean up WebCore's Base.xcconfig
+        https://bugs.webkit.org/show_bug.cgi?id=105808
+
+        Reviewed by Sam Weinig.
+
+        * Configurations/Base.xcconfig: Simplify the definition of GCC_GENERATE_DEBUGGING_SYMBOLS,
+        which is always YES.
+
 2012-12-28  Rafael Weinstein  <rafaelw@chromium.org>
 
         Heap-use-after-free in WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement
index 5816769..8c13994 100644 (file)
@@ -94,15 +94,7 @@ WEBCORE_SQLITE3_HEADER_SEARCH_PATHS = $(NEXT_ROOT)/usr/local/include/WebCoreSQLi
 SQLITE3_HEADER_SEARCH_PATHS = $(SQLITE3_HEADER_SEARCH_PATHS_$(PLATFORM_NAME));
 SQLITE3_HEADER_SEARCH_PATHS_macosx = $(SQLITE3_HEADER_SEARCH_PATHS_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
 
-// FIXME: The size of the debug symbols generated for WebCore exceeds that which a 32-bit linker can deal with.
-// To allow the Leopard build bots to successfully compile WebCore we're disabling debug symbols in debug builds.
-GCC_GENERATE_DEBUGGING_SYMBOLS = $(GCC_GENERATE_DEBUGGING_SYMBOLS_$(PLATFORM_NAME));
-GCC_GENERATE_DEBUGGING_SYMBOLS_iphoneos = YES;
-GCC_GENERATE_DEBUGGING_SYMBOLS_iphonesimulator = YES;
-GCC_GENERATE_DEBUGGING_SYMBOLS_macosx = $(GCC_GENERATE_DEBUGGING_SYMBOLS_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
-GCC_GENERATE_DEBUGGING_SYMBOLS_macosx_1070 = YES;
-GCC_GENERATE_DEBUGGING_SYMBOLS_macosx_1080 = YES;
-GCC_GENERATE_DEBUGGING_SYMBOLS_macosx_1090 = YES;
+GCC_GENERATE_DEBUGGING_SYMBOLS = YES;
 
 TARGETING_SAME_OS_X_VERSION = $(TARGETING_SAME_OS_X_VERSION_$(MAC_OS_X_VERSION_MAJOR)_$(TARGET_MAC_OS_X_VERSION_MAJOR));
 TARGETING_SAME_OS_X_VERSION_1070_1070 = YES;