fix style failures in webkitpy: expected 2 blank lines found 1
authoraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 10 Nov 2017 17:39:51 +0000 (17:39 +0000)
committeraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 10 Nov 2017 17:39:51 +0000 (17:39 +0000)
https://bugs.webkit.org/show_bug.cgi?id=179529

Reviewed by Alex Christensen.

* Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added a blank line to follow style guidelines.
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Ditto.
* Scripts/webkitpy/common/system/platforminfo_mock.py: Ditto.
* Scripts/webkitpy/common/version.py: Ditto.
* Scripts/webkitpy/layout_tests/models/test_failures.py: Ditto.
* Scripts/webkitpy/port/mac_unittest.py: Ditto.
* Scripts/webkitpy/port/simulator_process.py: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py
Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py
Tools/Scripts/webkitpy/common/system/platforminfo_mock.py
Tools/Scripts/webkitpy/common/version.py
Tools/Scripts/webkitpy/layout_tests/models/test_failures.py
Tools/Scripts/webkitpy/port/mac_unittest.py
Tools/Scripts/webkitpy/port/simulator_process.py

index eb2ef13..a6abc9f 100644 (file)
@@ -1,3 +1,18 @@
+2017-11-10  Aakash Jain  <aakash_jain@apple.com>
+
+        fix style failures in webkitpy: expected 2 blank lines found 1
+        https://bugs.webkit.org/show_bug.cgi?id=179529
+
+        Reviewed by Alex Christensen.
+
+        * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added a blank line to follow style guidelines.
+        * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Ditto.
+        * Scripts/webkitpy/common/system/platforminfo_mock.py: Ditto.
+        * Scripts/webkitpy/common/version.py: Ditto.
+        * Scripts/webkitpy/layout_tests/models/test_failures.py: Ditto.
+        * Scripts/webkitpy/port/mac_unittest.py: Ditto.
+        * Scripts/webkitpy/port/simulator_process.py: Ditto.
+
 2017-11-10  Alex Christensen  <achristensen@webkit.org>
 
         REGRESSION(r224267): WebViews scheduled with custom run loop modes don't load
 2017-11-10  Alex Christensen  <achristensen@webkit.org>
 
         REGRESSION(r224267): WebViews scheduled with custom run loop modes don't load
index c8139b8..43b3c7e 100644 (file)
@@ -8,6 +8,7 @@ from osx_browser_driver import OSXBrowserDriver
 
 _log = logging.getLogger(__name__)
 
 
 _log = logging.getLogger(__name__)
 
+
 class OSXChromeDriver(OSXBrowserDriver):
     process_name = 'Google Chrome'
     browser_name = 'chrome'
 class OSXChromeDriver(OSXBrowserDriver):
     process_name = 'Google Chrome'
     browser_name = 'chrome'
@@ -59,6 +60,7 @@ def create_args():
     args = ['--args', '--homepage', create_window_size_arg()]
     return args
 
     args = ['--args', '--homepage', create_window_size_arg()]
     return args
 
+
 def create_chrome_options():
     from selenium.webdriver.chrome.options import Options
     chrome_options = Options()
 def create_chrome_options():
     from selenium.webdriver.chrome.options import Options
     chrome_options = Options()
index 7e8f654..b08c102 100755 (executable)
@@ -61,6 +61,7 @@ def parse_args():
 
     return args
 
 
     return args
 
+
 def run_benchmark_plan(args, plan):
     benchmark_runner_class = benchmark_runner_subclasses[args.driver]
     runner = benchmark_runner_class(plan, args.local_copy, args.count, args.build_dir, args.output_file, args.platform, args.browser, args.scale_unit, args.device_id)
 def run_benchmark_plan(args, plan):
     benchmark_runner_class = benchmark_runner_subclasses[args.driver]
     runner = benchmark_runner_class(plan, args.local_copy, args.count, args.build_dir, args.output_file, args.platform, args.browser, args.scale_unit, args.device_id)
@@ -72,6 +73,7 @@ def list_benchmark_plans():
     for plan in BenchmarkRunner.available_plans():
         print "\t%s" % plan
 
     for plan in BenchmarkRunner.available_plans():
         print "\t%s" % plan
 
+
 def start(args):
     if args.json_file:
         results_json = json.load(open(args.json_file, 'r'))
 def start(args):
     if args.json_file:
         results_json = json.load(open(args.json_file, 'r'))
index 61704cf..55bc04d 100644 (file)
@@ -29,6 +29,7 @@
 
 from webkitpy.common.version import Version
 
 
 from webkitpy.common.version import Version
 
+
 class MockPlatformInfo(object):
     def __init__(self, os_name='mac', os_version='snowleopard'):
         self.os_name = os_name
 class MockPlatformInfo(object):
     def __init__(self, os_name='mac', os_version='snowleopard'):
         self.os_name = os_name
index 7f6a3ee..060ea79 100644 (file)
@@ -22,6 +22,7 @@
 
 import collections
 
 
 import collections
 
+
 class Version(object):
 
     def __init__(self, ver='0'):
 class Version(object):
 
     def __init__(self, ver='0'):
index bd811db..7aeb8cf 100644 (file)
@@ -169,6 +169,7 @@ class FailureNotTested(FailureText):
     def message(self):
         return 'test was not run'
 
     def message(self):
         return 'test was not run'
 
+
 class FailureTextMismatch(FailureText):
     def message(self):
         return "text diff"
 class FailureTextMismatch(FailureText):
     def message(self):
         return "text diff"
index ec0de2d..fd2a25b 100644 (file)
@@ -36,6 +36,7 @@ from webkitpy.common.system.outputcapture import OutputCapture
 from webkitpy.tool.mocktool import MockOptions
 from webkitpy.common.system.executive_mock import MockExecutive, MockExecutive2, ScriptError
 
 from webkitpy.tool.mocktool import MockOptions
 from webkitpy.common.system.executive_mock import MockExecutive, MockExecutive2, ScriptError
 
+
 class MacTest(darwin_testcase.DarwinTest):
     os_name = 'mac'
     os_version = 'lion'
 class MacTest(darwin_testcase.DarwinTest):
     os_name = 'mac'
     os_version = 'lion'
index ac2d117..8f31316 100644 (file)
@@ -27,6 +27,7 @@ import time
 from webkitpy.common.timeout_context import Timeout
 from webkitpy.port.server_process import ServerProcess
 
 from webkitpy.common.timeout_context import Timeout
 from webkitpy.port.server_process import ServerProcess
 
+
 class SimulatorProcess(ServerProcess):
 
     class Popen(object):
 class SimulatorProcess(ServerProcess):
 
     class Popen(object):