dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
authordburkart@apple.com <dburkart@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 7 Feb 2015 04:35:30 +0000 (04:35 +0000)
committerdburkart@apple.com <dburkart@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 7 Feb 2015 04:35:30 +0000 (04:35 +0000)
https://bugs.webkit.org/show_bug.cgi?id=141349

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
(BuildbotTesterQueueView.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js
Tools/ChangeLog

index 523fb4f..3425a43 100644 (file)
@@ -79,12 +79,12 @@ BuildbotTesterQueueView.prototype = {
                 } else if (!iteration.productive) {
                     var url = iteration.queue.buildbot.buildPageURLForIteration(iteration);
                     var status = new StatusLineView(messageElement, StatusLineView.Status.Danger, iteration.text, undefined, url);
-                } else if (queue.crashesOnly && !iteration.crashCount) {
+                } else if (queue.crashesOnly && !layoutTestResults.crashCount) {
                     var url = iteration.queue.buildbot.buildPageURLForIteration(iteration);
                     var status = new StatusLineView(messageElement, StatusLineView.Status.Good, "no crashes found", undefined, url);
-                } else if (queue.crashesOnly && iteration.crashCount) {
+                } else if (queue.crashesOnly && layoutTestResults.crashCount) {
                     var url = iteration.queue.buildbot.layoutTestResultsURLForIteration(iteration);
-                    var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, layoutTestResults.failureCount === 1 ? "crash found" : "crashes found", undefined, url);
+                    var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, layoutTestResults.crashCount === 1 ? "crash found" : "crashes found", layoutTestResults.crashCount, url);
                     new PopoverTracker(status.statusBubbleElement, this._presentPopoverForLayoutTestRegressions.bind(this), iteration);
                 } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && !platformAPITestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.errorOccurred && !bindingTestResults.errorOccurred) {
                     // Something wrong happened, but it was not a test failure.
index 337ac04..66560f4 100644 (file)
@@ -1,3 +1,14 @@
+2015-02-06  Dana Burkart  <dburkart@apple.com>
+
+        dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
+        https://bugs.webkit.org/show_bug.cgi?id=141349
+
+        Reviewed by Alexey Proskuryakov.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+        (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
+        (BuildbotTesterQueueView.prototype.update):
+
 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
 
         Report network process crashes during layout tests