[GTK] WebKitWebProcess crashes when viewing an HTML with a <video> element referencin...
authorcturner@igalia.com <cturner@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Aug 2019 12:08:50 +0000 (12:08 +0000)
committercturner@igalia.com <cturner@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Aug 2019 12:08:50 +0000 (12:08 +0000)
https://bugs.webkit.org/show_bug.cgi?id=200530

Reviewed by Xabier Rodriguez-Calvar.

Not amenable to unit testing.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

index d9e1524..1de4c8b 100644 (file)
@@ -1,3 +1,15 @@
+2019-08-08  Charlie Turner  <cturner@igalia.com>
+
+        [GTK] WebKitWebProcess crashes when viewing an HTML with a <video> element referencing unknown file
+        https://bugs.webkit.org/show_bug.cgi?id=200530
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Not amenable to unit testing.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
+
 2019-08-07  Saam Barati  <sbarati@apple.com>
 
         [WHLSL] Prune unreachable stdlib functions after the Checker runs
index 6d7105e..4f36433 100644 (file)
@@ -1647,6 +1647,12 @@ void MediaPlayerPrivateGStreamer::purgeInvalidTextTracks(Vector<String> validTra
 
 void MediaPlayerPrivateGStreamer::fillTimerFired()
 {
+    if (m_errorOccured) {
+        GST_DEBUG_OBJECT(pipeline(), "[Buffering] An error occurred, disabling the fill timer");
+        m_fillTimer.stop();
+        return;
+    }
+
     GRefPtr<GstQuery> query = adoptGRef(gst_query_new_buffering(GST_FORMAT_PERCENT));
     double fillStatus = 100.0;
     GstBufferingMode mode = GST_BUFFERING_DOWNLOAD;