https://bugs.webkit.org/show_bug.cgi?id=140232
<rdar://problem/
19371010>
Reviewed by Anders Carlsson.
Source/WebCore:
We need to support default button styling even when application chrome
mode is not enabled (it was a bit weird that this was exposed as a Setting
anyway). We should render as a default button whenever content sets
the proprietary -webkit-appearance. This means we don't need the
applicationChromeMode setting.
For normal Web content there should be no change in behavior.
* page/Settings.in: Remove applicationChromeMode
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isDefault): Don't test for the setting.
Source/WebKit/mac:
Remove the applicationChromeMode setting, but leave stubs in to make
sure existing binaries don't break.
* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController init]):
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences applicationChromeModeEnabled]):
(-[WebPreferences setApplicationChromeModeEnabled:]):
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit/win:
Remove the applicationChromeMode setting, but leave stubs in to make
sure existing binaries don't break.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::inApplicationChromeMode):
(WebPreferences::setApplicationChromeMode):
* WebView.cpp:
(WebView::notifyPreferencesChanged):
Source/WebKit2:
Remove the applicationChromeMode setting, but leave stubs in to make
sure existing binaries don't break.
* Shared/API/c/WKDeprecatedFunctions.cpp:
(WKPreferencesSetApplicationChromeModeEnabled):
(WKPreferencesGetApplicationChromeModeEnabled):
* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetApplicationChromeModeEnabled): Deleted.
(WKPreferencesGetApplicationChromeModeEnabled): Deleted.
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorPageGroups::createInspectorPageGroup):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@178124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2015-01-08 Dean Jackson <dino@apple.com>
+
+ Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
+ https://bugs.webkit.org/show_bug.cgi?id=140232
+ <rdar://problem/19371010>
+
+ Reviewed by Anders Carlsson.
+
+ We need to support default button styling even when application chrome
+ mode is not enabled (it was a bit weird that this was exposed as a Setting
+ anyway). We should render as a default button whenever content sets
+ the proprietary -webkit-appearance. This means we don't need the
+ applicationChromeMode setting.
+
+ For normal Web content there should be no change in behavior.
+
+ * page/Settings.in: Remove applicationChromeMode
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::isDefault): Don't test for the setting.
+
2015-01-08 Chris Dumez <cdumez@apple.com>
Unfriend StyleResolver and StyleBuilderCustom
syncXHRInDocumentsEnabled initial=true
cookieEnabled initial=true
mediaEnabled initial=true
-applicationChromeMode initial=false
DOMPasteAllowed initial=false
# When enabled, window.blur() does not change focus, and
if (!isActive(o))
return false;
- if (!o.frame().settings().applicationChromeMode())
- return false;
-
return o.style().appearance() == DefaultButtonPart;
}
+2015-01-08 Dean Jackson <dino@apple.com>
+
+ Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
+ https://bugs.webkit.org/show_bug.cgi?id=140232
+ <rdar://problem/19371010>
+
+ Reviewed by Anders Carlsson.
+
+ Remove the applicationChromeMode setting, but leave stubs in to make
+ sure existing binaries don't break.
+
+ * WebCoreSupport/WebInspectorClient.mm:
+ (-[WebInspectorWindowController init]):
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+ (-[WebPreferences applicationChromeModeEnabled]):
+ (-[WebPreferences setApplicationChromeModeEnabled:]):
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
2015-01-07 Daniel Bates <dabates@apple.com>
[iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
WebPreferences *preferences = [[WebPreferences alloc] init];
[preferences setAllowsAnimatedImages:YES];
- [preferences setApplicationChromeModeEnabled:YES];
[preferences setAuthorAndUserStylesEnabled:YES];
[preferences setAutosaves:NO];
[preferences setDefaultFixedFontSize:11];
#define WebKitDeveloperExtrasEnabledPreferenceKey @"WebKitDeveloperExtrasEnabledPreferenceKey"
#define WebKitJavaScriptExperimentsEnabledPreferenceKey @"WebKitJavaScriptExperimentsEnabledPreferenceKey"
#define WebKitAuthorAndUserStylesEnabledPreferenceKey @"WebKitAuthorAndUserStylesEnabledPreferenceKey"
-#define WebKitApplicationChromeModeEnabledPreferenceKey @"WebKitApplicationChromeModeEnabledPreferenceKey"
#define WebKitDOMTimersThrottlingEnabledPreferenceKey @"WebKitDOMTimersThrottlingEnabledPreferenceKey"
#define WebKitWebArchiveDebugModeEnabledPreferenceKey @"WebKitWebArchiveDebugModeEnabledPreferenceKey"
#define WebKitLocalFileContentSniffingEnabledPreferenceKey @"WebKitLocalFileContentSniffingEnabledPreferenceKey"
[NSNumber numberWithBool:NO], WebKitDeveloperExtrasEnabledPreferenceKey,
[NSNumber numberWithBool:NO], WebKitJavaScriptExperimentsEnabledPreferenceKey,
[NSNumber numberWithBool:YES], WebKitAuthorAndUserStylesEnabledPreferenceKey,
- [NSNumber numberWithBool:NO], WebKitApplicationChromeModeEnabledPreferenceKey,
[NSNumber numberWithBool:YES], WebKitDOMTimersThrottlingEnabledPreferenceKey,
[NSNumber numberWithBool:NO], WebKitWebArchiveDebugModeEnabledPreferenceKey,
[NSNumber numberWithBool:NO], WebKitLocalFileContentSniffingEnabledPreferenceKey,
[self _setBoolValue:flag forKey:WebKitAuthorAndUserStylesEnabledPreferenceKey];
}
+// FIXME: applicationChromeMode is no longer needed by ToT, but is still used in Safari 8.
- (BOOL)applicationChromeModeEnabled
{
- return [self _boolValueForKey:WebKitApplicationChromeModeEnabledPreferenceKey];
+ return NO;
}
- (void)setApplicationChromeModeEnabled:(BOOL)flag
{
- [self _setBoolValue:flag forKey:WebKitApplicationChromeModeEnabledPreferenceKey];
}
- (BOOL)domTimersThrottlingEnabled
settings.setDeveloperExtrasEnabled([preferences developerExtrasEnabled]);
settings.setJavaScriptExperimentsEnabled([preferences javaScriptExperimentsEnabled]);
settings.setAuthorAndUserStylesEnabled([preferences authorAndUserStylesEnabled]);
- settings.setApplicationChromeMode([preferences applicationChromeModeEnabled]);
settings.setNeedsSiteSpecificQuirks(_private->useSiteSpecificSpoofing);
settings.setDOMTimersThrottlingEnabled([preferences domTimersThrottlingEnabled]);
+2015-01-08 Dean Jackson <dino@apple.com>
+
+ Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
+ https://bugs.webkit.org/show_bug.cgi?id=140232
+ <rdar://problem/19371010>
+
+ Reviewed by Anders Carlsson.
+
+ Remove the applicationChromeMode setting, but leave stubs in to make
+ sure existing binaries don't break.
+
+ * WebPreferences.cpp:
+ (WebPreferences::initializeDefaultSettings):
+ (WebPreferences::inApplicationChromeMode):
+ (WebPreferences::setApplicationChromeMode):
+ * WebView.cpp:
+ (WebView::notifyPreferencesChanged):
+
2015-01-07 Brent Fulgham <bfulgham@apple.com>
[Win] WindowCloseTimer is an ActiveDOMObject and must call suspendIfNeeded
CFDictionaryAddValue(defaults, CFSTR(WebKitCacheModelPreferenceKey), cacheModelRef.get());
CFDictionaryAddValue(defaults, CFSTR(WebKitAuthorAndUserStylesEnabledPreferenceKey), kCFBooleanTrue);
- CFDictionaryAddValue(defaults, CFSTR(WebKitApplicationChromeModePreferenceKey), kCFBooleanFalse);
CFDictionaryAddValue(defaults, CFSTR(WebKitOfflineWebApplicationCacheEnabledPreferenceKey), kCFBooleanFalse);
return S_OK;
}
-HRESULT WebPreferences::inApplicationChromeMode(BOOL* enabled)
+HRESULT WebPreferences::inApplicationChromeMode(BOOL*)
{
- *enabled = boolValueForKey(WebKitApplicationChromeModePreferenceKey);
return S_OK;
}
-
-HRESULT WebPreferences::setApplicationChromeMode(BOOL enabled)
+
+HRESULT WebPreferences::setApplicationChromeMode(BOOL)
{
- setBoolValue(WebKitApplicationChromeModePreferenceKey, enabled);
return S_OK;
}
settings.setAuthorAndUserStylesEnabled(enabled);
}
- hr = prefsPrivate->inApplicationChromeMode(&enabled);
- if (FAILED(hr))
- return hr;
- settings.setApplicationChromeMode(enabled);
-
hr = prefsPrivate->offlineWebApplicationCacheEnabled(&enabled);
if (FAILED(hr))
return hr;
+2015-01-08 Dean Jackson <dino@apple.com>
+
+ Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
+ https://bugs.webkit.org/show_bug.cgi?id=140232
+ <rdar://problem/19371010>
+
+ Reviewed by Anders Carlsson.
+
+ Remove the applicationChromeMode setting, but leave stubs in to make
+ sure existing binaries don't break.
+
+ * Shared/API/c/WKDeprecatedFunctions.cpp:
+ (WKPreferencesSetApplicationChromeModeEnabled):
+ (WKPreferencesGetApplicationChromeModeEnabled):
+ * Shared/WebPreferencesDefinitions.h:
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetApplicationChromeModeEnabled): Deleted.
+ (WKPreferencesGetApplicationChromeModeEnabled): Deleted.
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+ * UIProcess/WebInspectorProxy.cpp:
+ (WebKit::WebInspectorPageGroups::createInspectorPageGroup):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
2015-01-08 Gwang Yoon Hwang <yoon@igalia.com>
[ThreadedCompositor] Update active animations without interrupting the main-thread
WK_EXPORT void WKPreferencesSetRegionBasedColumnsEnabled(WKPreferencesRef, bool flag);
WK_EXPORT bool WKPreferencesGetRegionBasedColumnsEnabled(WKPreferencesRef);
+WK_EXPORT void WKPreferencesSetApplicationChromeModeEnabled(WKPreferencesRef, bool);
+WK_EXPORT bool WKPreferencesGetApplicationChromeModeEnabled(WKPreferencesRef);
+
WK_EXPORT void WKPreferencesSetMultithreadedWebGLEnabled(WKPreferencesRef, bool);
WK_EXPORT bool WKPreferencesGetMultithreadedWebGLEnabled(WKPreferencesRef);
return false;
}
+void WKPreferencesSetApplicationChromeModeEnabled(WKPreferencesRef, bool)
+{
+}
+
+bool WKPreferencesGetApplicationChromeModeEnabled(WKPreferencesRef)
+{
+ return false;
+}
+
bool WKInspectorIsDebuggingJavaScript(WKInspectorRef)
{
return false;
macro(ShowsToolTipOverTruncatedText, showsToolTipOverTruncatedText, Bool, bool, false) \
macro(MockScrollbarsEnabled, mockScrollbarsEnabled, Bool, bool, false) \
macro(WebAudioEnabled, webAudioEnabled, Bool, bool, true) \
- macro(ApplicationChromeModeEnabled, applicationChromeMode, Bool, bool, false) \
macro(SuppressesIncrementalRendering, suppressesIncrementalRendering, Bool, bool, false) \
macro(BackspaceKeyNavigationEnabled, backspaceKeyNavigationEnabled, Bool, bool, true) \
macro(CaretBrowsingEnabled, caretBrowsingEnabled, Bool, bool, false) \
return toImpl(preferencesRef)->webAudioEnabled();
}
-void WKPreferencesSetApplicationChromeModeEnabled(WKPreferencesRef preferencesRef, bool enabled)
-{
- toImpl(preferencesRef)->setApplicationChromeModeEnabled(enabled);
-}
-
-bool WKPreferencesGetApplicationChromeModeEnabled(WKPreferencesRef preferencesRef)
-{
- return toImpl(preferencesRef)->applicationChromeMode();
-}
-
void WKPreferencesSetInspectorUsesWebKitUserInterface(WKPreferencesRef, bool)
{
// FIXME: Remove once WebKit nightlies don't need to support Safari 6 thru 7.
WK_EXPORT void WKPreferencesSetMockScrollbarsEnabled(WKPreferencesRef preferencesRef, bool flag);
WK_EXPORT bool WKPreferencesGetMockScrollbarsEnabled(WKPreferencesRef preferencesRef);
-// Defaults to false.
-WK_EXPORT void WKPreferencesSetApplicationChromeModeEnabled(WKPreferencesRef preferencesRef, bool enabled);
-WK_EXPORT bool WKPreferencesGetApplicationChromeModeEnabled(WKPreferencesRef preferencesRef);
-
// Deprecated. Always returns false.
WK_EXPORT void WKPreferencesSetInspectorUsesWebKitUserInterface(WKPreferencesRef preferencesRef, bool enabled);
WK_EXPORT bool WKPreferencesGetInspectorUsesWebKitUserInterface(WKPreferencesRef preferencesRef);
#endif
pageGroup->preferences().setAllowFileAccessFromFileURLs(true);
- pageGroup->preferences().setApplicationChromeModeEnabled(true);
return pageGroup.release();
}
settings.setMediaPlaybackAllowsAirPlay(store.getBoolValueForKey(WebPreferencesKey::mediaPlaybackAllowsAirPlayKey()));
#endif
- settings.setApplicationChromeMode(store.getBoolValueForKey(WebPreferencesKey::applicationChromeModeKey()));
settings.setSuppressesIncrementalRendering(store.getBoolValueForKey(WebPreferencesKey::suppressesIncrementalRenderingKey()));
settings.setIncrementalRenderingSuppressionTimeoutInSeconds(store.getDoubleValueForKey(WebPreferencesKey::incrementalRenderingSuppressionTimeoutKey()));
settings.setBackspaceKeyNavigationEnabled(store.getBoolValueForKey(WebPreferencesKey::backspaceKeyNavigationEnabledKey()));